Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Andrea Del Bene
Having a flexible eviction policy would be nice, but if we decide to for this way I would strongly recommend to NOT start implementing our own cache solution. Instead, we should consider to adopt one of the existing solutions (like Guava cache). > > An additional consideration: what about getPage(S

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Martin Grigorov
We could have second impl of org.apache.wicket.pageStore.IPageStore and you can switch them by overriding org.apache.wicket.DefaultPageManagerProvider#newPageStore The question is: how useful this second level cache really is ? The first level cache (all touched pages in the last request cycle be

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Nick Pratt
Would it be possible to make this change available as a switchable option in 6.x (in addition to 7.x), leaving the current store/mechanism in place. The reason I ask is because this seems to be a very significant fundamental change to Wicket, and while the analysis by the original poster was very

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Tom Götz
On 07.03.2014, at 14:14, Martin Grigorov wrote: > On Fri, Mar 7, 2014 at 2:51 PM, Andrea Del Bene wrote: > >> Just my considerations (hopefully not to obvious) on caching inside >> DefaultPageStore.SerializedPagesCache. >> >> -Using a LinkedList instead of ArrayList would bring better performa

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Martin Grigorov
On Fri, Mar 7, 2014 at 2:51 PM, Andrea Del Bene wrote: > Just my considerations (hopefully not to obvious) on caching inside > DefaultPageStore.SerializedPagesCache. > > -Using a LinkedList instead of ArrayList would bring better performances > because we would avoid to recompating (using add/remo

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Andrea Del Bene
Just my considerations (hopefully not to obvious) on caching inside DefaultPageStore.SerializedPagesCache. -Using a LinkedList instead of ArrayList would bring better performances because we would avoid to recompating (using add/remove last/first element) -Doing a deeper refactoring we could use o

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Martin Grigorov
On Fri, Mar 7, 2014 at 1:21 PM, Tom Götz wrote: > Just curious: > in 5527-inefficient-DefaultDataStore branch (8908b8f2) you are now using a > ConcurrentLinkedDeque as a cache. Why not use a map here, e.g. > ConcurrentSkipListMap with entries ordered by a timestamp or whatever? > This is what I'

Re: Inefficient org.apache.wicket.pageStore.DefaultPageStore.SerializedPagesCache

2014-03-07 Thread Tom Götz
Just curious: in 5527-inefficient-DefaultDataStore branch (8908b8f2) you are now using a ConcurrentLinkedDeque as a cache. Why not use a map here, e.g. ConcurrentSkipListMap with entries ordered by a timestamp or whatever? Plus: why is that cache global in terms of that it contains all pages of

Re: A placeholder for header items in page's markup

2014-03-07 Thread Jesse Long
OK, WICKET-5531 Thanks, Jesse On 07/03/2014 11:42, Martin Grigorov wrote: Hi Jesse, I have forgotten about this discussion... Please create a ticket and we will try to implement it. Thanks! Martin Grigorov Wicket Training and Consulting On Fri, Mar 7, 2014 at 11:35 AM, Jesse Long wrote:

Re: A placeholder for header items in page's markup

2014-03-07 Thread Martin Grigorov
Hi Jesse, I have forgotten about this discussion... Please create a ticket and we will try to implement it. Thanks! Martin Grigorov Wicket Training and Consulting On Fri, Mar 7, 2014 at 11:35 AM, Jesse Long wrote: > Hi Martin, > > Any news about the feature discussed below? At the time I thou

Re: A placeholder for header items in page's markup

2014-03-07 Thread Jesse Long
Hi Martin, Any news about the feature discussed below? At the time I thought it was a good idea, and today I have a perfect use case for it. Is it still planned? Thanks, Jesse On 19/04/2013 16:43, Sven Meier wrote: My idea was to support only in . Ok, understood. Sven On 04/19/2013 03: