Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/114#issuecomment-90409380
Hi,
I see this PR introduces some API changes.
We want to release Wicket 7.0.0 next week so I am a bit hesitant to merge
it.
Please start a discussion
This is a vote to release the wicket-eclipse-settings version 2.
Version 2 uses JDK 1.7 and should be used by Wicket 7.x
Wicket Eclipse Settings is a project to specify Eclipse settings for a
uniform development environment between all Eclipse using Wicket Team
members. Most notably the
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-90512131
Hi @Fogetti ,
Do you want me to improve the PR myself and merge it?
---
If your project is set up for it, you can reply to this email and have your
reply
+1 release
On Tuesday 07 April 2015 14:20:50 Martin Grigorov wrote:
This is a vote to release the wicket-eclipse-settings version 2.
Version 2 uses JDK 1.7 and should be used by Wicket 7.x
Wicket Eclipse Settings is a project to specify Eclipse settings for a
uniform development environment
[+1] Yes, release it!
On 07/04/2015 13:20, Martin Grigorov wrote:
This is a vote to release the wicket-eclipse-settings version 2.
Version 2 uses JDK 1.7 and should be used by Wicket 7.x
Wicket Eclipse Settings is a project to specify Eclipse settings for a
uniform development environment
Github user Fogetti commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r27885190
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
---
@@ -155,6 +168,57 @@
+1
kind regards
Tobias
Am 07.04.2015 um 13:20 schrieb Martin Grigorov mgrigo...@apache.org:
This is a vote to release the wicket-eclipse-settings version 2.
Version 2 uses JDK 1.7 and should be used by Wicket 7.x
Wicket Eclipse Settings is a project to specify Eclipse settings for a
Github user Fogetti commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r27885257
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/message/AbortedMessage.java
---
@@ -0,0 +1,56
Github user Fogetti commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-90594677
Hi Martin!
Sorry for the late reply. I made the improvements. Would you be so kind to
take a look at the new set of changed files?
I made the changes
