This change causes a NPE in our unit tests (regression)--in M5 the
tests ran as expected:
java.lang.NullPointerException
at
org.apache.wicket.markup.parser.AbstractMarkupFilter.getRequestUniqueId(AbstractMarkupFilter.java:211)
at
org.apache.wicket.markup.parser.filter.EnclosureHandler.onComponen
Github user selckin commented on the pull request:
https://github.com/apache/wicket/pull/114#issuecomment-108387157
Now with less api changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Hi,
InlineImage seems useful, but OutputField isn't finished yet:
IMHO you're putting too much logic into that tag - actually it offers
nothing more than a little semantics.
Regards
Sven
On 03.06.2015 07:39, Tobias Soloschenko wrote:
Hi,
this is just a vote if we should move / integrate th
Hi,
I tried to make the input-output roundtrip as easy as possible that's why I put
in the logic. If you have suggestions how to reduce the logic and provide more
flexibility I would be very pleased.
kind regards
Tobias
> Am 03.06.2015 um 15:06 schrieb Sven Meier :
>
> Hi,
>
> InlineImage
Hi,
I didn't have time to review the PR for OutputField but from what I've seen
while debugging your problem with the reset of its value - I didn't like
it. Sorry! :-)
I hope to have some time tonight for the review.
To keep the result/output value up to date in the browser I'd use something
like
Me I am sad about little OutputField ;-( - ok - to sum
+1 for InlineImage
-1 for OutputField
I'm going to integrate InlineImage tomorrow. :-)
kind regards
Tobias
> Am 03.06.2015 um 16:46 schrieb Martin Grigorov :
>
> Hi,
>
> I didn't have time to review the PR for OutputField but from w
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/123#issuecomment-108586006
Moved to https://github.com/klopfdreh/wicket-components-playground -
further changes there to not keep PRs opened
---
If your project is set up for it, you can reply
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/124
InlineImage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket Inline_Image
Alternatively you can review and apply these change
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/125
InlineImage
I noticed an exception at
org.apache.wicket.markup.html.form.upload.MultiFileUploadFieldTest:
Caused by: org.junit.ComparisonFailure:
expected:<...iFileUploadFieldTest[1].txt
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/124#discussion_r31666828
--- Diff:
wicket-core/src/test/java/org/apache/wicket/markup/html/image/InlineImageTest.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Sof
Hi,
done - two pull request for InlineImage with docs, examples, unit tests
and refactoring to keep the base64 encoding stuff at one place.
Reviewers are welcome. ;-)
kind regards
Tobias
P.S.: I am going to keep the OutputField in my repository and improve it
a bit more.
Am 03.06.15 um 1
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/124#issuecomment-108607617
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/124#discussion_r31666998
--- Diff:
wicket-core/src/test/java/org/apache/wicket/markup/html/image/InlineImageTest.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache So
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/124#issuecomment-108611701
Thanks for the fast review! :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
15 matches
Mail list logo
