Fwd: wicket git commit: WICKET-6194 PushHeaderItem handles client side cache

2016-08-17 Thread Tobias Soloschenko
Hi, yesterday I did some research and made some notes - here they are: I had a look at your suggestions and I found out that within a header item we can't use RequestCycle.get(), because it does not return the actual page request / response within the renderHead method. Thats the reason why I us

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Martijn Dashorst
Sounds good to me Martijn On Wednesday, 17 August 2016, Martin Grigorov wrote: > Hi, > > What do you think on adding a new setting to ExceptionSettings that says > whether to log a WARN (default, as it does now) or to throw exception when > setOutputMarkupId/setOutputMarkupPlaceholderTag() are

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Sebastien
+1 too On Aug 17, 2016 21:24, "Carl-Eric Menzel" wrote: > +1 for that. > > On Wed, 17 Aug 2016 14:59:03 +0700 > Maxim Solodovnik wrote: > > > +1 for "throw an exception in DEV mode and log a WARN in PROD mode" > > > > On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov > > wrote: > > > > > Hi, >

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Carl-Eric Menzel
+1 for that. On Wed, 17 Aug 2016 14:59:03 +0700 Maxim Solodovnik wrote: > +1 for "throw an exception in DEV mode and log a WARN in PROD mode" > > On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov > wrote: > > > Hi, > > > > What do you think on adding a new setting to ExceptionSettings that > >

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Sven Meier
+1 Sven On 17.08.2016 09:59, Maxim Solodovnik wrote: +1 for "throw an exception in DEV mode and log a WARN in PROD mode" On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov wrote: Hi, What do you think on adding a new setting to ExceptionSettings that says whether to log a WARN (default, as

[GitHub] wicket issue #177: Expensive validator wicket 7.x

2016-08-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/177 Another Wicket developer commented in the dev@ mailing list: http://markmail.org/message/o3qsaetsloo73lwt --- If your project is set up for it, you can reply to this email and have your reply appea

Re: [GitHub] wicket issue #177: Expensive validator wicket 7.x

2016-08-17 Thread Emond Papegaaij
Hi, I agree. This is best implemented as part of the validator. You could for example create a validator decorator that only forwards the calls to the actual validator when expensive validation is required. This condition can depend on many factors, but in your case, you could check if the curr

[GitHub] wicket issue #176: Expensive validator wicket 8.x

2016-08-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/176 X-Ref: https://github.com/apache/wicket/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] wicket issue #177: Expensive validator wicket 7.x

2016-08-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/177 Thank you for your contribution! I am not sure it is a good idea, though. With this change we will make all Ajax form component submits "non-expensive", i.e. a subset of validator will b

Re: Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Maxim Solodovnik
+1 for "throw an exception in DEV mode and log a WARN in PROD mode" On Wed, Aug 17, 2016 at 2:56 PM, Martin Grigorov wrote: > Hi, > > What do you think on adding a new setting to ExceptionSettings that says > whether to log a WARN (default, as it does now) or to throw exception when > setOutputM

Throw exception when setOutputMarkupId() on non-renderable component

2016-08-17 Thread Martin Grigorov
Hi, What do you think on adding a new setting to ExceptionSettings that says whether to log a WARN (default, as it does now) or to throw exception when setOutputMarkupId/setOutputMarkupPlaceholderTag() are used on component with #setRenderBodyOnly(true) or attached to ? I've had few occasions in

[ANNOUNCE] WicketStuff 8.0.0-M1 Released

2016-08-17 Thread Martin Grigorov
WicketStuff core 8.0.0-M1 based on Apache Wicket 8.0.0-M1 is released and soon will be available at Maven Central! This release is almost the same as 7.4.0 but built againt Wicket 8.0.0-M1. The changelog since 7.4.0 is: Martin Tzvetanov Grigorov (45): 'master' branch builds against Wicket