[GitHub] wicket issue #193: WICKET-6287 Switch from json.org to open-json - 8.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/193 Summary before integration: * json.org is replaced with open-json, now * Because Apache Wicket 8 is at milestone level API changes are allowed and because of this all JSON library

[GitHub] wicket issue #194: WICKET-6287 Switch from json.org to open-json - 6.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/194 Summary before integration: * json.org is replaced with open-json, now * Method calls not supported by open-json throw a WicketRuntimeException to inform the user * If users still

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 Summary before integration: * json.org is replaced with open-json, now * Method calls not supported by open-json throw a WicketRuntimeException to inform the user * If the users

[GitHub] wicket issue #194: WICKET-6287 Switch from json.org to open-json - 6.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/194 Hi @martin-g - this was because Objects.hashCode is only available since idk > 7. I replaced the call with a return 0; - this is done by Objects.hashCode(null) anyway. I also

[GitHub] wicket issue #194: WICKET-6287 Switch from json.org to open-json - 6.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/194 Hi @martin-g - thanks for the hint - I am going to have a look at it, soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 Haha @duesenklipper - you wrote a bit earlier - yep I know the CssUrlReplacer and @martin-g , too. We implemented it 😊 --- If your project is set up for it, you can reply to this email and

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 I don't think this is regarding the JSON change. The String is to long and it is a different as the expected one and the CssUrlReplacer don't use JSON at all (only regex) - maybe it has something

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 @klopfdreh I don't think it does. It appears to be a problem on @martin-g's machine. The JSON stuff doesn't even come close to CssUrlReplacer. --- If your project is set up for it, you can

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 To come to the point: In which way the JSON lib change affects CssUrlReplacerTest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 Oh, you mean a problem on your machine? If that's the case, I'll stop trying to recreate it here ;-) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/195 I was saying that if BuildBot is fine (at wicket-core) then the problem must be here. The problem with Arquillian is known. It waits someone to debug it. Too bad the JavaEE fans do not give it

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/195 The problem seems to be here. BuildBot passes the build until Arquilian tests: https://ci.apache.org/builders/wicket-branch-7.x/builds/333 --- If your project is set up for it, you can reply

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 (I ran `mvn clean package`) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 I figured out to do $ git fetch github-upstream refs/pull/195/head $ git checkout FETCH_HEAD From that I got commit 4dbdbdfe, and that builds cleanly for me. I also tried

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 This might be a stupid question, but I must be missing something. How do I check out the pull request branch? --- If your project is set up for it, you can reply to this email and have your

Re: Multi-tab / window support in Wicket 7.5

2016-12-07 Thread Martin Grigorov
Could you please expand on "and you do not want to make custom logic to allow multi window/tab (in browser)" ? How exactly Wicket prevents the "multi browser tabs/windows" ? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Dec 7, 2016 at 1:37 PM, Martin

Re: Multi-tab / window support in Wicket 7.5

2016-12-07 Thread Martin Makundi
If one makes a single-page application that has multiple tabs (within one browser window), and you do not want to make custom logic to allow multi window/tab (in browser) management into session, it would work best if there was separate "session" for each browser tab/window inside wicket.

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/195 Compilation and Clirr pass but a test fails: ``` Failed tests: CssUrlReplacerTest.base64EncodedImage:165->Assert.assertThat:923->Assert.assertThat:956 Expected: a string

[GitHub] wicket issue #194: WICKET-6287 Switch from json.org to open-json - 6.x

2016-12-07 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/194 This PR fails with: ``` [INFO] [ERROR] Failed to execute goal

[GitHub] wicket issue #194: WICKET-6287 Switch from json.org to open-json - 6.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/194 @martin-g , @dashorst , @bitstorm - would you be so kind and review the changes / check if there are no clirr issues for the 6.x branch? I don't have jdk 6 / jdk 7 installed so I get a "Invalid

[GitHub] wicket issue #194: WICKET-6287 Switch from json.org to open-json - 6.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/194 Hi @solomax , I managed to resolve the clirr issues: https://github.com/apache/wicket/pull/195#issuecomment-265422034 --- If your project is set up for it, you can reply to this email

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 I managed to resolve the clirr issues. What I did was: * Revert back all class signatures that were copied from json.org and throw a corresponding exception to inform users about the

Re: Multi-tab / window support in Wicket 7.5

2016-12-07 Thread Martin Makundi
This should be built into wicket core, automatic session management. Login once and enable multiple tabs and a new sub-session for each tab. If user logs out from any of the sessions, all would be invalidated. Not sure if this exists yet, but would be needed. ** Martin 2016-12-07 12:59

Updating Columns of datatable by Ajax

2016-12-07 Thread Christoph.Manig
Hello I want to create a datatable which contains 2 columns. The first column should represent a state (started/stopped) and the second one should contain a button which depends on the state of the first column (start button / stop button). If the state is started the stop button should be