Hi Dieter,
I've made some comments and approved the PR. Mostly minor things.
I've also invited you to the WicketStuff collaborators team so you can
commit in the repo, and merge PRs.
You can still use PRs for your contributions when you want someone else to
take a look before applying the changes.
Hello Dieter,
I had no time to check this "in action" :(
Will try to during weekend
On Wed, Aug 23, 2017 at 11:36 PM, Dieter Tremel
wrote:
> Hi,
>
> sorry for my lack of experience with pull requests.
>
> Did you have time to look at the sources?
>
> Is there anything expected from me now? What
Hi,
sorry for my lack of experience with pull requests.
Did you have time to look at the sources?
Is there anything expected from me now? What are the next steps?
What issues to solve do you see?
Dieter
Am 13.08.2017 um 12:56 schrieb Martin Grigorov:
> Hi Dieter,
>
> Are Google Charts version
Perfect, thank you.
On 08/23/2017 11:00 AM, Andrea Del Bene wrote:
I've created an issue: https://issues.apache.org/jira/browse/WICKET-6455
On Mon, Aug 21, 2017 at 5:43 PM, Andrea Del Bene
wrote:
To avoid changing wantSubmitOnParentFormSubmit visibility we can use
isSubmitted to check if th
I've created an issue: https://issues.apache.org/jira/browse/WICKET-6455
On Mon, Aug 21, 2017 at 5:43 PM, Andrea Del Bene
wrote:
> To avoid changing wantSubmitOnParentFormSubmit visibility we can use
> isSubmitted to check if the target form has been submitted:
>
> @Override
> protected
