+1
On Oct 2, 2017 14:53, "Maxim Solodovnik" wrote:
> I'll change the list and the question :)))
>
> WebSocketTester seems to be not usable in case Application is not destroyed
> after it was used once
> due to call to "webApplication.getWicketFilter().setFilterPath("");"
https://github.com/apache/wicket/pull/236
On Tue, Oct 3, 2017 at 12:54 PM, Martin Grigorov
wrote:
> +1
>
> On Oct 2, 2017 14:53, "Maxim Solodovnik" wrote:
>
> > I'll change the list and the question :)))
> >
> > WebSocketTester seems to be not
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/236
[WICKET-6476] check is added while setting filter path to prevent excâ¦
â¦eption
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket
I'll change the list and the question :)))
WebSocketTester seems to be not usable in case Application is not destroyed
after it was used once
due to call to "webApplication.getWicketFilter().setFilterPath("");" in
constructor
I'm going to create PR against `master` to improve this situation.
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
I'll create `org.apache.wicket.examples.datetime` later tonight taking
`org.apache.wicket.examples.captcha` as reference :)
---
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/235
We should show the usage of these 'new' components in wicket-examples,
under "component reference".
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/235
old date examples are still available at wicketstuff, what is "example's
compref"?
---
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142088563
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,278 @@
+/*
+ *
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142088478
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateLabel.java
---
@@ -227,14 +216,10 @@ public
Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142083823
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateLabel.java
---
@@ -227,14 +216,10 @@ public
Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142085534
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,278 @@
+/*
+ *
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076722
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,288 @@
+/*
+ *
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076750
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/IDateConverter.java
---
@@ -0,0 +1,53 @@
+/*
+ *
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076776
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/StyleTimeConverter.java
---
@@ -0,0 +1,118 @@
+/*
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076656
--- Diff: pom.xml ---
@@ -89,7 +89,6 @@
wicket
wicket-core
wicket-util
- wicket-datetime
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142076708
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,288 @@
+/*
+ *
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142068804
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/StyleTimeConverter.java
---
@@ -0,0 +1,118 @@
+/*
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142068495
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/IDateConverter.java
---
@@ -0,0 +1,53 @@
+/*
+ *
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142068292
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/IDateConverter.java
---
@@ -0,0 +1,53 @@
+/*
+ *
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142068371
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/IDateConverter.java
---
@@ -0,0 +1,53 @@
+/*
+ *
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142068252
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,288 @@
+/*
+ *
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142068241
--- Diff:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/DateTimeField.java
---
@@ -0,0 +1,288 @@
+/*
+ *
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/235#discussion_r142067840
--- Diff: pom.xml ---
@@ -89,7 +89,6 @@
wicket
wicket-core
wicket-util
- wicket-datetime
23 matches
Mail list logo