Re: Analyze Wicket builds with Sonar

2017-11-09 Thread Tobias Soloschenko
+1 :-) kind regards Tobias > Am 10.11.2017 um 06:21 schrieb Maxim Solodovnik : > > Hello All, > > Maybe it worth to add Sonar analysis to Wicket builds? > It is available at Apache build servers: https://builds.apache.org/analysis/ > > > -- > WBR > Maxim aka solomax

[GitHub] wicket issue #243: Added Czech localization for Wizard

2017-11-09 Thread vrozkovec
Github user vrozkovec commented on the issue: https://github.com/apache/wicket/pull/243 Done ---

Analyze Wicket builds with Sonar

2017-11-09 Thread Maxim Solodovnik
Hello All, Maybe it worth to add Sonar analysis to Wicket builds? It is available at Apache build servers: https://builds.apache.org/analysis/ -- WBR Maxim aka solomax

[GitHub] wicket issue #244: [WICKET-6491] ajax download seems to work under both IE11...

2017-11-09 Thread solomax
Github user solomax commented on the issue: https://github.com/apache/wicket/pull/244 @svenmeier I reverted my changes to AjaxDownloadBehavior.java, thanks for catching this :) ---

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread solomax
Github user solomax commented on a diff in the pull request: https://github.com/apache/wicket/pull/244#discussion_r150018189 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/AjaxDownloadBehavior.java --- @@ -323,10 +323,30 @@ private String getName()

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread svenmeier
Github user svenmeier commented on a diff in the pull request: https://github.com/apache/wicket/pull/244#discussion_r150014533 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/AjaxDownloadBehavior.java --- @@ -323,10 +323,30 @@ private String getName()

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread solomax
Github user solomax commented on a diff in the pull request: https://github.com/apache/wicket/pull/244#discussion_r150012308 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/AjaxDownloadBehavior.java --- @@ -323,10 +323,30 @@ private String getName()

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/244#discussion_r149995282 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/wicket-ajaxdownload.js --- @@ -108,29 +108,32 @@

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread solomax
Github user solomax commented on a diff in the pull request: https://github.com/apache/wicket/pull/244#discussion_r149991409 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/wicket-ajaxdownload.js --- @@ -108,29 +108,32 @@

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/244#discussion_r149970025 --- Diff: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/wicket-ajaxdownload.js --- @@ -108,29 +108,32 @@

[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-09 Thread solomax
GitHub user solomax opened a pull request: https://github.com/apache/wicket/pull/244 [WICKET-6491] ajax download seems to work under both IE11 and Edge I would appreciate if someone can review my changes You can merge this pull request into a Git repository by running: $ git

[GitHub] wicket issue #242: WICKET-6490

2017-11-09 Thread bitstorm
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 That's the DebugBar. Honestly even to me It's not very clear who is using it and what its purpose is,but it was already there in the old examples version. We might consider to remove it if it is