[GitHub] wicket pull request #244: [WICKET-6491] ajax download seems to work under bo...

2017-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/244 ---

[GitHub] wicket issue #244: [WICKET-6491] ajax download seems to work under both IE11...

2017-11-10 Thread solomax
Github user solomax commented on the issue: https://github.com/apache/wicket/pull/244 Is it OK to merge this PR? ---

Re: Analyze Wicket builds with Sonar

2017-11-10 Thread Maxim Solodovnik
I'll check if it will be possible to create/customize sonar profile On Fri, Nov 10, 2017 at 5:27 PM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > Only if you tweak sonar config such that we don't have to rework our source > code. Sonar's defaults are awful and should not be used by

Re: Analyze Wicket builds with Sonar

2017-11-10 Thread Martijn Dashorst
Only if you tweak sonar config such that we don't have to rework our source code. Sonar's defaults are awful and should not be used by any serious developer. I weep whenever I see someone extract a private method to get a method from cyclomatic complexity of 8 to 6 (aka the "sweep shit under the