I'll try to test WICKET-6498 today/tomorrow
On Sun, Dec 31, 2017 at 5:04 PM, Martijn Dashorst <
martijn.dasho...@gmail.com> wrote:
> I’m working on restyling the QuickStart to look like the new examples. Not
> a blocker but would be awesome to include. Will work on it 2nd Jan
>
> Martijn
>
>
>
>
Hi Maxim,
I don't think WICKET-6498 will be part of Wicket 8:
There are still conceptual open questions (who decides what resources to defer)
and implementation issues, i.e. does the proposed solution with
addEventListener work in all browsers.
Thanks for testing this.
Sven
Gesendet mit Blue
Hello Sven,
I would like to test using out main app, since initial version seems to be
more performant
And I believe this would be good way to improve my wicket skills :))
On Tue, Jan 2, 2018 at 4:57 PM, Sven Meier wrote:
> Hi Maxim,
>
> I don't think WICKET-6498 will be part of Wicket 8:
GitHub user svenmeier opened a pull request:
https://github.com/apache/wicket/pull/253
WICKET-6498 deferred javascript
If addEventListener is used instead of jQuery "domready" and "load"
events, and OnLoadHeaderItem instead of JavaScriptHeaderItem, all JavaScript
resources can be
May I ask why not a simple Config option? When disabled current behaviour
(default) but when turned on new behaviour? That way it wont break anything and
may be added to wicket any time?
I just ask because this "not in that version" etc. usually is the reason why
some Frameworks seems less acti
If configuration option is final solution then yes, otherwise it opens a
new can of worms for backwards (and on-site branching) compatibility.
**
Martin
+0.02
2018-01-02 12:29 GMT+02:00 Korbinian Bachl :
> May I ask why not a simple Config option? When disabled current behaviour
> (default) but
Please take a look at the pull request:
https://github.com/apache/wicket/pull/253
As you can see, there are many places that have to work together - do
you see a good way to make that configurable?
I'd prefer to support a single solution only:
addEventListener() instead of jQuery "domready"
Hi,
1) one can always replace the version with JavaScriptLibrarySettings
2.x is used as default because most jQuery plugins are not migrated to 3.x,
JS folks moved to more modern JS solutions (React, Angular, Vue, ...)
2) wicket-ajax-*jquery*.js is named this way because it depends on jQuery!
One
Hi,
I just reviewed it and added some notes.
kind regards
Tobias
> Am 02.01.2018 um 11:28 schrieb svenmeier :
>
> GitHub user svenmeier opened a pull request:
>
>https://github.com/apache/wicket/pull/253
>
>WICKET-6498 deferred javascript
>
>If addEventListener is used instead o
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159220270
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final Component
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159219467
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/OnLoadHeaderItem.java
---
@@ -86,8 +86,8 @@ public void render(Response response)
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159220379
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CoreLibrariesContributor.java
---
@@ -63,8 +64,7 @@ public static void contributeAjax(final
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159286930
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CoreLibrariesContributor.java
---
@@ -63,8 +64,7 @@ public static void contributeAjax(final
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159286873
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final Component
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159287015
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/OnLoadHeaderItem.java
---
@@ -86,8 +86,8 @@ public void render(Response response)
Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159297861
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/OnLoadHeaderItem.java
---
@@ -86,8 +86,8 @@ public void render(Response response)
GitHub user andruhon opened a pull request:
https://github.com/apache/wicket/pull/254
provide more information on read only LambdaModel setObject exception
It is sometimes hard to find which model is misused as ReadOnly model when
it should be a ReadWrite one, because the Unsupporte
17 matches
Mail list logo
