Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r162726991
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/filter/FilteringHeaderResponse.java
---
@@ -263,14 +262,12 @@ public void markRendered(O
Hello All,
I was able to fix all tests broken by this PR
https://github.com/apache/wicket/pull/253
Except for FilteringHeaderResponseTest (
https://github.com/apache/wicket/pull/253#pullrequestreview-88658254)
Can someone take a look at it please?
--
WBR
Maxim aka solomax
Thank you!
On Jan 19, 2018 10:24 AM, "Sven Meier" wrote:
> Hi Andrea,
>
> I've tried to limit my clean-up to internal methods, i.e. those marked
> with "THIS METHOD IS NOT ... PUBLIC .. DO NOT CALL IT!".
>
> I see now that #onAfterRenderChildren() was protected and not marked as
> internal, but
Hi Andrea,
I've tried to limit my clean-up to internal methods, i.e. those marked
with "THIS METHOD IS NOT ... PUBLIC .. DO NOT CALL IT!".
I see now that #onAfterRenderChildren() was protected and not marked as
internal, but IMHO it wasn't meant to be overriden by users anyway.
I'll add a s
Hi,
I've noted that the last commit for WICKET-6503 wiped out some hook methods
from Component and MarkupContainer classes (for example
MarkupContainer#onAfterRenderChildren). Is there a migration strategy for
this change?
Andrea.
Github user andruhon closed the pull request at:
https://github.com/apache/wicket/pull/255
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/255
Hi,
is this PR reflection a subset of changes of:
https://github.com/apache/wicket/pull/256?
If yes we might consider to close this one and continue it in only one PR.
Tha