[GitHub] wicket pull request #274: [WICKET-6546] HTML comments are removed from inlin...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/274 ---

Re: [DISCUSSION] WICKET-6544 mobile browser detection

2018-04-05 Thread Tobias Soloschenko
-1 for dropping agent detection +1 for adding a dependency to an external library (because of the big pool of browsers - which might increase in future) kind regards Tobias > Am 05.04.2018 um 13:44 schrieb Sven Meier : > > +0 for dropping agent detection (3) > -1 for adding a dependency to an

[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved

2018-04-05 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/269 In my opinion and because of such a big pool of browsers I would say yes. ---

Re: [DISCUSSION] WICKET-6544 mobile browser detection

2018-04-05 Thread Sven Meier
+0 for dropping agent detection (3) -1 for adding a dependency to an external library Sven Am 3. April 2018 16:34:15 MESZ schrieb Maxim Solodovnik : >It seems the discussion is spread between this thread and the JIRA >https://issues.apache.org/jira/browse/WICKET-6544?focusedCommentId=16423835&pag

[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved

2018-04-05 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/269 Guys I get it, there are many good solutions to choose from, but why should we make Wicket dependent on anyone of them? https://github.com/nielsbasjes/yauaa looks good, but do users really

[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved

2018-04-05 Thread klopfdreh
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/269 I just tested a bit around and I would suggest the following changes: * Drop the support for minor version in exchange for a full version String (11.0, 3.5.8, 4.0b4a) * Change the imple