Re: wicketstuff failing master build

2018-06-22 Thread Andrea Del Bene
I've found something that might be interesting. Java 10 contains a fix about Calendar#getFirstDayOfWeek(): https://bugs.openjdk.java.net/browse/JDK-8185841 To get the first day of the week DatePicker uses the following code: protected int getFirstDayOfWeek(Locale locale) {   return Calendar.ge

Re: wicketstuff failing master build

2018-06-22 Thread Andrea Del Bene
I don't know if the two things are related (they don't look to me), but yesterday I've refactored Wicket 9 to remove many deprecated classes from wicket-core. You can try to run the build locally updating the 9.0.0-SNAPSHOT dependencies. On Fri, Jun 22, 2018 at 2:35 PM, Maxim Solodovnik wrote: >

Re: [DISCUSSION] WICKET-6544 mobile browser detection

2018-06-22 Thread Tobias Soloschenko
I think we should turn off the gatherExtendedBrowserInformation by default and give a hint that there is a synchronisation point of 0,011 ms when turned on, but the detection is much more reliable with the new implementation. kind regards Tobias > Am 22.06.2018 um 11:49 schrieb Maxim Solodovni

Re: wicketstuff failing master build

2018-06-22 Thread Maxim Solodovnik
Both failed :( WBR, Maxim (from mobile, sorry for the typos) On Fri, Jun 22, 2018, 18:15 Maxim Solodovnik wrote: > Was able to run the build with 2 java10: > https://travis-ci.org/wicketstuff/core > Lets check the results :) > > On Fri, Jun 22, 2018 at 5:30 PM Andrea Del Bene > wrote: > >> May

Re: wicketstuff failing master build

2018-06-22 Thread Maxim Solodovnik
Was able to run the build with 2 java10: https://travis-ci.org/wicketstuff/core Lets check the results :) On Fri, Jun 22, 2018 at 5:30 PM Andrea Del Bene wrote: > Maybe the type of JDK is irrelevant but still, that's what I noted so > far... > > On Fri, Jun 22, 2018 at 12:27 PM, Maxim Solodovnik

Re: wicketstuff failing master build

2018-06-22 Thread Andrea Del Bene
Maybe the type of JDK is irrelevant but still, that's what I noted so far... On Fri, Jun 22, 2018 at 12:27 PM, Maxim Solodovnik wrote: > Travis has OpenJDK, will add OracleJDK to compare :) > > On Fri, Jun 22, 2018 at 5:26 PM Andrea Del Bene > wrote: > > > Hi, > > > > build fails on my local ma

Re: wicketstuff failing master build

2018-06-22 Thread Maxim Solodovnik
Travis has OpenJDK, will add OracleJDK to compare :) On Fri, Jun 22, 2018 at 5:26 PM Andrea Del Bene wrote: > Hi, > > build fails on my local machine with the same error. I've successfully > build the project few days ago on another machine. On the failing machine > I've got an Oracle JDK while

Re: wicketstuff failing master build

2018-06-22 Thread Andrea Del Bene
Hi, build fails on my local machine with the same error. I've successfully build the project few days ago on another machine. On the failing machine I've got an Oracle JDK while on the other one I have an OpenJDK distribution. I will try to investigate further as soon as possible. On Fri, Jun 22,

Re: [DISCUSSION] WICKET-6544 mobile browser detection

2018-06-22 Thread Maxim Solodovnik
Is it time to resume this discussion? We still have PR unmerged, and don't have agreement what to do next :( On Tue, Apr 10, 2018 at 3:08 AM Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > :-D > > kind regards > > Tobias > > > Am 09.04.2018 um 19:14 schrieb Sven Meier : > > > > bi

wicketstuff failing master build

2018-06-22 Thread Maxim Solodovnik
Hello All, I have build failed for wicketstuff/master after switching to Java10 Here is the error: [ERROR] test1(org.wicketstuff.datetime.extensions.yui.calendar.DatePickerTest) Time elapsed: 0.269 s <<< FAILURE! org.junit.ComparisonFailure: org/wicketstuff/datetime/extensions/yui/calendar/Dat