GitHub user renoth opened a pull request:
https://github.com/apache/wicket/pull/287
Considering upgrading to Junit5
Proof of concept of the upgrade to Junit5:
Thanks for the quick reply, i supplied the changes to WicketTester to
remove the junit4 dependencies, i think TagTe
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206493069
--- Diff:
wicket-util/src/main/java/org/apache/wicket/util/markup/xhtml/WellFormedXmlTestCase.java
---
@@ -16,23 +16,18 @@
*/
package org.apache.
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206493340
--- Diff:
wicket-util/src/test/java/org/apache/wicket/util/collections/IntHashMapTest.java
---
@@ -48,9 +46,9 @@ public void serialize() throws IOException,
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206492111
--- Diff:
wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java ---
@@ -54,14 +38,24 @@
import org.apache.wicket.request.mapper.para
Github user renoth commented on a diff in the pull request:
https://github.com/apache/wicket/pull/287#discussion_r206494911
--- Diff:
wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTester.java ---
@@ -54,14 +38,24 @@
import org.apache.wicket.request.mapper.param
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/285
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/285
This PR has been merged and can be closed.
Thanks a lot for the changes!
---
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/284
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/284
This PR has been merged.
Thanks a lot for the changes!
---
Github user try0 commented on the issue:
https://github.com/apache/wicket/pull/284
Hi @klopfdreh
Thank you for merging this PR.
---
10 matches
Mail list logo
