Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/343#discussion_r238198570
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
---
@@ -161,19 +161,19 @@ public final void onComponen
Github user svenmeier commented on a diff in the pull request:
https://github.com/apache/wicket/pull/343#discussion_r238201851
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -2116,10 +2116,15 @@
// Adds
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/343#discussion_r238202582
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -2116,10 +2116,15 @@
// Adds th
Github user bitstorm commented on the issue:
https://github.com/apache/wicket/pull/342
@svenmeier sorry, what I said wasn't correct. By calling onDetach we don't
discard the current page instance but we force configuration phase to be
performed again before the actual rendering phase,
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/342
Ok, you're right, that would be an improvement.
IMHO this change is to big to introduce in a 8.x release though.
I'd say we revert WICKET-6608 (which as is allows even more components to
Github user bitstorm commented on the issue:
https://github.com/apache/wicket/pull/342
Sounds good to me
---
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/342
This needs a thorough discussion of a solution for 9.x.
---
Github user svenmeier closed the pull request at:
https://github.com/apache/wicket/pull/342
---
