Re: [DISSCUSSION] can we drop wicketstuff-pushd*

+1 to drop it! If someone uses it then (s)he can use the old releases and send a PR later to revive it! On Fri, Apr 1, 2022 at 5:20 AM Maxim Solodovnik wrote: > Hello All, > > AFAIK these days push is available out-of-the-box via websockets > Do we need all these components? > > If we do need t

[DISSCUSSION] can we drop wicketstuff-pushd*

Hello All, AFAIK these days push is available out-of-the-box via websockets Do we need all these components? If we do need them can anyone take a look at `push-cometd`? cometd-java-client/cometd-java-server seems to be changed a lot and the version we are currently using reported to be vulnerable

Build failed in Jenkins: Wicket » wicket-9.x #104

See Changes: [thomas.heigl] Revert "WICKET-6963 Use singletons for PanelMarkupSourcingStrategy (#503)" -- [...truncated 2.59 MB...] [INFO] Copying 3 resources [IN

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

It's just a single commit. I have reverted it for both 9.x and master. Best, Thomas On Thu, Mar 31, 2022 at 11:06 AM Andrea Del Bene wrote: > On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl wrote: > > > Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code > > related to this

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl wrote: > Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code > related to this flag is quite convoluted and full of TODOs and WHY > comments. I think I will have to do another take on this and replace the > field with a parameter,

[ANNOUNCE] WicketStuff 9.9.0 Released

WicketStuff core 9.9.0 based on Apache Wicket 9.9.0 is released and soon will be available at Maven Central! Maxim Solodovnik (3): Switching to the next development version Dependencies are updated wicketstuff core 9.9.0 is released The WicketStuff team

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

I've looked at https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/AssociatedMarkupSourcingStrategy.java and I somehow wonder if we couldn't get rid of this private boolean noMoreWicketHeadTagsAllowed = false; at all? It seems to be quest

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code related to this flag is quite convoluted and full of TODOs and WHY comments. I think I will have to do another take on this and replace the field with a parameter, but this will take some time. I would suggest we revert WICKET

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

Although the JavaDoc states that this should be possible: // reset for each render in case the strategy is re-used noMoreWicketHeadTagsAllowed = false; It would be great if we had a failing test-case for this. In my production environment with about 5000 panels, there are none of these issues.

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

It seems I should cancel wicketstuff build :(( On Thu, 31 Mar 2022 at 15:14, Thomas Heigl wrote: > I think we will have to revert WICKET-6963. > > I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed > in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton > st

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

I think we will have to revert WICKET-6963. I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton strategy doesn't work. Thomas On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl wrote: > This is probably cause

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

This is probably caused by my change in https://issues.apache.org/jira/browse/WICKET-6963 I have been using this code in production for a couple of weeks now without issues, but there seem to be cases where the singleton strategy doesn't work. Can you reproduce this issue in a test-case? Thomas

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

Well, the only thing I did was change wicket-9.8.0 to wicket-9.9.0 then I get these errors in production. After reverting to 9.8.0 these are gone I never touched any HTML files in between the deploys :X What has happened here? - Ursprüngliche Mail - > Von: "Maxim Solodovnik" >

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

Hi, The changelog is quite short: CHANGELOG for 9.9.0: ** Bug * [WICKET-6957] - Declare JSPM 'uses' for IInitializer * [WICKET-6965] - Memory leak in WicketEndpoint ** Improvement * [WICKET-6960] - Reduce allocations when encoding ComponentInfo * [WICKET-6963] - Use sing

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

" tags are only allowed before , , etc. tag" sounds reasonable :) On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl < korbinian.ba...@whiskyworld.de> wrote: > Hi, > > I deployed our app on 9.9.0 this morning and after initializing a crawl of > the page I ended up getting a low quote of 503s. > > The

wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

Hi, I deployed our app on 9.9.0 this morning and after initializing a crawl of the page I ended up getting a low quote of 503s. The 503s are always the same: 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper] Unexpected error occurred org.apache.wicket.markup.MarkupExce