Re: New committer: Jesse Long

2014-10-04 Thread Igor Vaynberg
Welcome aboard Jesse. -igor On Sun, Sep 28, 2014 at 11:47 AM, Martijn Dashorst wrote: > The Project Management Committee (PMC) for Apache Wicket > has asked Jesse Long to become a committer and we are pleased > to announce that he has accepted. > > Jesse has been involved with Wicket for a whil

Re: proposal: behavior bundles

2014-07-17 Thread Igor Vaynberg
On Thu, Jul 17, 2014 at 9:08 AM, Garret Wilson wrote: > On 7/17/2014 8:25 AM, Martin Grigorov wrote: >> >> ... >> >> For some reason this feature doesn't seem that usable to me... > > > Could you be more specific about why you don't find this feature doesn't > seem useful? None of your comments be

Re: [VOTE] Release Apache Wicket 6.16.0

2014-06-13 Thread Igor Vaynberg
+1 to release -igor On Thu, Jun 12, 2014 at 1:18 AM, Martin Grigorov wrote: > [X] Yes, release Apache Wicket 6.16.0 > > tested our main app, random wicket examples, local build > > Martin Grigorov > Wicket Training and Consulting > > > On Tue, Jun 10, 2014 at 3:37 PM, Sven Meier wrote: > >> [X

Re: [VOTE] Release Apache Wicket 7.0.0-M1

2014-04-21 Thread Igor Vaynberg
+1 to release -igor On Sun, Apr 20, 2014 at 1:44 PM, Martijn Dashorst wrote: > WOW. This is the first of many votes to come for our first Wicket 7 > release train. It took some work, but I managed to manipulate our > projects, Maven and its release plugin to generate the right release > version

Re: [VOTE] Release Apache Wicket 6.15.0

2014-04-21 Thread Igor Vaynberg
+1 to release -igor On Wed, Apr 16, 2014 at 3:56 PM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.15.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts

Re: Wicket 7: IChoiceRenderer restore or keep out?

2014-03-25 Thread Igor Vaynberg
On Wed, Mar 19, 2014 at 2:58 AM, Sven Meier wrote: > Hi Martin, > > I'm +1 on releasing 7.x soon. > > ListMultipleChoice#getModelValue() and > AbstractSingleSelectChoice#getModelValue() are still problematic though: > Both call getChoices().indexOf(object), thus any non-primitive option has to > i

Re: Future of org.apache.wicket.util.iterator.ComponentHierarchyIterator

2014-03-17 Thread Igor Vaynberg
i think the visitors are a simpler solution. -igor On Mon, Mar 17, 2014 at 3:09 AM, Martin Grigorov wrote: > Hi, > > Juergen has introduced component hierarchy iterators with > https://issues.apache.org/jira/browse/WICKET-3789 to simplify the hierarchy > traversal via IVisitor. > > Unfortunatel

Re: Wicket 7: IChoiceRenderer restore or keep out?

2014-02-26 Thread Igor Vaynberg
On Wed, Feb 26, 2014 at 8:00 AM, Sven Meier wrote: > To add another point to the discussion: > > IMHO (I)ChoiceRenderer in 7.x is broken anyway. > As long as the user has to implement #equals() in his model objects *or* > override #getModelValue(), the choice renderer API is not yet complete: > >

Re: [1/2] git commit: WICKET-3335 fragment and wicket:container support

2014-02-25 Thread Igor Vaynberg
cket/tree/61b01295 >> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/61b01295 >> >> Branch: refs/heads/master >> Commit: 61b01295d0d52929178d058d48456cae4acbc3e7 >> Parents: a79ed51 >> Author: Igor Vayn

Re: git commit: WICKET-3335 test fixes

2014-02-21 Thread Igor Vaynberg
s/asf/wicket/diff/1fd9d57c >> >> Branch: refs/heads/sandbox/component-queueing-2 >> Commit: 1fd9d57c0954f393e7cf6b6391d2f69c2815674d >> Parents: 63d15c5 >> Author: Igor Vaynberg >> Authored: Thu Feb 20 23:09:43 2014 -0800 >> Committer: Igor Vaynberg >&g

Re: Markup driven component tree

2014-02-21 Thread Igor Vaynberg
tests fixed, merged into master. -igor On Tue, Feb 18, 2014 at 5:29 AM, Martin Grigorov wrote: > On Mon, Feb 17, 2014 at 5:48 AM, Igor Vaynberg wrote: > >> i think the implementation is good enough to be merged into master >> now. it supports: >> > > I am still

Re: [2/2] git commit: WICKET-3335 nested borders working. everything should be working. needs more cleanup and javadoc

2014-02-20 Thread Igor Vaynberg
ndbox/component-queueing-2 >> Commit: 384d748c150031fa584aa44fce2f0a7e05e98531 >> Parents: 14797ed >> Author: Igor Vaynberg >> Authored: Sat Feb 15 00:40:48 2014 -0800 >> Committer: Igor Vaynberg >> Committed: Sat Feb 15 00:40:48 2014 -0800 >> >> --

Re: Markup driven component tree

2014-02-16 Thread Igor Vaynberg
structures maybe, but i dont think its needed... todo: * fragments - should be trivial, possibly as trivial as letting it implement IQueueRegion * check markup inheritance works on pages, panels, fragments. * examples * update to the guide -igor On Fri, Feb 14, 2014 at 8:36 AM, Igor Vaynberg

Re: [VOTE] Release Apache Wicket 6.14.0 - second try

2014-02-14 Thread Igor Vaynberg
+1 -igor On Fri, Feb 14, 2014 at 7:45 AM, Jonas wrote: > [X] Yes, release Apache Wicket 6.14.0 (try 2) > (non binding) > > Tested our main webapp, plus verified the jira tracks I've filed > (WICKET-5469, WICKET-5493) > > cheers, > Jonas > > > On Fri, Feb 14, 2014 at 4:01 PM, Martijn Dashorst < >

Re: Markup driven component tree

2014-02-14 Thread Igor Vaynberg
i am reworking the implementation a bit to properly support borders and repeaters by delegating to components...will check it in when i have it working... -igor On Fri, Feb 14, 2014 at 7:26 AM, Martin Grigorov wrote: > On Mon, Feb 10, 2014 at 6:01 PM, Igor Vaynberg wrote: > >> On

Re: Markup driven component tree

2014-02-10 Thread Igor Vaynberg
On Mon, Feb 10, 2014 at 6:26 AM, Martin Grigorov wrote: > > On Mon, Feb 10, 2014 at 9:43 AM, Igor Vaynberg wrote: > > > i just pushed my new idea into sandbox/component-queueing-2 > > > > the way this works now is instead of doing it in onInitialize() and in > >

Re: Markup driven component tree

2014-02-10 Thread Igor Vaynberg
I am suspending my work on this because I think there is not enough > >> interest in this feature at the moment. > >> > >> Martin Grigorov > >> Wicket Training and Consulting > >> > >> > >> On Mon, Jan 27, 2014 at 10:07 AM, Martin Grigorov >

Re: [VOTE] Release Apache Wicket 1.4.22

2014-01-31 Thread Igor Vaynberg
+1 -igor On Thu, Jan 30, 2014 at 5:00 AM, Martin Grigorov wrote: > This vote is to release Apache Wicket 1.4.22 > > Git repo > http://git-wip-us.apache.org/repos/asf/wicket.git > > Branch name > build/wicket-1.4.22 > > Archived and signed Git repo > https://dist.apache.org/repos/dist/dev/wicket

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-28 Thread Igor Vaynberg
then change eclipse formatter settings to match whatever is in our code base now? -igor On Tue, Jan 28, 2014 at 10:21 AM, Martin Grigorov wrote: > On Tue, Jan 28, 2014 at 7:13 PM, Igor Vaynberg wrote: > >> the format edited lines only applies to save actions, it will do >>

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-28 Thread Igor Vaynberg
Consulting >> >> >> On Tue, Jan 28, 2014 at 5:27 PM, Sven Meier wrote: >> >>> if the formatter config is correct i shouldnt have to just format >>> edited >>>> >>>> lines... >>>> >>> Correct. >>> >

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-28 Thread Igor Vaynberg
quot;format edited lines" > selected in the configuration? > > Regards > Sven > > > > On 01/28/2014 09:52 AM, Igor Vaynberg wrote: >> >> apparently eclipse formatter setup in master is incorrect. i am >> working on a new queuing implementation idea and kee

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-28 Thread Igor Vaynberg
older and use that as the canonical version. > > Martijn > > > On Tue, Nov 12, 2013 at 11:10 PM, Igor Vaynberg > wrote: >> any progress Martijn? >> >> -igor >> >> On Sun, Nov 10, 2013 at 12:49 AM, Martijn Dashorst >> wrote: >>> We can let

Re: Markup driven component tree

2014-01-23 Thread Igor Vaynberg
On Thu, Jan 23, 2014 at 8:53 AM, Martin Grigorov wrote: > On Thu, Jan 23, 2014 at 6:36 PM, Igor Vaynberg wrote: > >> On Thu, Jan 23, 2014 at 8:20 AM, Martin Grigorov >> wrote: >> > Once the markup driven construction is done (just before onInitialize()) >> >

Re: Markup driven component tree

2014-01-23 Thread Igor Vaynberg
are too many gotchas for all but the most trivial cases. couple this together with the fact that it has to be enabled as mentioned above would put me at -0.5 for this for now. -igor > I will add more use cases/tests soon. > And caching for the reflection stuff. > > > On T

Re: Markup driven component tree

2014-01-23 Thread Igor Vaynberg
what about components added in onInitialize() or on onConfigure()? this will also lead to a higher memory/serialization space usage since by default you need a field to store the component ref. not sure its worth doing it this way... -igor On Wed, Jan 22, 2014 at 12:12 PM, Martin Grigorov wro

Re: [Vote] Release Apache Wicket 1.5.11

2014-01-23 Thread Igor Vaynberg
+1 -igor On Thu, Jan 23, 2014 at 1:00 AM, Martijn Dashorst wrote: > +1 > > > On Mon, Jan 20, 2014 at 5:09 PM, Martin Grigorov wrote: > >> This vote is to release Apache Wicket 1.5.11 >> >> Git repo >> http://git-wip-us.apache.org/repos/asf/wicket.git >> >> Branch name >> build/wicket-1.5.11 >> >

Re: [VOTE] Release Apache Wicket 6.13.0

2014-01-07 Thread Igor Vaynberg
+1 to release -igor On Sun, Jan 5, 2014 at 12:58 PM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.13.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts

Re: [jira] [Resolved] (WICKET-5462) Ajax form-component-label repainting fails when setResponsePage() is used to navigate away from the page that has previously failed form validaiton

2014-01-06 Thread Igor Vaynberg
indeed, 6.13 hasnt been marked as released in jira yet... On Mon, Jan 6, 2014 at 11:47 AM, Sven Meier wrote: >> Fix Version/s: 7.0.0 >> 6.13.0 > > > That should be 6.14.0, no? > > Sven > > > > On 01/06/2014 07:27 PM, Igor Vaynbe

Re: The state of Wicket 6.13

2014-01-05 Thread Igor Vaynberg
+1 to rebase On Sun, Jan 5, 2014 at 8:39 AM, Martijn Dashorst wrote: > All, > > Since a long time I have tried to coerce the Maven release plugin to > actually build a release. It appears that newer versions of git have > altered the output format on which the m-r-p depends to commit the pom > ch

Re: Passing Component or Class to IAuthorizationStrategy#isInstantiationAuthorized()

2013-12-20 Thread Igor Vaynberg
of this class may try > to use the page instance for anything > > > Martin Grigorov > Wicket Training and Consulting > > > On Fri, Dec 20, 2013 at 6:14 PM, Igor Vaynberg wrote: > >> this is a security check, so the whole idea is that it is ran before >>

Re: Passing Component or Class to IAuthorizationStrategy#isInstantiationAuthorized()

2013-12-20 Thread Igor Vaynberg
this is a security check, so the whole idea is that it is ran before any of the user's code in the constructor which may have side-effects. eg a constructor marking a record as ready to be deleted because a delete panel was instantiated. the class itself should be enough. even if you get an instanc

Re: Queueing components?

2013-12-19 Thread Igor Vaynberg
just to clarify, this is not what component queueing is about. the usecase you are describing is more reminiscent of a CMS where you explicitly build out the functionality of being able to move components around on the page. if your friend A wants the search box on the left and your friend B wants

Re: git commit: WICKET-5418 properly handle groups in NonNull constraint

2013-11-15 Thread Igor Vaynberg
mit/49922cdd >> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/49922cdd >> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/49922cdd >> >> Branch: refs/heads/wicket-6.x >> Commit: 49922cdd5ccba3b97c59106d3aea769b8468962e >> Parents: 4bb19a4 >

Re: Future of wicket-cdi

2013-11-13 Thread Igor Vaynberg
ration new CdiConfiguration().configure(this); // after the line above the application is injected and resource is now available. by default injectApplication bit in CdiConfiguration is set to true and it passes the instance through NonContextual. resource.doSomething(); } } -

Re: Future of wicket-cdi

2013-11-13 Thread Igor Vaynberg
On Wed, Nov 13, 2013 at 2:42 PM, John Sarman wrote: >> further you are assuming i am running inside a container that has its >> filter's managed by cdi, this is not always the case so using your cdi >> filter would fail. one would have to fall back on wicket-filter and >> > > I am 100% assuming

Re: Future of wicket-cdi

2013-11-13 Thread Igor Vaynberg
configured it got called before internalInit(). either create a subcpass with @PostConstruct that configures the application - which wont work - people dont like using subclasses - or create a provider. -igor > On Wed, Nov 13, 2013 at 4:31 PM, Igor Vaynberg wrote: > >> i agree we should

Re: Future of wicket-cdi

2013-11-13 Thread Igor Vaynberg
i agree we should restart with the original implementation and incrementally introduce the new features - thats what i proposed in the original pull request. i am not a big fan of having the application instance managed. what is the value of this? it can be injected using noncontextual just like e

Re: remove recently merged cdi 1.1 from 6.x

2013-11-12 Thread Igor Vaynberg
the point on INonContextualManager was to internalize NonContextual - in case cdi implementation provides a better way to perform non-contextual injection. now that NonContextualManager is @ApplicationScoped and CdiConfiguration does not have a setter for it this functionality is lost. and even if

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-12 Thread Igor Vaynberg
eclipse.wst.validation.prefs > > > .settings/org.maven.ide.eclipse.prefs > /org.maven.ide.eclipse.prefs > > > > > > nl.topicus.onderwijs > eclipse-settings > 2012.2.2 > > > > > On Sun, Nov 10, 2013 at 12:45 AM, Igor Vaynberg > wrote: >> yes, m

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-09 Thread Igor Vaynberg
: > But you have to import the xml just once, right ? It is not a big deal. > Or the problem is that the xml messes up the other projects in your > workspace ? > > > > On Sat, Nov 9, 2013 at 7:24 AM, Igor Vaynberg wrote: > >> it is really frustrating that i have to do th

Re: git commit: WICKET-5411 auto label auto update during ajax

2013-11-09 Thread Igor Vaynberg
commit/a73209be >> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a73209be >> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a73209be >> >> Branch: refs/heads/wicket-6.x >> Commit: a73209beab8814a06f2e085384ad87bdf1fda212 >> Parents: 4e9a8

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-08 Thread Igor Vaynberg
it is really frustrating that i have to do this manually now. before all i had to do was checkout the project and it was all set. wicket shares my workspace with other projects so the workspace-default is not going to work. can we drop the format def on wicket.apache.org and configure the maven pl

remove recently merged cdi 1.1 from 6.x

2013-11-08 Thread Igor Vaynberg
not sure why this was merged into 6.x but there are a lot of problems with this contribution as can be seen here [1]. i think this should be removed from at least the release branch. -igor [1] https://github.com/apache/wicket/pull/50#issuecomment-28063112

Re: [VOTE] Release Apache Wicket 6.11.0

2013-09-23 Thread Igor Vaynberg
+1 -igor On Fri, Sep 20, 2013 at 4:16 AM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.11.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hour

Re: Broadcast.EXACT with Behavior

2013-09-04 Thread Igor Vaynberg
yep -igor On Wed, Sep 4, 2013 at 9:40 AM, Martin Grigorov wrote: > that is: just notify the component and all its behaviors? > > On Sep 4, 2013 6:53 PM, "Igor Vaynberg" wrote: >> >> i think it makes sense to be able to target a component as the most >>

Re: Broadcast.EXACT with Behavior

2013-09-04 Thread Igor Vaynberg
i think it makes sense to be able to target a component as the most fine grained receiver and letting all behaviors check in and see if they want to respond. -igor On Wed, Sep 4, 2013 at 3:13 AM, Martin Grigorov wrote: > Hi, > > https://issues.apache.org/jira/browse/WICKET-5339 requests to be ab

Re: RFC-0001: Deprecating PageParameters for Wicket 7 (was Re: [4/4] git commit: WICKET-4997)

2013-08-22 Thread Igor Vaynberg
On Thu, Aug 22, 2013 at 2:04 PM, Martijn Dashorst wrote: > > On Thu, Aug 22, 2013 at 10:09 PM, Ben Tilford wrote: > > > There really isn't a good reason to remove them even if parameter injection > > is added. > > > Yes there is: > - removing maintenance burden > - removing confusion > - makin

Re: RFC-0001: Deprecating PageParameters for Wicket 7 (was Re: [4/4] git commit: WICKET-4997)

2013-08-22 Thread Igor Vaynberg
i added a bunch of comments in the gist. not sure why we couldnt just do it here in place -igor On Thu, Aug 22, 2013 at 9:24 AM, Ben Tilford wrote: > By deprecate I hope you don't mean remove. This change would break almost > every single wicket application ever written. > > > On Thu, Aug

Re: [4/4] git commit: WICKET-4997: render bookmarkable urls for bookmarkable pages (not stateless)

2013-08-20 Thread Igor Vaynberg
so what happens to the pages that are both bookmarkable and not? public class EditCustomerPage { public EditCustomerPage(PageParameters params) { this(getEntity(params, "customer")); } public EditCustomerPage(IModel customer) { ... } } what url will i get now when i say urlFor

Re: [VOTE] Accept the Wicket Free Guide as a part of Apache Wicket

2013-08-20 Thread Igor Vaynberg
[x] Yes, accept the Wicket Free Guide to incorporate into our project -igor On Sun, Aug 18, 2013 at 7:48 AM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > Andrea del Bene has granted us the ability to include the Wicket Free Guide > into our project and to conclude the IP-clearance we

Re: [VOTE] Release Apache Wicket 6.10.0 - take 3

2013-08-12 Thread Igor Vaynberg
+1 -igor On Mon, Aug 12, 2013 at 3:12 AM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > This is a vote to release Apache Wicket 6.10.0, take 3 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source

Re: [VOTE] Release Apache Wicket 6.10.0 - take 2

2013-08-09 Thread Igor Vaynberg
+1 to release. On Fri, Aug 9, 2013 at 5:52 AM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.10.0, take 2 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > las

Re: [Wicket7] History API support for navigable AJAX pages/components?

2013-08-05 Thread Igor Vaynberg
On Sun, Aug 4, 2013 at 1:16 AM, Martin Grigorov wrote: > On Sat, Aug 3, 2013 at 5:23 PM, Igor Vaynberg >wrote: > > > * we need to have two different disk stores - one for ajax versions and > one > > for non-ajax. this is to ensure that the original rendered page instance

Re: [Wicket7] History API support for navigable AJAX pages/components?

2013-08-03 Thread Igor Vaynberg
* we need to have two different disk stores - one for ajax versions and one for non-ajax. this is to ensure that the original rendered page instance is not evicted if its render is followed by a lot of ajax activity. if it is evicted then any non-ajax callbacks will break. we already have wicket-aj

its that time of year again, 42lines is hiring java devs

2013-07-30 Thread Igor Vaynberg
the company i work for ( 42lines.net ) is growing and we are looking for a few good devs. about our approach: * we are a distributed usa-based company * everyone telecommutes either from home or a coworking space of your choice (paid for by the company) * we use a variation of agile methodology (

Re: Ajax behavior for JavaScript event delegation

2013-07-30 Thread Igor Vaynberg
binding on document is fine, you just have to make sure your code is fast in case you are binding to things like mousemove. -igor On Tue, Jul 30, 2013 at 1:31 AM, Martin Grigorov wrote: > On Fri, Jul 12, 2013 at 5:21 PM, Igor Vaynberg >wrote: > > > On Fri, Jul 12, 2013 at

Re: git commit: WICKET-5071 use url as clientUrl

2013-07-12 Thread Igor Vaynberg
human history is not cryptographically hashed :( On Fri, Jul 12, 2013 at 6:36 AM, Martin Grigorov wrote: > On Fri, Jul 12, 2013 at 4:33 PM, Jeremy Thomerson > wrote: > >> On Fri, Jul 12, 2013 at 7:34 AM, Sven Meier wrote: >> >> > Sorry, that was the wrong issue number in the clipboard. >> > >> >

Re: Ajax behavior for JavaScript event delegation

2013-07-12 Thread Igor Vaynberg
On Fri, Jul 12, 2013 at 1:50 AM, Martin Grigorov wrote: > On Fri, Jul 12, 2013 at 8:59 AM, Igor Vaynberg wrote: > >> On Thu, Jul 11, 2013 at 7:22 AM, Martin Grigorov >> wrote: >> > On Thu, Jul 11, 2013 at 4:48 PM, Sven Meier wrote: >> > >> >&g

Re: Ajax behavior for JavaScript event delegation

2013-07-11 Thread Igor Vaynberg
On Thu, Jul 11, 2013 at 7:22 AM, Martin Grigorov wrote: > On Thu, Jul 11, 2013 at 4:48 PM, Sven Meier wrote: > >> Hi, >> >> >> >The idea with plain JS solution I cannot visualize in my head yet. >> >> EventDelegatingBehavior is just a collector of JavaScript snippets. The >> actual magic runs in

Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues

2013-07-05 Thread Igor Vaynberg
+1 to release -igor On Fri, Jul 5, 2013 at 9:17 AM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.9.1 > > This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was > broken for injecting into anonymous inner classes (see WICKET-5226). > > This release only

Re: Michael Mosmann is a committer and PMC member!

2013-07-01 Thread Igor Vaynberg
welcome! -igor On Mon, Jul 1, 2013 at 2:51 AM, Martijn Dashorst wrote: > Please welcome Michael Mosmann as our newest addition to the Wicket team! > > Michael has been a long time contributor to Wicket, and even wrote a > book on the subject. His day to day work keeps him busy with Wicket so > w

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-29 Thread Igor Vaynberg
go for it On Fri, Jun 28, 2013 at 11:43 PM, martin.dilger wrote: > That sounds like a pretty good thing. Should I file a Ticket? > > > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/RestartResponseAtInterceptPageException-continueToOriginalDestination-tp4659907

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Igor Vaynberg
i think the middle ground is to add RequestCycle#continueToOriginalDestination(). that way its your job to make sure you actually have a valid wicket scope before attempting to call that method. -igor On Fri, Jun 28, 2013 at 11:49 AM, martin.dilger wrote: > Hi Igor, > > We dont talk about differ

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Igor Vaynberg
this does not seem cluttered to me: 1 add(new Button("login") { 2 onsubmit() { 3 if (authenticator.login(username, password)) { 4continueToOriginalDestination(); 5setResponsePage(UserHome.class); 6} else { 7 error("login failed"); 8 } 9 } do you expect to call set

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Igor Vaynberg
if your form is not backed by wicket i do not think you should count on being within a wicket request cycle... -igor On Fri, Jun 28, 2013 at 7:43 AM, martin.dilger wrote: > Hi Martin, > > image the typical SignIn-Functionality. > > You have a SignInPanel which only shows the necessary Form Comp

Re: Wicket 7 status

2013-06-26 Thread Igor Vaynberg
i may be able to help here. ive recently written a descent polling panel we use to execute long-running sql queries. its not async in the sense that it does not work via servlet 3 async requests - it polls with ajax. but, unlike lazyloadpanel we have now this one doesnt block access to the page, an

Re: Wicket 7 status

2013-06-26 Thread Igor Vaynberg
On Wed, Jun 26, 2013 at 4:20 AM, Martin Grigorov wrote: > Hi all, > > I'd like to discuss where we are with Wicket 7 and what to do next. > > At the moment there are just > 3

Re: Deprecating wicket:enclosure

2013-06-17 Thread Igor Vaynberg
to write or some other problems ? > > What to do with these tickets ? I can close all but one as duplicates and > link them ... > > > On Tue, Jun 18, 2013 at 3:12 AM, Igor Vaynberg wrote: > >> even though wicket:enclosure doesnt work for every single situation >> ou

Re: Deprecating wicket:enclosure

2013-06-17 Thread Igor Vaynberg
even though wicket:enclosure doesnt work for every single situation out there it is still immensely useful because it works for 90% use cases out there. so -1 to deprecate. in fact, the reason we introduced it in the first place was because adding EnclosureContainer-like components in code was a pa

Re: WicketTester CDI and WicketApplication

2013-06-17 Thread Igor Vaynberg
yes, and they make my eyes bleed :) -igor On Mon, Jun 17, 2013 at 1:26 PM, Martin Grigorov wrote: > Thanks! > I'll take a look. > > You may have noticed that now there are JS functional tests for the CDI > pages in wicket-examples too > > > On Mon, Jun 17, 2013 at

Re: WicketTester CDI and WicketApplication

2013-06-17 Thread Igor Vaynberg
we use a custom solution at $dayjob, but its so tired to our environment it would be hard to repackage. maybe we can use this: http://jglue.org/cdi-unit/ but i havent tried it yet. -igor On Mon, Jun 10, 2013 at 1:49 AM, Martin Grigorov wrote: > > Hi Igor & Emond, > > At the moment we don't have

Re: Generified Component

2013-05-30 Thread Igor Vaynberg
On Thu, May 30, 2013 at 12:37 PM, tetsuo wrote: > -1000! > > This will be horrible! Even with the current API, most generics I have to > declare in my code don't add anything to type safety. For example: while i am also not a fan of having component generified i do believe the example below is a

Re: ISessionListener#onUnbound(String)

2013-05-29 Thread Igor Vaynberg
+1 -igor On Wed, May 29, 2013 at 1:29 PM, Martin Grigorov wrote: > Hi, > > Do you think the following improvement should be made for Wicket 7: > > diff --git i/wicket-core/src/main/java/org/apache/wicket/Application.java > w/wicket-core/src/main/java/org/apache/wicket/Application.java > index 98

Re: [VOTE] Release Apache Wicket 6.8.0

2013-05-18 Thread Igor Vaynberg
+1 -igor On Fri, May 17, 2013 at 11:59 AM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.8.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hour

Re: Handling user-specific timezones

2013-05-09 Thread Igor Vaynberg
On Thu, May 9, 2013 at 1:12 PM, Martin Grigorov wrote: > On Thu, May 9, 2013 at 9:45 PM, Igor Vaynberg wrote: > >> On Thu, May 9, 2013 at 12:32 PM, Martin Grigorov >> wrote: >> > On Thu, May 9, 2013 at 5:37 PM, Igor Vaynberg > >wrote: >> > >> >&

Re: Handling user-specific timezones

2013-05-09 Thread Igor Vaynberg
On Thu, May 9, 2013 at 12:32 PM, Martin Grigorov wrote: > On Thu, May 9, 2013 at 5:37 PM, Igor Vaynberg wrote: > >> we should write components that work with multiple types. >> > > But this will mean that we will have to re-write it to javax.time for the > version of

Re: Handling user-specific timezones

2013-05-09 Thread Igor Vaynberg
we should write components that work with multiple types. for example this is what code of a DateLabel might look like: @Override public void onComponentTagBody(MarkupStream markupStream, ComponentTag openTag) { String body = ""; Object date = getDefaultModelObject(); if (date != null) { if (da

Re: CDI upgrade to 1.1

2013-05-06 Thread Igor Vaynberg
most likely wicket-cdi module will be cloned into wicket-cdi-1.1 module with the old one remaining... -igor On Mon, May 6, 2013 at 11:03 PM, Emond Papegaaij wrote: > Yes, the conversational scope is the main reason for the upgrade. > Seam-conversation has always been sort of a hack, and it is go

Re: FormComponent's label outputs markup attributes

2013-05-02 Thread Igor Vaynberg
because they need to be styled differently and as far as i know there is no cross-browser selector that lets you select a label connected to a form component that has some specific css class or attribute... -igor On Thu, May 2, 2013 at 1:45 PM, Martin Grigorov wrote: > Hi Igor, > > I have a ques

Re: A few questions about contributing

2013-05-02 Thread Igor Vaynberg
-0 i would prefer that only core committers are assigned to an issue, that way we know someone is actually taking care of it and its easy to find issues not taken by anyone. if a non-committer wants to contribute a patch and "claim" an issue while doing so they can leave a comment to that effect

Re: Warnings from RequestCycle.handleException(Exception)

2013-04-27 Thread Igor Vaynberg
in many cases this exception will lead to the error page, so its not just debugging information. this is the case i would rather wicket be loud by default to help while developing and have interested parties silence the logger in production systems... -igor On Sat, Apr 27, 2013 at 11:43 AM, Marti

Re: [VOTE] Branch for Wicket 7.0

2013-04-27 Thread Igor Vaynberg
correct. the commitment we make is: new features go into current major version we maintain major.version-1 - which means backporting bug fixes we support major.version-2 - which means we backport security releated fixes -igor On Sat, Apr 27, 2013 at 1:07 AM, Martin Grigorov wrote: > On Sat, Apr

Re: Add 'Component' to #updateAjaxRequestAttributes()

2013-04-27 Thread Igor Vaynberg
On Fri, Apr 26, 2013 at 11:44 AM, Martin Grigorov wrote: > Hi Igor, > > I saw your entry in the roadmap: > == > h4. ajaxbehavior#updateAjaxAttributes() should get component passed in > > otherwise referencing the component as needed in throttle settings is > annoyin

Re: Add 'Component' to #updateAjaxRequestAttributes()

2013-04-27 Thread Igor Vaynberg
the idea was to make it more obvious/easier to access since you are likely to need the component in that method. reusing ajax behavior instances doesnt make sense because they hold state. im not really attached to this enhancement, just seemed like it would make the code cleaner when i was doing th

Re: [VOTE] Branch for Wicket 7.0

2013-04-26 Thread Igor Vaynberg
[x] Yes, start work on Wicket 7 with the proposed roadmap -igor On Thu, Apr 25, 2013 at 6:15 AM, Martin Grigorov wrote: > Hi, > > I think it is time to start the work for Wicket 7.0. > At https://cwiki.apache.org/confluence/x/D4flAQ you may see the proposed > roadmap. > > The entries are extract

Re: [VOTE] Release Apache Wicket 6.7.0 (take 2)

2013-04-12 Thread Igor Vaynberg
lol. nice! On Fri, Apr 12, 2013 at 1:38 PM, Dan Retzlaff wrote: > If the changelog doesn't look impressive enough, try this: > http://starlogs.net/#apache/wicket > > > On Fri, Apr 12, 2013 at 1:04 PM, Igor Vaynberg wrote: > >> +1 to release >> >> -ig

Re: [VOTE] Release Apache Wicket 6.7.0 (take 2)

2013-04-12 Thread Igor Vaynberg
+1 to release -igor On Fri, Apr 12, 2013 at 12:55 PM, Martijn Dashorst wrote: > This is the second vote to release Apache Wicket 6.7.0. > > The previous attempt was one month ago and was cancelled due to a bug that > caused wicket (examples) to not function on Windows machines. Right after > the

Re: [VOTE] Release Apache Wicket 6.7.0

2013-04-08 Thread Igor Vaynberg
friday is fine by me -igor On Mon, Apr 8, 2013 at 4:05 AM, Cedric Gatay wrote: > +1 for the 6.7.0 release on Friday. > > __ > Cedric Gatay (@Cedric_Gatay ) > http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr > > > On Mon, Apr 8, 2013 at

Re: git commit: fix WICKET-5117 Wicket ignores allowDefault:false attribute in multipart ajax requests

2013-03-26 Thread Igor Vaynberg
pache.org/repos/asf/wicket/tree/ea29f1f7 >> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ea29f1f7 >> >> Branch: refs/heads/master >> Commit: ea29f1f7c04fdec88a06d056b1ddf4f9d345a22d >> Parents: 15e5b0e >> Author: Igor Vaynberg >

Re: [VOTE] Release Apache Wicket 6.7.0

2013-03-22 Thread Igor Vaynberg
+1 to release -igor On Fri, Mar 22, 2013 at 8:40 AM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.7.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts f

Re: Release Wicket 6.7.0 soon ?

2013-03-18 Thread Igor Vaynberg
+1 -igor On Mon, Mar 18, 2013 at 8:51 AM, Martin Grigorov wrote: > OK, thanks! > > I hope you get better soon! > > > On Mon, Mar 18, 2013 at 4:38 PM, Martijn Dashorst < > martijn.dasho...@gmail.com> wrote: > >> On Mon, Mar 18, 2013 at 9:41 AM, Martin Grigorov > >wrote: >> >> > Hi Martijn, >> > >

Re: [Vote] Release Apache Wicket 1.5.10

2013-02-20 Thread Igor Vaynberg
+1 -igor On Wed, Feb 20, 2013 at 3:59 AM, Martin Grigorov wrote: > This vote is to release Apache Wicket 1.5.10 > > Git repo > http://git-wip-us.apache.org/repos/asf/wicket.git > > Branch name > build/wicket-1.5.10 > > Archived and signed Git repo > https://dist.apache.org/repos/dist/dev/wicket/

Re: [Vote] Release Apache Wicket 1.4.22

2013-02-20 Thread Igor Vaynberg
+1 -igor On Wed, Feb 20, 2013 at 6:33 AM, Martin Grigorov wrote: > This vote is to release Apache Wicket 1.4.22 > > Git repo > http://git-wip-us.apache.org/repos/asf/wicket.git > > Branch name > build/wicket-1.4.22 > > Archived and signed Git repo > https://dist.apache.org/repos/dist/dev/wicket/

Re: Igor needs 105 commits to overtake Eelco's commit count

2013-02-19 Thread Igor Vaynberg
Eelco Hillenius > * 2827 Igor Vaynberg > * 2053 Martin Grigorov > * 1867 Juegen Donnerstag > * 1484 Johan Compagner > * 1321 Jonathan Locke > * 963 Matej Knopp > * 928 Martijn Dashorst > * 422 Alastair Maw > * 353 Peter Ertl > * 277 Jean-Baptiste Queno

Re: [VOTE] Release Apache Wicket 6.6.0

2013-02-15 Thread Igor Vaynberg
+1 release -igor On Fri, Feb 15, 2013 at 5:36 AM, Martijn Dashorst wrote: > This is a vote to release Apache Wicket 6.6.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for

Re: How to contribute to the reference guide

2013-02-06 Thread Igor Vaynberg
why doesnt the guide live in a subdir of the project. that way there will be a guide per branch. one of the biggest problems with the wiki, etc, is that it doesnt account for code differences between the versions. having a guide per branch (major version) makes more sense. -igor On Wed, Feb 6, 20

Re: [VOTE] Release Apache Wicket 6.5.0

2013-01-20 Thread Igor Vaynberg
+1 to release -igor On Fri, Jan 18, 2013 at 3:58 PM, Martijn Dashorst wrote: > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache W

Re: [VOTE] Release Apache Wicket 6.4.0

2012-12-14 Thread Igor Vaynberg
+1 -igor On Fri, Dec 14, 2012 at 8:24 AM, Martijn Dashorst wrote: > Please download the source distributions found on my people.apache.org > distribution area linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, relea

Re: [2/2] git commit: Make 'groups' member final and rename other field members to not have '_' as suffix to make them consistent with rest Wicket classes.

2012-11-25 Thread Igor Vaynberg
this is the reason. > > If we are going to use them from now on then let's make it public in dev@. > > > On Sun, Nov 25, 2012 at 9:30 PM, Igor Vaynberg wrote: > >> can you please rename the fields back. >> >> the underscore at the end of the field means those

Re: [2/2] git commit: Make 'groups' member final and rename other field members to not have '_' as suffix to make them consistent with rest Wicket classes.

2012-11-25 Thread Igor Vaynberg
can you please rename the fields back. the underscore at the end of the field means those fields should not be accessed directly for example property_ should not be accessed directly - only via getProperty() getter because it is lazily initialized. even though it is private people modifying the c

  1   2   3   4   5   6   7   8   9   10   >