[GitHub] wicket issue #292: WICKET-6587 make CheckBoxSelector extensible

2018-09-21 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/292 That is a possibility, yes, though in your example you do hold on to the connectedCheckBoxes. My main idea was to keep it simple, by providing addCheckBox() users can just add checkboxes in a

[GitHub] wicket pull request #293: WICKET-6587 make CheckBoxSelector extensible

2018-09-14 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/293 WICKET-6587 make CheckBoxSelector extensible You can merge this pull request into a Git repository by running: $ git pull https://github.com/duesenklipper/wicket wicket-7/WICKET-6587

[GitHub] wicket pull request #292: WICKET-6587 make CheckBoxSelector extensible

2018-09-14 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/292 WICKET-6587 make CheckBoxSelector extensible You can merge this pull request into a Git repository by running: $ git pull https://github.com/duesenklipper/wicket wicket-8/WICKET-6587

[GitHub] wicket pull request #264: WICKET-6526 check HTTP method for all form submiss...

2018-02-04 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/264 WICKET-6526 check HTTP method for all form submissions this moves the HTTP method check from onFormSubmitted to onFormSubmitted(submitter) so that every form submission performs this

[GitHub] wicket pull request #263: WICKET-6526 check HTTP method for all form submiss...

2018-02-04 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/263 WICKET-6526 check HTTP method for all form submissions this moves the HTTP method check from onFormSubmitted to onFormSubmitted(submitter) so that every form submission performs this

[GitHub] wicket pull request #262: WICKET-6526 check HTTP method for all form submiss...

2018-02-04 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/262 WICKET-6526 check HTTP method for all form submissions this moves the HTTP method check from onFormSubmitted to onFormSubmitted(submitter) so that every form submission performs this

[GitHub] wicket pull request #199: WICKET-6289 fix autolinker so it does not generate...

2017-03-21 Thread duesenklipper
Github user duesenklipper closed the pull request at: https://github.com/apache/wicket/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-08 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 @martin-g I hate German translations of computer terms, which is the main reason my systems are all in English. But as mentioned elsewhere, I use a split locale instead, with formatting set to

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-08 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 @klopfdreh I know you did ;-) @martin-g I found it. @klopfdreh is right, it has something to do with Locale. My fault - for some reason I lost the `@Before` method in

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 @klopfdreh I don't think it does. It appears to be a problem on @martin-g's machine. The JSON stuff doesn't even come close to CssUrlReplacer. --- If your project is set up

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 Oh, you mean a problem on your machine? If that's the case, I'll stop trying to recreate it here ;-) --- If your project is set up for it, you can reply to this email and have

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 That's a different problem though (and it worked for me too). I'm building 5bfa280b2b7fb9dc7861d582a9c6e37d106be879 locally now to see what it does (the one you linked to) -

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 (I ran `mvn clean package`) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 I figured out to do $ git fetch github-upstream refs/pull/195/head $ git checkout FETCH_HEAD From that I got commit 4dbdbdfe, and that builds cleanly for me. I also tried

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 (that said, that test works in the original wicket-7.x branch. i'll try and figure this out as soon as i can get at the branch) --- If your project is set up for it, you can reply to

[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x

2016-12-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 This might be a stupid question, but I must be missing something. How do I check out the pull request branch? --- If your project is set up for it, you can reply to this email and have your

[GitHub] wicket pull request #202: WICKET-6290 fix CssUrlReplacer so it does not mang...

2016-11-28 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/202 WICKET-6290 fix CssUrlReplacer so it does not mangle data URIs You can merge this pull request into a Git repository by running: $ git pull https://github.com/duesenklipper/wicket

[GitHub] wicket pull request #201: WICKET-6290 fix CssUrlReplacer so it does not mang...

2016-11-28 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/201 WICKET-6290 fix CssUrlReplacer so it does not mangle data URIs You can merge this pull request into a Git repository by running: $ git pull https://github.com/duesenklipper/wicket

[GitHub] wicket pull request #200: WICKET-6290 fix CssUrlReplacer so it does not mang...

2016-11-28 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/200 WICKET-6290 fix CssUrlReplacer so it does not mangle data URIs You can merge this pull request into a Git repository by running: $ git pull https://github.com/duesenklipper/wicket

[GitHub] wicket issue #199: WICKET-6289 fix autolinker so it does not generate an onc...

2016-11-27 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/199 It's not really needed for 1.5, no. I just first came across it in 1.5 while helping a customer migrate a whole bunch of applications from 1.4 - currently on the way to 7.x. I don't

[GitHub] wicket pull request #198: WICKET-6289 fix autolinker so it does not generate...

2016-11-25 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/198 WICKET-6289 fix autolinker so it does not generate an onclick attribu… …te for img tags You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] wicket pull request #199: WICKET-6289 fix autolinker so it does not generate...

2016-11-25 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/199 WICKET-6289 fix autolinker so it does not generate an onclick attribu… …te for img tags You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] wicket pull request #197: WICKET-6289 fix autolinker so it does not generate...

2016-11-25 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/197 WICKET-6289 fix autolinker so it does not generate an onclick attribu… …te for img tags You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] wicket pull request #196: WICKET-6289 fix autolinker so it does not generate...

2016-11-25 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/196 WICKET-6289 fix autolinker so it does not generate an onclick attribu… …te for img tags You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] wicket issue #188: Feature/locale format fix

2016-11-23 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/188 Yes, it would have still worked - I changed it so it explicitly tests for a split Locale now. If no formatting locale is set, `Locale.getDefault(FORMAT)` falls back to the "normal&quo

[GitHub] wicket issue #188: Feature/locale format fix

2016-11-22 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/188 Ticket is at https://issues.apache.org/jira/browse/WICKET-6273, and I went through the various calls to Locale.getDefault. What do you think? --- If your project is set up for it, you can

[GitHub] wicket pull request #189: make NoRecordsToolbar use onConfigure/setVisible i...

2016-11-07 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/189 make NoRecordsToolbar use onConfigure/setVisible instead of overridin… …g isVisible Overriding isVisible is discouraged, visibility should be set just once. I know the rowcount

[GitHub] wicket issue #188: Feature/locale format fix

2016-11-07 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/188 I'd merge it myself, but I can so rarely work on wicket itself these days that I prefer having someone look at it first. If this one is accepted, I'll add the same thing to

[GitHub] wicket pull request #188: Feature/locale format fix

2016-11-07 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/188 Feature/locale format fix On some systems (like my desktop ;-) ) there is not one single `Locale`, but rather different ones for text and formats. For example, I use `en_US` for nearly

[GitHub] wicket pull request #172: WICKET-6053 Allow to reuse the same application in...

2016-06-29 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/172 WICKET-6053 Allow to reuse the same application instance in several t… …ests Cherry-pick the fix for WICKET-6053 for Wicket 6. You can merge this pull request into a Git

[GitHub] wicket pull request: WICKET-5749 add AuthorizeResource to auth-rol...

2015-02-23 Thread duesenklipper
GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/99 WICKET-5749 add AuthorizeResource to auth-roles so Resources can be prot... WICKET-5749 add AuthorizeResource to auth-roles so Resources can be protected too. Also cleaned up and