Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/88#issuecomment-74373886
This PR has been integrated. Thanks a lot @martin-g
For more information see:
https://issues.apache.org/jira/browse/WICKET-5827?focusedCommentId
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/90#issuecomment-74378512
Linked ticket: https://issues.apache.org/jira/browse/WICKET-5837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/91#issuecomment-74378760
Linked ticket: https://issues.apache.org/jira/browse/WICKET-5837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/90
WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/91
WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior
little adjustment for master
You can merge this pull request into a Git repository by running:
$ git pull https
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/55#issuecomment-73840247
Can be close due to
https://github.com/apache/wicket/commit/b8be5346311406fe394741009f943fdf5dc71809
---
If your project is set up for it, you can reply to this email
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/13#issuecomment-73840576
As of the JIRA ticket this topic wouldn't be fixed - @minman would you be
so kind and close this PR? Thank you.
---
If your project is set up for it, you can reply
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/74#issuecomment-73840792
It would be nice if you could file in a ticket in JIRA so that it can be
catched up by the Wicket Dev's. For more information take a look here:
https://cwiki.apache.org
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/55#issuecomment-73842717
Thanks a lot @RoadRunner120485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/89
WICKET-5828 PageProvider not serializable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket WICKET-5828
Alternatively you can
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095338
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094462
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095087
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24095452
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-72903920
Ok I think I got it, but the changes are not backward compatible to wicket
6.x
---
If your project is set up for it, you can reply to this email and have your
reply
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094314
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24096363
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24096380
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeJavaScriptCompressor.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24096980
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094203
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24096192
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-72895940
What do you think of leaving the check of page away in the first step and
then implement your suggestions in a further pull request?
---
If your project is set up
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094994
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24094955
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24098307
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacementCompressor.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-72907386
So for now, yep the CssUrlReplacer is a bit slow, because it is scanning
for the images in different scopes and it is a limitation that you could not
put images
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24093233
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/87#issuecomment-73007971
Thank you very much! I also applied the changes we discussed here for the
wicket-6.x branch - https://github.com/apache/wicket/pull/88
---
If your project is set up
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/87
WICKET-5827 Allow to apply multiple Javascript / CSS compressors
- Allow multiple ICssCompressors and IJavaScriptCompressors
- CssUrlReplacementCompressor
You can merge this pull request
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/88
WICKET-5827 Allow to apply multiple Javascript / CSS compressors
(wicket-6.x)
- Allow multiple ICssCompressors and IJavaScriptCompressors
- CssUrlReplacementCompressor
You can merge this pull
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24091717
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/85#issuecomment-71913385
Integrated. Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/85#issuecomment-71004418
TODO: Implement CORS settings to the img tag.
crossorigin=anonymouse
crossorigin=use-credentials
crossorigin=
---
If your project is set up for it, you
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/86
WICKET-5819 Media tags - audio / video implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket media_tags
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/86#issuecomment-71107868
TODO: Examples in the examples project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/85
Wicket-5801 Responsive Images
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket master
Alternatively you can review and apply
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/82#issuecomment-69562819
Wicket-5802: Commit-Ids: f89731b, 564acb7, 0434e1d, 4add7fd
Wicket-5801: Commit-Ids: 15283cb, 339e9cc
Wicket-5808: Commit-Ids: 66c203a
---
If your project
301 - 339 of 339 matches
Mail list logo