subject:"\[GitHub\] wicket issue #258\: Wicket 6498 deferred javascript made simple"

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-31 Thread svenmeier

Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/258 Merged into master ---

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-28 Thread solomax

Github user solomax commented on the issue: https://github.com/apache/wicket/pull/258 Thanks @svenmeier, my bad, I should investigate deeper. +1 for merging this PR, everything works as expected :))) ---

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-28 Thread svenmeier

Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/258 Ah, that one is easy: Your header item is defining a function "wbAction". With deferred items this function is now defined inside the 'DOMContentLoaded' callback only. This is one of the

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-27 Thread solomax

Github user solomax commented on the issue: https://github.com/apache/wicket/pull/258 It seems I should use `git rebase` while merging ---

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-27 Thread solomax

Github user solomax commented on the issue: https://github.com/apache/wicket/pull/258 Thanks @svenmeier , `Auto mode` seems to work :) I have updated https://github.com/solomax/repeater-with-events with case that fails in deferred mode I'll try to check this from my side

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-27 Thread svenmeier

Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/258 This was an issue with WICKET_6503, which is now fixed on master. Thanks Maxim! So back to deferred JavaScript :) ---

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-27 Thread svenmeier

Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/258 Anything related to setAuto() must be magic. ---

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-26 Thread solomax

Github user solomax commented on the issue: https://github.com/apache/wicket/pull/258 Hello @svenmeier Finally I was able to create quick-start https://github.com/solomax/repeater-with-events, The issue is reproducible using latest wicket-core from master branch The

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-26 Thread svenmeier

Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/258 Hm, that would be an error on my other building site :P I have no clue what might causing this atm. ---

[GitHub] wicket issue #258: Wicket 6498 deferred javascript made simple

2018-01-26 Thread solomax

Github user solomax commented on the issue: https://github.com/apache/wicket/pull/258 @svenmeier here is incomplete investigation: I can see same errors using latest 8.0.0-SNAPSHOT from master branch :( I have checked commit-by-commit and this behavior caused by this