Github user renoth commented on the issue:
https://github.com/apache/wicket/pull/287
No Problem, thanks for accepting the PR.
---
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/287
Please close the PR.
---
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/287
Merged to master!
Thank you for the work, Johannes!
---
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/287
I'm trying to merge this PR.
---
Github user renoth commented on the issue:
https://github.com/apache/wicket/pull/287
Also i had to include the junit-vintage-engine in wicket-cdi and
wicket-arquilian because there is no compatibility for Junit5 with CDI and
Arquilian at the moment. Junit4 and Junit5 tests can run in
Github user renoth commented on the issue:
https://github.com/apache/wicket/pull/287
I did as best i could and locally mvn clean test runs successfully except
for wicket-arquilian-testing which has some failing tests.
Please review and give suggestions or criticism.
---
Github user renoth commented on the issue:
https://github.com/apache/wicket/pull/287
I have returned from vacation and created
https://issues.apache.org/jira/browse/WICKET-6583 i will begin the upgrade over
the next weeks. Comments and suggestions very welcome.
---
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/287
@renoth We have an agreement to upgrade to JUnit 5.x. You can continue with
the work on this PR! Please also open a ticket in JIRA for the changelog. Thank
you!
---
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/287
+1 from me too
---
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/287
+1 from me :)
---
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/287
Let's see what the other devs think about it but I like the idea of
upgrading dependencies for the next major version!
JUnit 5.x is actively developed and uses modern Java - this may help make
Github user renoth commented on the issue:
https://github.com/apache/wicket/pull/287
Yes this is correct, this PR is not intended to be merged soon or at all
but just as a demo on what the code changes would be if upgrading to Junit5 and
removing Junit4 dependencies from WicketTester.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/287
AFAIU this PR replaces JUnit 4.x with JUnit 5.x. Am I correct ?
I've seen usage of opentest4j classes which I guess come as transitive
dependency of JUnit 5.x.
I am fine with such kind of cha
13 matches
Mail list logo
