[GitHub] wicket issue #292: WICKET-6587 make CheckBoxSelector extensible

2018-09-21 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/292 Ah, I didn't notice your cleanup behavior. That's an improvement to the old solution already +1. I just think that a dynamic lookup with an overriden #getCheckBoxes() would be more flexibl

[GitHub] wicket issue #292: WICKET-6587 make CheckBoxSelector extensible

2018-09-21 Thread duesenklipper
Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/292 That is a possibility, yes, though in your example you do hold on to the connectedCheckBoxes. My main idea was to keep it simple, by providing addCheckBox() users can just add checkboxes in a l

[GitHub] wicket issue #292: WICKET-6587 make CheckBoxSelector extensible

2018-09-18 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/292 Why not add a lookup to CheckBoxSelector instead: ``` public CheckBoxSelector(String id, CheckBox... boxes) { super(id); connectedCheckBoxes = boxes; }