[GitHub] wicket issue #300: [WICKET-6603] Asypc page/data store destroyed without han...

2018-10-25 Thread solomax
Github user solomax commented on the issue: https://github.com/apache/wicket/pull/300 nice catch :) I'll update PR, thanks! ---

[GitHub] wicket issue #300: [WICKET-6603] Asypc page/data store destroyed without han...

2018-10-25 Thread solomax
Github user solomax commented on the issue: https://github.com/apache/wicket/pull/300 It would be impossible to call `pageSavingThread.join();` to ensure Thread is stopped Would it be OK? ---

[GitHub] wicket issue #300: [WICKET-6603] Asypc page/data store destroyed without han...

2018-10-25 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/300 I like to minimize the count of member variables: ``` @Override public void destroy() { final Thread pageSavingThread = this.pageSavingThread; this.pageSavingThre