Re: How to streamline ajax page region toggle

2011-03-03 Thread Joo Hama
Juergen, thanks for the review. I modified the code according to your suggestions. > - EnclosureHandler: A variable to increment the id postfix will not > work. A fresh copy of MarkupParser and all its handlers is created for > every markup file (page, panel, border, etc.). Your increment will > t

Re: How to streamline ajax page region toggle

2011-02-20 Thread Martin Makundi
> From an outside view the difference is whether the Enclosure is added > automatically or manually. From an implementation point of view the > automatic approach requires quite a bit of magic / complexity. I hope you don't aim at almost watering the whole idea ;) The idea of auto ajax enclosure

Re: How to streamline ajax page region toggle

2011-02-20 Thread Juergen Donnerstag
IMO it's quite a bit of (partially complex) code to achieve the objective. Just a thought (I've not implemented/tested it). It'll not lead to the very same result, but may be a less complex implementation => tradeoff. The basic idea: provided the child id is not necessarily something the html desi

Re: How to streamline ajax page region toggle

2011-02-20 Thread Juergen Donnerstag
I did a first review. - EnclosureHandler: A variable to increment the id postfix will not work. A fresh copy of MarkupParser and all its handlers is created for every markup file (page, panel, border, etc.). Your increment will thus only be unique within the a single markup file. Your page however

Re: How to streamline ajax page region toggle

2011-02-19 Thread Joo Hama
> the problem with the tag is that it is not rendered into the markup so > cannot be targetted via ajax. > > -igor Yes, this is exactly the point. We cannot render Enclosure tags without breaking html, for example inside a . If we cannot render it, we cannot target it with ajax. When we use an En

Re: How to streamline ajax page region toggle

2011-02-19 Thread Igor Vaynberg
On Sat, Feb 19, 2011 at 2:20 PM, Juergen Donnerstag wrote: > A couple of comments on previous posts > - you can always assign your own wicket:id like wicket:id="myEnclosure" child="label1"> > - yes, creates an auto component (no java code > necessary) that is auto-added to the container which at

Re: How to streamline ajax page region toggle

2011-02-19 Thread Juergen Donnerstag
A couple of comments on previous posts - you can always assign your own wicket:id like - yes, creates an auto component (no java code necessary) that is auto-added to the container which at that point in time gets rendered, when during the render process the markup stream hits the enclosure tag .

Re: How to streamline ajax page region toggle

2011-02-07 Thread Igor Vaynberg
i will try to look over it in the few coming days and give you some feedback. -igor On Mon, Feb 7, 2011 at 3:43 AM, Joo Hama wrote: > Thanks Igor and Jeremy, > > I managed to resolve these issues and committed a patch to JIRA: > > https://issues.apache.org/jira/browse/WICKET-3422 > > It introduc

Re: How to streamline ajax page region toggle

2011-02-07 Thread Joo Hama
Thanks Igor and Jeremy, I managed to resolve these issues and committed a patch to JIRA: https://issues.apache.org/jira/browse/WICKET-3422 It introduces an "inline" Enclosure defined as an attribute of a html tag, and a listener to find the right inline Enclosures at the time of Ajax request han

Re: How to streamline ajax page region toggle

2011-01-21 Thread Joo Hama
The EnclosureResolver... container.autoAdd seems to be invoked only in the parsing phase of the original request, whereas the onBeforeRender is invoked during handling of the AjaxRequest (when the listener is attached to the AjaxRequestTarget). I found out that the Enclosure is not a child of a Pa

Re: How to streamline ajax page region toggle

2011-01-21 Thread Martin Makundi
Hi! EnclosureResolvercontainer.autoAdd is invoked at render phase? Would it be necessary to hook into a different event (instead of onBeforeRender) or could it be pre-sniffed at onBeforeRender? ** Martin 2011/1/21 Joo Hama : > I tested this idea by adding the code below to my web application

Re: How to streamline ajax page region toggle

2011-01-21 Thread Joo Hama
I tested this idea by adding the code below to my web application object. Problem was though, that when viewing the variables in debugger, the enclosure object didn't seem to be included in the tree of the parent objects. It was as if the enclosure was invisible to them. Perhaps because Enclosure i

Re: How to streamline ajax page region toggle

2011-01-20 Thread James Carman
On Thu, Jan 20, 2011 at 3:07 PM, Jeremy Thomerson wrote: > > I, too, like the idea.  Couldn't it be simpler?  Couldn't he: > Yes, it could be simpler. It could be easier to add a listener to the ART in-general. :)

Re: How to streamline ajax page region toggle

2011-01-20 Thread Jeremy Thomerson
On Thu, Jan 20, 2011 at 1:51 PM, Igor Vaynberg wrote: > interesting idea. i think this would require a bit of a trick. > > a) modify enclosure tag handler to accept an attribute instead of a tag > b) modify enclosure tag handler to add a bit of metadata to the > component marking that it belongs t

Re: How to streamline ajax page region toggle

2011-01-20 Thread Igor Vaynberg
interesting idea. i think this would require a bit of a trick. a) modify enclosure tag handler to accept an attribute instead of a tag b) modify enclosure tag handler to add a bit of metadata to the component marking that it belongs to an enclosure c) add a ajaxrequesttarget.listener to the reques

How to streamline ajax page region toggle

2011-01-20 Thread Joo Hama
I'm trying to find out ways to reduce boilerplate code when toggling visibility of regions of a page using ajax calls. Basically i'd like to extend wicket:enclosure to overcome this limitation: "Changing the visibility of a child component in Ajax callback method will not affect the entire

How to streamline ajax page region toggle

2011-01-20 Thread Joo Hama
I'm trying to find out ways to reduce boilerplate code when toggling visibility of regions of a page using ajax calls. Basically i'd like to extend wicket:enclosure to overcome this limitation: "Changing the visibility of a child component in Ajax callback method will not affect the entire