Re: Make output markup container id default for development mode

2008-04-04 Thread Ryan Gravener
It is very useful. +1 nb On Fri, Apr 4, 2008 at 5:56 PM, Gwyn Evans <[EMAIL PROTECTED]> wrote: > I assume it actually outputs it as > > > markup that > comes form ThisOrThatPanel > > ? > > /Gwyn > > > > On Fri, Apr 4, 2008 at 9:02 AM, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > this has n

Re: Make output markup container id default for development mode

2008-04-04 Thread Gwyn Evans
I assume it actually outputs it as markup that comes form ThisOrThatPanel ? /Gwyn On Fri, Apr 4, 2008 at 9:02 AM, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > this has nothing to do with outputting markup ids. it outputs wicket > component class name next to a component > > eg > > > markup

Re: Make output markup container id default for development mode

2008-04-04 Thread Charlie Dobbie
+1, non-binding. Great idea! Charlie. On Fri, Apr 4, 2008 at 9:08 AM, Nino Saturnino Martinez Vazquez Wael < [EMAIL PROTECTED]> wrote: > I agree that it's a great idea.. > > And I've had a discussion about, using external web designers for design. > If we just provide them the whole page as r

Re: Make output markup container id default for development mode

2008-04-04 Thread Nino Saturnino Martinez Vazquez Wael
I agree that it's a great idea.. And I've had a discussion about, using external web designers for design. If we just provide them the whole page as rendered, this will make it even easier for us to paste back. regards Nino Igor Vaynberg wrote: this has nothing to do with outputting markup

Re: Make output markup container id default for development mode

2008-04-04 Thread Igor Vaynberg
this has nothing to do with outputting markup ids. it outputs wicket component class name next to a component eg markup that comes form ThisOrThatPanel -igor On Fri, Apr 4, 2008 at 12:37 AM, Peter Ertl <[EMAIL PROTECTED]> wrote: > I wouldn't do this (at least by default) as you might forget

Re: Make output markup container id default for development mode

2008-04-04 Thread Peter Ertl
I wouldn't do this (at least by default) as you might forget to call setOutputMarkupId(true) on some components that interacts with custom javascript. However your code will still work because _everything_ has an dom id now. Once you deploy you will realize that you missed something importa

Re: Make output markup container id default for development mode

2008-04-03 Thread Igor Vaynberg
fine by me -igor On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > We have this nice feature that puts the markup container's id in > comments into the generated markup. This is really handy for debugging > purposes. Should we enable this feature by the default duri

Re: Make output markup container id default for development mode

2008-04-03 Thread Matej Knopp
I think so. It doesn't do anything harmful imho, just adds some html comments. +1. -Matej On Thu, Apr 3, 2008 at 11:31 PM, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > We have this nice feature that puts the markup container's id in > comments into the generated markup. This is really handy fo

Make output markup container id default for development mode

2008-04-03 Thread Martijn Dashorst
We have this nice feature that puts the markup container's id in comments into the generated markup. This is really handy for debugging purposes. Should we enable this feature by the default during development? Martijn -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.2 is r