tests fixed, merged into master.
-igor
On Tue, Feb 18, 2014 at 5:29 AM, Martin Grigorov wrote:
> On Mon, Feb 17, 2014 at 5:48 AM, Igor Vaynberg wrote:
>
>> i think the implementation is good enough to be merged into master
>> now. it supports:
>>
>
> I am still not able to fix the tests
> I will
On Tue, Feb 18, 2014 at 3:29 PM, Martin Grigorov wrote:
>
>
>
> On Mon, Feb 17, 2014 at 5:48 AM, Igor Vaynberg wrote:
>
>> i think the implementation is good enough to be merged into master
>> now. it supports:
>>
>
> I am still not able to fix the tests
> I will need more time to get acquaint wit
On Mon, Feb 17, 2014 at 5:48 AM, Igor Vaynberg wrote:
> i think the implementation is good enough to be merged into master
> now. it supports:
>
I am still not able to fix the tests
I will need more time to get acquaint with the new code to be able to
maintain it
>
> * dequeuing algorithm that
I just merged from master and ran mvn clean install locally and many tests
fail
So I reverted to
commit 3a3e32a597aa312f97cc588a66780783cd0eb9ed
Author: Igor Vaynberg
Date: Sat Feb 15 21:56:18 2014 -0800
dequeue docs
and the build breaks the same way.
I will debug it.
Martin Grigorov
Wi
i think the implementation is good enough to be merged into master
now. it supports:
* dequeuing algorithm that delegates to components so subclasses can
override (this is how repeaters and borders support it)
* support for all major constructs: panels, borders, repeaters
* support for auto compon
i am reworking the implementation a bit to properly support borders
and repeaters by delegating to components...will check it in when i
have it working...
-igor
On Fri, Feb 14, 2014 at 7:26 AM, Martin Grigorov wrote:
> On Mon, Feb 10, 2014 at 6:01 PM, Igor Vaynberg wrote:
>
>> On Mon, Feb 10, 2
On Mon, Feb 10, 2014 at 6:01 PM, Igor Vaynberg wrote:
> On Mon, Feb 10, 2014 at 6:26 AM, Martin Grigorov
> wrote:
> >
> > On Mon, Feb 10, 2014 at 9:43 AM, Igor Vaynberg >wrote:
> >
> > > i just pushed my new idea into sandbox/component-queueing-2
> > >
> > > the way this works now is instead of
On Mon, Feb 10, 2014 at 6:01 PM, Igor Vaynberg wrote:
> On Mon, Feb 10, 2014 at 6:26 AM, Martin Grigorov
> wrote:
> >
> > On Mon, Feb 10, 2014 at 9:43 AM, Igor Vaynberg >wrote:
> >
> > > i just pushed my new idea into sandbox/component-queueing-2
> > >
> > > the way this works now is instead of
On Mon, Feb 10, 2014 at 6:26 AM, Martin Grigorov wrote:
>
> On Mon, Feb 10, 2014 at 9:43 AM, Igor Vaynberg wrote:
>
> > i just pushed my new idea into sandbox/component-queueing-2
> >
> > the way this works now is instead of doing it in onInitialize() and in
> > onConfigure() and all the other pla
>>>> #onConfigure().
> > >>>> Here I had to change Enclosure class - the child component resolving
> > >>>> should
> > >>>> be done as late as possible just before the rendering phase starts.
> > >>>>
> >
gt;>> be done as late as possible just before the rendering phase starts.
> >>>>
> >>>> Martin Grigorov
> >>>> Wicket Training and Consulting
> >>>>
> >>>>
> >>>> On Fri, Jan 24, 2014 at 11:47 AM, Martin Grigo
) method that adds
>>>>> components into a list.
>>>>> Later org.apache.wicket.ComponentTreeBuilder#rebuild() uses the list,
>>>>> and finally the list is null-yfied in #onDetach() so it is not
>>>>> serialized
>>>>> and not a
current impl
I must have missed that. Is there an example in the branch?
See
https://github.com/apache/wicket/blob/markup-driven-component-tree/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java?source=c#L1886
There is no test yet.
I don't understand why there's need fo
ier this is possible
with the current impl
I must have missed that. Is there an example in the branch?
See
https://github.com/apache/wicket/blob/markup-driven-component-tree/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java?source=c#L1886
There is no test yet.
I don't
the tree.
>>>
>>> No need of @Auto anymore.
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>>
>>>
>>> On Fri, Jan 24, 2014 at 10:39 AM, Martin Grigorov
>>> wrote:
>>>
>>>>
>>&
n 24, 2014 at 10:39 AM, Martin Grigorov
>> wrote:
>>
>>>
>>>
>>> On Fri, Jan 24, 2014 at 9:48 AM, Sven Meier wrote:
>>>
>>>> > per-component basis - yes, as I explained earlier this is possible
>>>> with the current impl
>
gt; On Fri, Jan 24, 2014 at 9:48 AM, Sven Meier wrote:
>>
>>> > per-component basis - yes, as I explained earlier this is possible
>>> with the current impl
>>>
>>> I must have missed that. Is there an example in the branch?
>>>
>>
>&g
t 9:48 AM, Sven Meier wrote:
>
>> > per-component basis - yes, as I explained earlier this is possible with
>> the current impl
>>
>> I must have missed that. Is there an example in the branch?
>>
>
> See
> https://github.com/apache/wicket/blob/mark
On Fri, Jan 24, 2014 at 9:48 AM, Sven Meier wrote:
> > per-component basis - yes, as I explained earlier this is possible with
> the current impl
>
> I must have missed that. Is there an example in the branch?
>
See
https://github.com/apache/wicket/blob/markup-driven-componen
> per-component basis - yes, as I explained earlier this is possible
with the current impl
I must have missed that. Is there an example in the branch?
I don't understand why there's need for an @Auto annotation. Why would
some components be annotated and some not?
behaviors don't have hooks
On Fri, Jan 24, 2014 at 12:04 AM, Sven Meier wrote:
> Hi,
>
> I don't think we're heading the right direction with this and I wouldn't
> advertise it as anything yet.
>
I'd like to advertise it anyhow now just to have more people feeding me
with stoppers, as you and Igor do. Thanks! :-)
>
> Th
On Thu, Jan 23, 2014 at 6:36 PM, Igor Vaynberg wrote:
> On Thu, Jan 23, 2014 at 8:20 AM, Martin Grigorov
> wrote:
> > Once the markup driven construction is done (just before onInitialize())
> > the application will have to use the old good add()/addOrReplace().
>
> yeah, but onInitialize() is th
On Thu, Jan 23, 2014 at 8:16 PM, Igor Vaynberg wrote:
> On Thu, Jan 23, 2014 at 8:53 AM, Martin Grigorov
> wrote:
> > On Thu, Jan 23, 2014 at 6:36 PM, Igor Vaynberg >wrote:
> >
> >> On Thu, Jan 23, 2014 at 8:20 AM, Martin Grigorov
> >> wrote:
> >> > Once the markup driven construction is done (
Hi,
I don't think we're heading the right direction with this and I wouldn't
advertise it as anything yet.
There are more questions to come but here is one upfront:
>And it is configurable, by default disabled.
As Igor has written, this does not work with component libraries which
depend on
On Thu, Jan 23, 2014 at 8:53 AM, Martin Grigorov wrote:
> On Thu, Jan 23, 2014 at 6:36 PM, Igor Vaynberg wrote:
>
>> On Thu, Jan 23, 2014 at 8:20 AM, Martin Grigorov
>> wrote:
>> > Once the markup driven construction is done (just before onInitialize())
>> > the application will have to use the o
On Thu, Jan 23, 2014 at 6:36 PM, Igor Vaynberg wrote:
> On Thu, Jan 23, 2014 at 8:20 AM, Martin Grigorov
> wrote:
> > Once the markup driven construction is done (just before onInitialize())
> > the application will have to use the old good add()/addOrReplace().
>
> yeah, but onInitialize() is th
On Thu, Jan 23, 2014 at 8:20 AM, Martin Grigorov wrote:
> Once the markup driven construction is done (just before onInitialize())
> the application will have to use the old good add()/addOrReplace().
yeah, but onInitialize() is there to partially replace the constructor
as a place to add compone
Once the markup driven construction is done (just before onInitialize())
the application will have to use the old good add()/addOrReplace().
The components are already in the MarkupContainer#children data structure.
So each field will add extra 8 bytes on 64bit machine (or 4 bytes with
CompressedO
what about components added in onInitialize() or on onConfigure()?
this will also lead to a higher memory/serialization space usage since
by default you need a field to store the component ref.
not sure its worth doing it this way...
-igor
On Wed, Jan 22, 2014 at 12:12 PM, Martin Grigorov wro
At
https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=6ba324dba2eab841cedc5426f4560946f8688b10you
may see a very simple demo of the idea.
A new test is added - a base page with three component which are *not *added
to the page and three specializations of that page wit
Hi,
Recently Fridolin Jackstadt shared his approach to "autowire" components -
https://github.com/wicket-acc/wicket-autowire.
I believe this approach can solve two issues:
- duplicate construction of the component tree - once in the markup and
second time in Java code
- auto components available
31 matches
Mail list logo
