Re: Migration to 7 report

2015-05-07 Thread Martin Grigorov
On Wed, May 6, 2015 at 4:42 PM, Guillaume Smet guillaume.s...@gmail.com wrote: On Mon, May 4, 2015 at 9:26 PM, Martin Grigorov mgrigo...@apache.org wrote: What's wrong with 'instanceof'+casting? Nothing, except it's more verbose. I'll go do that. I was wondering if it might be worth it

Re: Migration to 7 report

2015-05-06 Thread Guillaume Smet
On Mon, May 4, 2015 at 9:26 PM, Martin Grigorov mgrigo...@apache.org wrote: What's wrong with 'instanceof'+casting? Nothing, except it's more verbose. I'll go do that. I was wondering if it might be worth it to add a way to define the error keys with a setter of PatternValidator. We usually

Migration to 7 report

2015-05-04 Thread Guillaume Smet
Hi all, Just a report on the progress of our migration to 7. So far, I have migrated our bare application template without too many problems. The only real issue so far is this change of API in PatternValidator: protected IValidationError decorate(IValidationError error, IValidatableString

Re: Migration to 7 report

2015-05-04 Thread Martin Grigorov
Hi Guillaume, If org.apache.wicket.validation.validator.PatternValidator#validate() was 'final' then I'd agree to revert it but the change has been made to make it possible to use custom types of IValidationError. At my former client we used custom IVEs a lot and I'm afraid this may look like a