RE: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-04-01 Thread Martijn C. Vos
Martijn Dashorst wrote: > I guess this should go into Wicket NG (2.0/1.5) as a > replacement for the current image map. I don't think it is a > problem that we break backwards compatibility for a couple > components in the release after the generics release. ... > I'll add this one to the wish list

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-31 Thread Thijs
Not sure, you would probably pull a new patch of the new trunk. And in that case give it a new name. But I think that you should ensure you patch is stable enough, before it is commit. In an other apache project (solr) I see that a new feature / big bug-fixes are often debated and people submit

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-31 Thread Martijn Vos
Thijs wrote: If you attach a new patch with the same filename. Jira will automatically deprecate your old patch. But what if someone has already applied/commited my original patch? mcv.

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-30 Thread Thijs
If you attach a new patch with the same filename. Jira will automatically deprecate your old patch. Thijs Martijn Dashorst schreef: same :) On 3/31/08, Martijn Vos <[EMAIL PROTECTED]> wrote: Martijn Vos wrote: > Thanks for the response. I've just attached my patch to the bug issue. I ju

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-30 Thread Martijn Dashorst
same :) On 3/31/08, Martijn Vos <[EMAIL PROTECTED]> wrote: > Martijn Vos wrote: > > Thanks for the response. I've just attached my patch to the bug issue. > > > I just realised two things: > > Firstly, it's not necessary to break compatibility with the old > ImageMap. The old > ImageMap requir

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-30 Thread Martijn Vos
Martijn Vos wrote: Thanks for the response. I've just attached my patch to the bug issue. I just realised two things: Firstly, it's not necessary to break compatibility with the old ImageMap. The old ImageMap requires that it's linked to an tag, whereas my new version requires it to be link

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-30 Thread Martijn Vos
Martijn Dashorst wrote: I guess this should go into Wicket NG (2.0/1.5) as a replacement for the current image map. I don't think it is a problem that we break backwards compatibility for a couple components in the release after the generics release. I'd chalk this one up to the Wicket 1.0 compo

Re: WICKET-1456: rewrite existing ImageMap or create a new one?

2008-03-30 Thread Martijn Dashorst
I guess this should go into Wicket NG (2.0/1.5) as a replacement for the current image map. I don't think it is a problem that we break backwards compatibility for a couple components in the release after the generics release. I'd chalk this one up to the Wicket 1.0 components. They exist since th