Re: [PR] Fix instructions on how to test with docker [wicket-site]

2023-11-15 Thread via GitHub
martin-g commented on PR #18: URL: https://github.com/apache/wicket-site/pull/18#issuecomment-1812406343 Thank you, @raboof ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix instructions on how to test with docker [wicket-site]

2023-11-15 Thread via GitHub
martin-g merged PR #18: URL: https://github.com/apache/wicket-site/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@wicket.apache

[PR] Fix instructions on how to test with docker [wicket-site]

2023-11-15 Thread via GitHub
raboof opened a new pull request, #18: URL: https://github.com/apache/wicket-site/pull/18 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [wicket] jmewes commented on issue #367: Remove usage of deprecated method from test example

2019-06-01 Thread GitBox
jmewes commented on issue #367: Remove usage of deprecated method from test example URL: https://github.com/apache/wicket/pull/367#issuecomment-497956898 @bitstorm Welcome! This is an automated message from the Apache Git

[GitHub] [wicket] bitstorm commented on issue #367: Remove usage of deprecated method from test example

2019-06-01 Thread GitBox
bitstorm commented on issue #367: Remove usage of deprecated method from test example URL: https://github.com/apache/wicket/pull/367#issuecomment-497941295 @jmewes thank you! This is an automated message from the Apache Git

[GitHub] [wicket] bitstorm merged pull request #367: Remove usage of deprecated method from test example

2019-06-01 Thread GitBox
bitstorm merged pull request #367: Remove usage of deprecated method from test example URL: https://github.com/apache/wicket/pull/367 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [wicket] jmewes opened a new pull request #367: Remove usage of deprecated method from test example

2019-06-01 Thread GitBox
jmewes opened a new pull request #367: Remove usage of deprecated method from test example URL: https://github.com/apache/wicket/pull/367 The method `BaseWicketTester#startComponent(Component)` was removed in Wicket 7.0.0. See WICKET-5097

Re: wicket git commit: arquillian integration test management port is now configurable

2017-01-28 Thread Tobias Soloschenko
Hi Martin, it took just 5 minutes to fix this. I just used different ports for wicket-7.x and master so that if both builds are running there is no issue. I also rechecked the logs during the test run: INFO [org.wildfly.extension.undertow] JBAS017531: Host default-host starting INFO

Re: wicket git commit: arquillian integration test management port is now configurable

2017-01-28 Thread Tobias Soloschenko
;> Hi Martin, >> >>> Am 28.01.2017 um 21:55 schrieb Martin Grigorov : >>> >>> Hi Tobias, >>> >>>> On Sat, Jan 28, 2017 at 12:31 PM, wrote: >>>> >>>> Repository: wicket >>>> Updated Branches: >>&

Re: wicket git commit: arquillian integration test management port is now configurable

2017-01-28 Thread Martin Grigorov
; >> Repository: wicket > >> Updated Branches: > >> refs/heads/master 5b5e25c9c -> f4d5ddc84 > >> > >> > >> arquillian integration test management port is now configurable > >> > >> Project: http://git-wip-us.apache.org/repos/a

Re: wicket git commit: arquillian integration test management port is now configurable

2017-01-28 Thread Tobias Soloschenko
Hi Martin, > Am 28.01.2017 um 21:55 schrieb Martin Grigorov : > > Hi Tobias, > >> On Sat, Jan 28, 2017 at 12:31 PM, wrote: >> >> Repository: wicket >> Updated Branches: >> refs/heads/master 5b5e25c9c -> f4d5ddc84 >> >> >>

Re: wicket git commit: arquillian integration test management port is now configurable

2017-01-28 Thread Martin Grigorov
Hi Tobias, On Sat, Jan 28, 2017 at 12:31 PM, wrote: > Repository: wicket > Updated Branches: > refs/heads/master 5b5e25c9c -> f4d5ddc84 > > > arquillian integration test management port is now configurable > > Project: http://git-wip-us.apache.org/repos/asf/wicke

[GitHub] wicket-site pull request #9: Test INFRA-13227

2017-01-05 Thread martin-g
Github user martin-g closed the pull request at: https://github.com/apache/wicket-site/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] wicket-site pull request #9: Test INFRA-13227

2017-01-05 Thread martin-g
GitHub user martin-g opened a pull request: https://github.com/apache/wicket-site/pull/9 Test INFRA-13227 https://issues.apache.org/jira/browse/INFRA-13227 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martin-g/wicket-site-1

Re: wicket git commit: better test dependencies defaults as in wicket 7 and 8 plus changing wicket-core hamcrest dependency scope to test

2016-09-06 Thread Pedro Santos
wrote: > Hi Pedro, > > On Tue, Sep 6, 2016 at 12:11 AM, wrote: > >> Repository: wicket >> Updated Branches: >> refs/heads/wicket-6.x 5d5af682d -> 635b21c6e >> >> >> better test dependencies defaults as in wicket 7 and 8 plus changing >> wicke

Re: wicket git commit: better test dependencies defaults as in wicket 7 and 8 plus changing wicket-core hamcrest dependency scope to test

2016-09-06 Thread Martin Grigorov
Hi Pedro, On Tue, Sep 6, 2016 at 12:11 AM, wrote: > Repository: wicket > Updated Branches: > refs/heads/wicket-6.x 5d5af682d -> 635b21c6e > > > better test dependencies defaults as in wicket 7 and 8 plus changing > wicket-core hamcrest dependency scope to test >

Re: wicket git commit: WICKET-6134 Added regression test for WICKET-6043

2016-04-01 Thread Andrea Del Bene
You are welcome! Thanks for the explanation! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Apr 1, 2016 at 5:57 PM, andrea del bene wrote:

Re: wicket git commit: WICKET-6134 Added regression test for WICKET-6043

2016-04-01 Thread Martin Grigorov
ents are resolved earlier and now (as good > side effect) components can be dequeued even if their markup is inside an > autocomponent. In short WICKET-6088 made obsolete any previous solution > based on making components IQueueRegion. > > The test was added just for sanity-c

Re: wicket git commit: WICKET-6134 Added regression test for WICKET-6043

2016-04-01 Thread andrea del bene
ed on making components IQueueRegion. The test was added just for sanity-check. Maybe I should rename test method to something more meaningful? On 01/04/2016 16:59, Martin Grigorov wrote: Hi Andrea, I didn't understand how the use case from WICKET-6043 works now. So, you reverted the commi

Re: wicket git commit: WICKET-6134 Added regression test for WICKET-6043

2016-04-01 Thread Martin Grigorov
Hi Andrea, I didn't understand how the use case from WICKET-6043 works now. So, you reverted the commit that was a fix for 6043 and added a test case that verifies that the problem is fixed. But how is it fixed ? Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigoro

Re: wicket git commit: more test fixes

2016-03-30 Thread Sven Meier
ests are fixed. I think we can craft a regex to parse all parts. On Tue, Mar 29, 2016 at 11:13 PM, wrote: Repository: wicket Updated Branches: refs/heads/request_listener_simplification d97b70116 -> 76e175505 more test fixes Project: http://git-wip-us.apache.org/repos/asf/wicket/re

Re: wicket git commit: more test fixes

2016-03-30 Thread Martin Grigorov
t since it is optional we have "-.-". Let's try to get rid of it once the rest of the tests are fixed. I think we can craft a regex to parse all parts. On Tue, Mar 29, 2016 at 11:13 PM, wrote: > Repository: wicket > Updated Branches: > refs/heads/request_listener_simpl

Re: Winter time makes test fail: TimeOfDayTest

2015-10-26 Thread Martin Grigorov
+1 to deprecate Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Sun, Oct 25, 2015 at 1:25 PM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > While cleaning up warnings across the board I ran the tests and behold > we have a test that doesn

Re: Winter time makes test fail: TimeOfDayTest

2015-10-25 Thread Andrea Del Bene
Old story :-) http://wicket-dev.markmail.org/message/soepmwd2s3r6n5op?q=TimeOfDayTest+fails..today! +1 to deprecate them. While cleaning up warnings across the board I ran the tests and behold we have a test that doesn't work well with winter time/summer time (DST) Failed

Winter time makes test fail: TimeOfDayTest

2015-10-25 Thread Martijn Dashorst
While cleaning up warnings across the board I ran the tests and behold we have a test that doesn't work well with winter time/summer time (DST) Failed tests: TimeOfDayTest.test:37->Assert.assertEquals:144->Assert.assertEquals:118->Assert.failNotEquals:834->Assert.fail:88 e

Re: Wicket 7: failing test case

2015-07-03 Thread Martijn Dashorst
See https://issues.apache.org/jira/browse/WICKET-5942 for more details. I've modified the test case such that it passes (I suspect it is a bug in wicket tester rather than a bug in the actual ID generation), and added another case that fails the test (and have it ignored with a reference t

Re: Wicket 7: failing test case

2015-07-03 Thread Martijn Dashorst
According to git bisect this is the commit that caused the test failure: cfa36fbea6210aee1a70fdc79d9b78d7851c5a7a https://github.com/apache/wicket/commit/cfa36fbea6210aee1a70fdc79d9b78d7851c5a7a Martijn On Fri, Jul 3, 2015 at 11:17 AM, Martijn Dashorst wrote: > OK, now it fails in Eclipse

Re: Wicket 7: failing test case

2015-07-03 Thread Martijn Dashorst
OK, now it fails in Eclipse too. On Fri, Jul 3, 2015 at 11:15 AM, Martijn Dashorst wrote: > This is only from the command line, in Eclipse the test runs. > > Martijn > > > On Fri, Jul 3, 2015 at 10:43 AM, Martijn Dashorst > wrote: >> Current status: unable

Re: Wicket 7: failing test case

2015-07-03 Thread Martijn Dashorst
This is only from the command line, in Eclipse the test runs. Martijn On Fri, Jul 3, 2015 at 10:43 AM, Martijn Dashorst wrote: > Current status: unable to build the release due to: > > RepeaterTest.testHelloWorld:50->checkPage:60 » Markup The component > [Transpare

Wicket 7: failing test case

2015-07-03 Thread Martijn Dashorst
Current status: unable to build the release due to: RepeaterTest.testHelloWorld:50->checkPage:60 » Markup The component [Transpare... Martijn

Re: wicketstuff minis test errors

2015-02-21 Thread Tobias Soloschenko
nning without issues for you and others then everything is ok. :-) kind regards Tobias > Am 21.02.2015 um 19:49 schrieb Sven Meier : > > Builds fine here. What's the error? > > Sven > >> On 21.02.2015 18:57, Tobias Soloschenko wrote: >> Hi, >> >>

Re: wicketstuff minis test errors

2015-02-21 Thread Sven Meier
Builds fine here. What's the error? Sven On 21.02.2015 18:57, Tobias Soloschenko wrote: Hi, I noticed that one unit test class (TestRenderers) in wicketstuff-minis is running with errors. I run them before I integrated a new model (ReplacingResourceModel) http://apache-wicket.18429

wicketstuff minis test errors

2015-02-21 Thread Tobias Soloschenko
Hi, I noticed that one unit test class (TestRenderers) in wicketstuff-minis is running with errors. I run them before I integrated a new model (ReplacingResourceModel) http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html In wicket-6.x branch it is working

Re: git commit: WICKET-3335 test fixes

2014-02-21 Thread Igor Vaynberg
On Fri, Feb 21, 2014 at 5:09 AM, Martin Grigorov wrote: > > > On Fri, Feb 21, 2014 at 9:18 AM, wrote: >> >> Repository: wicket >> Updated Branches: >> refs/heads/sandbox/component-queueing-2 63d15c5c3 -> 1fd9d57c0 >> >> >> WICKET-3335 tes

Re: git commit: WICKET-3335 test fixes

2014-02-21 Thread Martin Grigorov
On Fri, Feb 21, 2014 at 9:18 AM, wrote: > Repository: wicket > Updated Branches: > refs/heads/sandbox/component-queueing-2 63d15c5c3 -> 1fd9d57c0 > > > WICKET-3335 test fixes > > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo > Commit: http:

Re: Test failing in WicketStuff, Scala module

2014-01-02 Thread Andrea Del Bene
I'm working on it :D > You should become Scala-addicted.Or at least Maven-addicted ;-) > Pull and try again. > > Martin Grigorov > Wicket Training and Consulting > > > On Thu, Jan 2, 2014 at 5:24 PM, Andrea Del Bene wrote: > >> hi, >> >> I still

Re: Test failing in WicketStuff, Scala module

2014-01-02 Thread Martin Grigorov
You should become Scala-addicted.Or at least Maven-addicted ;-) Pull and try again. Martin Grigorov Wicket Training and Consulting On Thu, Jan 2, 2014 at 5:24 PM, Andrea Del Bene wrote: > hi, > > I still getting a failure with a test case in WicketStuff. The test is > SampleP

Test failing in WicketStuff, Scala module

2014-01-02 Thread Andrea Del Bene
hi, I still getting a failure with a test case in WicketStuff. The test is SamplePageSpec from module wicketstuff-sample, a module from scala-extensions-parent. it can not find the home page markup: org.apache.wicket.markup.MarkupNotFoundException: Can not determine Markup. Component is not yet

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-09 Thread Andrea Del Bene
everything is fine now with the fix... Running with T < 21s causes consistent failures in the test (fails on first test run). Running with T=21 makes the test succeed consistently (i.e. 4 times in a row successful). So it appears to be a starvation issue. Martijn On Mon, Dec 9, 2013 at 9:07

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-09 Thread Andrea Del Bene
21s causes consistent failures in the test (fails on > first test run). Running with T=21 makes the test succeed consistently > (i.e. 4 times in a row successful). So it appears to be a starvation > issue. > > Martijn > > On Mon, Dec 9, 2013 at 9:07 AM, Emond Papegaaij > wrote:

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-09 Thread Martijn Dashorst
Running with T < 21s causes consistent failures in the test (fails on first test run). Running with T=21 makes the test succeed consistently (i.e. 4 times in a row successful). So it appears to be a starvation issue. Martijn On Mon, Dec 9, 2013 at 9:07 AM, Emond Papegaaij wrote: > This te

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-09 Thread Martin Grigorov
the maven release process to its conclusion due to a > failing test: > > Tests in error: > > > failToReleaseUnderLoad(org.apache.wicket.page.PageAccessSynchronizerTest): > Could not lock page 0. Attempt lasted 10 seconds > > > Relevant info

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-09 Thread Emond Papegaaij
hour if needed. Emond On Sunday 08 December 2013 20:14:59 Martijn Dashorst wrote: > The PageAccessSynchronizerTest#ReleaseUnderLoad() test fails when run > on OS X Mavericks on a Hasswell generation core i7 using OS X supplied > Java 6: > > java version "1.6.0_65&qu

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-08 Thread Martijn Dashorst
The PageAccessSynchronizerTest#ReleaseUnderLoad() test fails when run on OS X Mavericks on a Hasswell generation core i7 using OS X supplied Java 6: java version "1.6.0_65" Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609) Java HotSpot(TM) 64-Bit Server VM (build 20.

Re: Releasing 6.13.0: Test failure in 6.x

2013-12-08 Thread Martijn Dashorst
Of course it works running java 7, but I'd rather not use that to cut our release. Martijn On Sun, Dec 8, 2013 at 6:25 PM, Martijn Dashorst wrote: > I'm unable to run the maven release process to its conclusion due to a > failing test: > > Tests in error: > &

Releasing 6.13.0: Test failure in 6.x

2013-12-08 Thread Martijn Dashorst
I'm unable to run the maven release process to its conclusion due to a failing test: Tests in error: failToReleaseUnderLoad(org.apache.wicket.page.PageAccessSynchronizerTest): Could not lock page 0. Attempt lasted 10 seconds Relevant information for the stuff used in the release:

Re: Failing test in wicket-6.x

2013-09-20 Thread Martijn Dashorst
The build is now uploading to the dist.apache.org svn repo, so it appears to be a random thing that the test fails... Not sure what to make of it though... Martijn On Fri, Sep 20, 2013 at 11:22 AM, Martin Grigorov wrote: > The build of wicket-6.x branch passes here. > BuildBot is OK a

Re: Failing test in wicket-6.x

2013-09-20 Thread Martin Grigorov
The build of wicket-6.x branch passes here. BuildBot is OK as well - http://ci.apache.org/builders/wicket-branch-6.x On Fri, Sep 20, 2013 at 12:18 PM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > I started off a build for 6.11, but got this error: > > failToReleaseUnderLoad(org.apache

Failing test in wicket-6.x

2013-09-20 Thread Martijn Dashorst
I started off a build for 6.11, but got this error: failToReleaseUnderLoad(org.apache.wicket.page.PageAccessSynchronizerTest): Could not lock page 0. Attempt lasted 10 seconds I'll restart the build process to see if this is a fluke... Martijn

Re: A problem with a test method from wicket-time

2013-06-13 Thread Sven Meier
roblem :-/. BUT I've noted that if we try to run the single test method via maven (mvn -Dtest=DateConverterTest#testCalendar<...> test) it works fine. We can also run without problems all the test methods of class DateConverterTest (mvn -Dtest=DateConverterTest test). We could proceed

Re: A problem with a test method from wicket-time

2013-06-13 Thread Andrea Del Bene
I've got this problem on my machine at work. On my personal laptop, which has the same configuration (Ubuntu 12.04 64bit, Java 7) I don't have any problem :-/. BUT I've noted that if we try to run the single test method via maven (mvn -Dtest=DateConverterTest#testCalendar<.

Re: A problem with a test method from wicket-time

2013-06-13 Thread Sven Meier
Thu, Jun 13, 2013 at 6:07 PM, Andrea Del Bene wrote: hi, I'm having a little weird problem with unit test method testCalendarConverterWithDeleg**ate from class DateConverterTest. If I run it from Eclipse everything is fine but if a try to run tests from maven I get a failure with the f

Re: A problem with a test method from wicket-time

2013-06-13 Thread Andrea Del Bene
It was just right above my nose :) Hi Andrea, Sven wrote a mail to dev@ about this problem yesterday. Help him debug it ! On Thu, Jun 13, 2013 at 6:07 PM, Andrea Del Bene wrote: hi, I'm having a little weird problem with unit test method testCalendarConverterWithDeleg**ate from

Re: A problem with a test method from wicket-time

2013-06-13 Thread Martin Grigorov
Hi Andrea, Sven wrote a mail to dev@ about this problem yesterday. Help him debug it ! On Thu, Jun 13, 2013 at 6:07 PM, Andrea Del Bene wrote: > hi, > > I'm having a little weird problem with unit test method > testCalendarConverterWithDeleg**ate from class DateConverterTe

A problem with a test method from wicket-time

2013-06-13 Thread Andrea Del Bene
hi, I'm having a little weird problem with unit test method testCalendarConverterWithDelegate from class DateConverterTest. If I run it from Eclipse everything is fine but if a try to run tests from maven I get a failure with the following text (more or less): Exprected: ...,YEAR

Re: Problem with test

2012-11-11 Thread Andrea Del Bene
r any of the current Wicket devs run the build on Windows. This test have never failed for me on Ubuntu and neither BuildBot ( http://ci.apache.org/builders/wicket-master) nor Jenkins have reported such error. But both of them run on Linux/Unix. On Sat, Nov 10, 2012 at 5:02 PM, Andrea Del Bene w

Re: Problem with test

2012-11-11 Thread Martin Grigorov
Hi Andrea, What is your OS ? Check with "ping unknown". It could be that your etc/hosts has an entry for it or your DNS has such entry. Additionally I'm not sure whether any of the current Wicket devs run the build on Windows. This test have never failed for me on Ubuntu and n

Problem with test

2012-11-10 Thread Andrea Del Bene
I've noticed that test method testExtractFromContainerRequestUnknownXForwardedFor inside WebClientInfoTest randomly fails. In short it seems that sometimes InetAddress.getByName (inide WebClientInfo, line 148) returns a valid ip for 'unknown'. Has anybody experienced this pr

Re: Request for help: simple GitHub test

2011-12-18 Thread Martin Grigorov
e: >> >> If anybody here has ten minutes available to help me test some GitHub >> features, please see [1] and complete the first batch of steps. >>  Basically, >> fork that repo, add a commit or two, and then create a pull request for >> me. >>  I'll

Re: Request for help: simple GitHub test

2011-12-11 Thread Sven Meier
Pull requested. Sven On 12/11/2011 02:35 AM, Jeremy Thomerson wrote: If anybody here has ten minutes available to help me test some GitHub features, please see [1] and complete the first batch of steps. Basically, fork that repo, add a commit or two, and then create a pull request for me

Re: Request for help: simple GitHub test

2011-12-10 Thread Igor Vaynberg
pull request pending -igor On Sat, Dec 10, 2011 at 5:35 PM, Jeremy Thomerson wrote: > If anybody here has ten minutes available to help me test some GitHub > features, please see [1] and complete the first batch of steps.  Basically, > fork that repo, add a commit or two, and then crea

Request for help: simple GitHub test

2011-12-10 Thread Jeremy Thomerson
If anybody here has ten minutes available to help me test some GitHub features, please see [1] and complete the first batch of steps. Basically, fork that repo, add a commit or two, and then create a pull request for me. I'll take it from there. If I can get a few pull requests (or even a

Re: svn commit: r1190589 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java test/java/org/apache/wicket/protocol/http/servlet/ServletWebReques

2011-10-31 Thread Martin Grigorov
-4168 >> >> Modified: >>     >> wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java >>     >> wicket/trunk/wicket-core/src/test/java/org/apache/wicket/protocol/http/servlet/ServletWebRequestTest.java >> >>

Re: svn commit: r1190589 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java test/java/org/apache/wicket/protocol/http/servlet/ServletWebReques

2011-10-31 Thread Martin Grigorov
> Modified: >     > wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java >     > wicket/trunk/wicket-core/src/test/java/org/apache/wicket/protocol/http/servlet/ServletWebRequestTest.java > > Modified: > wicket/trunk/wi

Commit 1185985 has broken test?

2011-10-19 Thread Andrea Del Bene
Hi, it seems that the commit in object has broken test SecurePackageResourceGuardTest.fileOnly, assertion 'guard.acceptAbsolutePath("../test.gif")' With this commit in ResourceSettings the default value for parentFolderPlaceholder has been setted to '::' but

Re: svn commit: r1172909 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/ main/java/org/apache/wicket/behavior/ test/java/org/apache/wicket/behavior/

2011-09-20 Thread Martin Grigorov
t/Behaviors.java >     > wicket/trunk/wicket-core/src/main/java/org/apache/wicket/behavior/Behavior.java >     > wicket/trunk/wicket-core/src/main/java/org/apache/wicket/behavior/InvalidBehaviorIdException.java >     > wicket/trunk/wicket-core/src/test/java/org/apache/wicket/be

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martin Grigorov
t;>> *www.brunoborges.com* >>> >>> >>> >>> On Mon, Aug 29, 2011 at 4:46 PM, Martijn Dashorst < >>> martijn.dasho...@gmail.com> wrote: >>> >>>> The issue is not the new logic, but rather the change in signature. >>>&

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Frank van Lankvelt
tting it into production with an existing war... I can >>> see enough reason not to have to recompile a whole codebase for a >>> 1.5.1 upgrade. Instead just upgrade the jar, repackage and deploy to >>> your test server. Boom, doesn't work with nosuchmethod error. &

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Bruno Borges
2011 at 4:46 PM, Martijn Dashorst < > > martijn.dasho...@gmail.com> wrote: > > > >> The issue is not the new logic, but rather the change in signature. > >> PageParameters is not a rarely used class. > >> > >> As for not putting it into pro

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martin Grigorov
y used class. >> >> As for not putting it into production with an existing war... I can >> see enough reason not to have to recompile a whole codebase for a >> 1.5.1 upgrade. Instead just upgrade the jar, repackage and deploy to >> your test server. Boom, doesn't wor

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Bruno Borges
ead just upgrade the jar, repackage and deploy to > your test server. Boom, doesn't work with nosuchmethod error. > > Martijn > > On Mon, Aug 29, 2011 at 9:37 PM, Martin Grigorov > wrote: > > I mean remove the new logic in this method, not the whole method > > &g

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martin Grigorov
be such users out there > your test server. Boom, doesn't work with nosuchmethod error. > > Martijn > > On Mon, Aug 29, 2011 at 9:37 PM, Martin Grigorov wrote: >> I mean remove the new logic in this method, not the whole method >> >> On Mon, Aug 29, 2011 at

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martijn Dashorst
, repackage and deploy to your test server. Boom, doesn't work with nosuchmethod error. Martijn On Mon, Aug 29, 2011 at 9:37 PM, Martin Grigorov wrote: > I mean remove the new logic in this method, not the whole method > > On Mon, Aug 29, 2011 at 9:37 PM, Martin Grigorov wrote: >> I

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martin Grigorov
-3938 Impossible to remove particular key-value from PageParameters >>> >>> >>> Modified: >>>     >>> wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/INamedParameters.java >>>     >>> wicket/trunk

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martin Grigorov
    >> wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java >>     >> wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/parameter/PageParametersTest.java >> >> Modified: >> wicket/trunk/

Re: svn commit: r1162772 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/mapper/parameter/ test/java/org/apache/wicket/request/mapper/parameter/

2011-08-29 Thread Martijn Dashorst
/parameter/PageParameters.java >     > wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/mapper/parameter/PageParametersTest.java > > Modified: > wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/INamedParameters.java > URL: >

Re: svn commit: r1139477 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/Url.java test/java/org/apache/wicket/request/UrlTest.java

2011-06-26 Thread Martin Grigorov
The commit diff looked like you renamed and removed the test for UrlDecoder. Sorry. It is here. I'll move the test for Url in -request. On Sat, Jun 25, 2011 at 1:18 PM, Peter Ertl wrote: > Hi Martin, > > what test for URLDecoder are you talking about? To the best of my knowledg

Re: svn commit: r1139477 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/Url.java test/java/org/apache/wicket/request/UrlTest.java

2011-06-25 Thread Peter Ertl
Hi Martin, what test for URLDecoder are you talking about? To the best of my knowledge I did not delete anything. I _copied_ from UrlEncoderTest but the file is still there. Merging UrlTest from wicket-core with UrlTest in wicket-request makes sense. Did not realize there's another test

Re: svn commit: r1139477 - in /wicket/trunk/wicket-request/src: main/java/org/apache/wicket/request/Url.java test/java/org/apache/wicket/request/UrlTest.java

2011-06-24 Thread Martin Grigorov
Why the hell the test for URLDecoder has been killed and replaced with something else ?!? We have tests for Url at org.apache.wicket.request.UrlTest in wicket-core. I agree that it belongs to wicket-request and to be able to move it there it should get rid of WicketObjects usage but this kind of

Re: svn commit: r1132204 - /wicket/trunk/wicket-core/src/test/java/org/apache/wicket/page/persistent/disk/DiskDataStoreTest.java

2011-06-05 Thread Martin Grigorov
This test also started failing here after I did "svn update" for the commits from this weekend. It fails only when I build it with bg_BG locale On Sun, Jun 5, 2011 at 12:00 PM, wrote: > Author: jdonnerstag > Date: Sun Jun  5 09:00:51 2011 > New Revision: 1132204 > > U

Re: failing test on trunk

2011-06-03 Thread Martin Grigorov
G and Maven3/en_US >>> >>> On Fri, Jun 3, 2011 at 2:46 PM, Ernesto Reinaldo Barreiro >>> wrote: >>>> Hi, >>>> >>>> I just did a clean check out of trunk + mvn install and I get some >>>> test failing on wicket-util subp

Re: failing test on trunk

2011-06-03 Thread Juergen Donnerstag
icket%201.5.x/ >> all is green right now. >> I build with Maven2/bg_BG and Maven3/en_US >> >> On Fri, Jun 3, 2011 at 2:46 PM, Ernesto Reinaldo Barreiro >> wrote: >>> Hi, >>> >>> I just did a clean check out of trunk + mvn install and I get so

Re: failing test on trunk

2011-06-03 Thread Martin Grigorov
esto > > On Fri, Jun 3, 2011 at 2:07 PM, Martin Grigorov wrote: >> can you provide the surefire result file for this test ? >> >> On Fri, Jun 3, 2011 at 3:04 PM, Ernesto Reinaldo Barreiro >> wrote: >>> Martin, >>> >>> I get it at >>&

Re: failing test on trunk

2011-06-03 Thread Ernesto Reinaldo Barreiro
Yes. Will mail them to you. Best, Ernesto On Fri, Jun 3, 2011 at 2:07 PM, Martin Grigorov wrote: > can you provide the surefire result file for this test ? > > On Fri, Jun 3, 2011 at 3:04 PM, Ernesto Reinaldo Barreiro > wrote: >> Martin, >>

Re: failing test on trunk

2011-06-03 Thread Martin Grigorov
can you provide the surefire result file for this test ? On Fri, Jun 3, 2011 at 3:04 PM, Ernesto Reinaldo Barreiro wrote: > Martin, > > I get it at > > org.util.string.StringTest.testLogger() > > Ernesto > > On Fri, Jun 3, 2011 at 1:57 PM, Martin Grigorov wrot

Re: failing test on trunk

2011-06-03 Thread Ernesto Reinaldo Barreiro
t; I build with Maven2/bg_BG and Maven3/en_US > > On Fri, Jun 3, 2011 at 2:46 PM, Ernesto Reinaldo Barreiro > wrote: >> Hi, >> >> I just did a clean check out of trunk + mvn install and I get some >> test failing on wicket-util subproject. Is this a known issue? >

Re: failing test on trunk

2011-06-03 Thread Martin Grigorov
out of trunk + mvn install and I get some >> test failing on wicket-util subproject. Is this a known issue? >> >> Regards, >> >> Enresto >> > > > > -- > Martin Grigorov > jWeekend > Training, Consulting, Development > http://jWeekend.com > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com

Re: failing test on trunk

2011-06-03 Thread Martin Grigorov
unk + mvn install and I get some > test failing on wicket-util subproject. Is this a known issue? > > Regards, > > Enresto > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com

failing test on trunk

2011-06-03 Thread Ernesto Reinaldo Barreiro
Hi, I just did a clean check out of trunk + mvn install and I get some test failing on wicket-util subproject. Is this a known issue? Regards, Enresto

Re: svn commit: r1103594 - in /wicket/branches/wicket-1.4.x/wicket/src: main/java/org/apache/wicket/markup/html/form/upload/ test/java/org/apache/wicket/markup/html/form/upload/

2011-05-15 Thread Martin Grigorov
istence > Issue: WICKET-3715 > > Modified: > > > wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/FileUpload.java > > > wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/upload/FileUploadFie

Re: Test failure probably due to locale

2011-05-08 Thread Martin Grigorov
uot;££")); >> i.e. "££" seems to be broken by your ide. >> >> See at >> http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/ComponentTagAttributeEscapingTest.java?view=markup >> >> On Sun, May 8, 2011 at 11:43

Re: Test failure probably due to locale

2011-05-08 Thread Juergen Donnerstag
ly looks like: > assertTrue("One of the pound entity representations is missing: > £ or £", >                        response.contains("££")); > i.e. "££" seems to be broken by your ide. > > See at > http://svn.apache.org/viewvc/wick

Re: Test failure probably due to locale

2011-05-08 Thread Martin Grigorov
The code actually looks like: assertTrue("One of the pound entity representations is missing: £ or £", response.contains("££")); i.e. "££" seems to be broken by your ide. See at http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test

Re: Test failure probably due to locale

2011-05-08 Thread Juergen Donnerstag
e. > My Maven setup uses bg_BG and again all is fine. Just verified. > Igor mentioned that this test started to fail at his machine > yesterday, but I guess his setup completely is en_US. > > On Sun, May 8, 2011 at 11:13 AM, Juergen Donnerstag > wrote: >

Re: Test failure probably due to locale

2011-05-08 Thread Martin Grigorov
My Eclipse uses en_US locale and all is fine. My Maven setup uses bg_BG and again all is fine. Just verified. Igor mentioned that this test started to fail at his machine yesterday, but I guess his setup completely is en_US. On Sun, May 8, 2011 at 11:13 AM, Juergen Donnerstag wrote: > Hi, >

Re: Test failure probably due to locale

2011-05-08 Thread Carl-Eric Menzel
On Sun, 8 May 2011 11:13:27 +0200 Juergen Donnerstag wrote: > The assertion test is like: response.contains("££")); replacing it > with response.contains("\u00A3\u00A3")); works for me. It's loading UTF-8 data but interprets it as probably ISO-8859-1.

Test failure probably due to locale

2011-05-08 Thread Juergen Donnerstag
(ComponentTagAttributeEscapingTest.java:48) The output looks like: link The assertion test is like: response.contains("££")); replacing it with response.contains("\u00A3\u00A3")); works for me. Interestingly it's failing in eclipse only. It passes the test with maven -Juergen

Re: svn commit: r1085095 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/markup/ main/java/org/apache/wicket/markup/parser/ main/java/org/apache/wicket/markup/parser/filter/ test/java/

2011-03-25 Thread Martin Grigorov
On Fri, Mar 25, 2011 at 9:03 AM, Juergen Donnerstag < juergen.donners...@gmail.com> wrote: > Please bear in mind both approaches serve different purposes: > > IMarkupResourceStreamProvider: provide a resource stream no matter > where it come from. The stream gets cached and everything, like a > no

Re: svn commit: r1085095 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/markup/ main/java/org/apache/wicket/markup/parser/ main/java/org/apache/wicket/markup/parser/filter/ test/java/

2011-03-25 Thread Juergen Donnerstag
Please bear in mind both approaches serve different purposes: IMarkupResourceStreamProvider: provide a resource stream no matter where it come from. The stream gets cached and everything, like a normal markup file => is invoked only once Component.get/setMarkup: allows you to provide your own Com

Re: svn commit: r1085095 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/markup/ main/java/org/apache/wicket/markup/parser/ main/java/org/apache/wicket/markup/parser/filter/ test/java/

2011-03-24 Thread Juergen Donnerstag
yes, makes sense. Feel free to commit the change. On Thu, Mar 24, 2011 at 10:38 PM, Martin Grigorov wrote: > +       public static Markup get(final String markup) > > cool! > this makes IMarkupResourceStreamProvider a bit redudant > What about renaming the method to .of(String) so it looks like M

  1   2   >