[GitHub] [ws-wss4j] coheigea commented on issue #2: WSS-659 SecurityContextToken validator fixing QName

2020-01-08 Thread GitBox
coheigea commented on issue #2: WSS-659 SecurityContextToken validator fixing QName URL: https://github.com/apache/ws-wss4j/pull/2#issuecomment-572168048 The easiest way is just to subclass SecurityContextTokenValidatorImpl and call super.validate

[GitHub] [ws-wss4j] CauchyPeano edited a comment on issue #2: WSS-659 SecurityContextToken validator fixing QName

2020-01-08 Thread GitBox
CauchyPeano edited a comment on issue #2: WSS-659 SecurityContextToken validator fixing QName URL: https://github.com/apache/ws-wss4j/pull/2#issuecomment-572164340 Because i need to return it. Can I return `null` in `validate` result?

[GitHub] [ws-wss4j] CauchyPeano commented on issue #2: WSS-659 SecurityContextToken validator fixing QName

2020-01-08 Thread GitBox
CauchyPeano commented on issue #2: WSS-659 SecurityContextToken validator fixing QName URL: https://github.com/apache/ws-wss4j/pull/2#issuecomment-572164340 Yes, but can I return `null` in `validate` result? This is an

[GitHub] [ws-wss4j] coheigea commented on issue #2: WSS-659 SecurityContextToken validator fixing QName

2020-01-08 Thread GitBox
coheigea commented on issue #2: WSS-659 SecurityContextToken validator fixing QName URL: https://github.com/apache/ws-wss4j/pull/2#issuecomment-572160332 Why are you adding a AbstractInboundSecurityToken ? If you look at say the test testSCTDKTEncryptInbound in

[GitHub] [ws-wss4j] CauchyPeano commented on issue #2: WSS-659 SecurityContextToken validator fixing QName

2020-01-08 Thread GitBox
CauchyPeano commented on issue #2: WSS-659 SecurityContextToken validator fixing QName URL: https://github.com/apache/ws-wss4j/pull/2#issuecomment-572142741 Hey @coheigea , I am trying to write test now, and have difficulty to understanding how to write Validator. Here is what I am

[GitHub] [ws-wss4j] CauchyPeano edited a comment on issue #2: WSS-659 SecurityContextToken validator fixing QName

2020-01-08 Thread GitBox
CauchyPeano edited a comment on issue #2: WSS-659 SecurityContextToken validator fixing QName URL: https://github.com/apache/ws-wss4j/pull/2#issuecomment-572142741 Hey @coheigea , I am trying to write test now, and have difficulty to understand how to write Validator. Here is what