Re: [Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-31 Thread Pamod Sylvester
Also based on [1] it specifies the following on un-subscription under the section "Unsubscribe" of shared/ non shared durable subscriptions. "It is erroneous for a client to delete a durable subscription *while there is an active (not closed) consumer for the subscription*, or while a consumed mes

Re: [Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-30 Thread Hasitha Hiranya
By AMQP semantics "unsubscribe" call breaks into two subsequent calls. 1. subscription close 2. queue delete If only one subscriber is there these calls does not matter. When there are multiple (shared durable), with the existing impl I guess we will delete the queue. Meaning rest of the subscrib

Re: [Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-30 Thread Hemika Kodikara
+1 for option 2. Because if one client send 'unsubscribe', it does not mean other clients should be unsubscribed as well. Regards, Hemika Hemika Kodikara Software Engineer WSO2 Inc. lean . enterprise . middleware http://wso2.com Mobile : +9477762 On Mon, Aug 31, 2015 at 11:16 AM, Asanka Ab

Re: [Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-30 Thread Ramith Jayasinghe
than when are you suggesting to do the actual 'unsubscribe' ? after last one says 'unsubscribe'? On Mon, Aug 31, 2015 at 11:16 AM, Asanka Abeyweera wrote: > I think we should follow what we do with the queue subscriptions. For > queues we don't remove all the subscriptions when a single subscrib

Re: [Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-30 Thread Asanka Abeyweera
I think we should follow what we do with the queue subscriptions. For queues we don't remove all the subscriptions when a single subscriber sends an unsubscribe request. Therefore +1 for option 2. . On Mon, Aug 31, 2015 at 11:02 AM, Pamod Sylvester wrote: > Hi All, > > When enabled shared subsc

Re: [Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-30 Thread Ramith Jayasinghe
I think we should remove everyone in such situation. 'unsubscribe' is a conscious decision compared to a disconnect which could happen even due to a network outage. Thoughts? On Mon, Aug 31, 2015 at 11:02 AM, Pamod Sylvester wrote: > Hi All, > > When enabled shared subscriptions, it creates subs

[Dev] [MB] Shared Subscription - unsubscribe operation - expected behavior

2015-08-30 Thread Pamod Sylvester
Hi All, When enabled shared subscriptions, it creates subscription groups which are distinguished through the client ids of the consumers. hence, for a given durable topic it allows multiple subscriptions to be bound with the same client id, in return when a message is delivered, for the consumers