Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-26 Thread Udara Liyanage
Hi Anurudda, Merged. On Tue, May 26, 2015 at 12:38 PM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi Udara, > > I have fixed them now. > > Thanks, > > On Tue, May 26, 2015 at 12:07 PM, Udara Liyanage wrote: > >> Hi Anurudda, >> >> I put some comments for the pull request. Please co

Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-26 Thread Anuruddha Liyanarachchi
Hi Udara, I have fixed them now. Thanks, On Tue, May 26, 2015 at 12:07 PM, Udara Liyanage wrote: > Hi Anurudda, > > I put some comments for the pull request. Please consider/fix them. > > On Tue, May 26, 2015 at 11:56 AM, Anuruddha Liyanarachchi < > anurudd...@wso2.com> wrote: > >> Hi Imesh, >

Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-25 Thread Udara Liyanage
Hi Anurudda, I put some comments for the pull request. Please consider/fix them. On Tue, May 26, 2015 at 11:56 AM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi Imesh, > > I have now created configurator feature. > Can you please review and merge [1] for the same. > > [1] https://g

Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-25 Thread Anuruddha Liyanarachchi
Hi Imesh, I have now created configurator feature. Can you please review and merge [1] for the same. [1] https://github.com/wso2/product-private-paas/pull/73 Thanks On Tue, May 26, 2015 at 10:24 AM, Imesh Gunaratne wrote: > Hi Anuruddha, > > I think we also need to create a feature for the C

Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-25 Thread Imesh Gunaratne
Hi Anuruddha, I think we also need to create a feature for the Configurator and use that to build its product distribution. In addition we need to make sure that Configurator maven artifacts are uploaded to Nexus on maven deploy command. Thanks On Mon, May 25, 2015 at 9:20 PM, Imesh Gunaratne w

Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-25 Thread Imesh Gunaratne
Thanks Anuruddha! I reviewed your pull request and merged. On Mon, May 25, 2015 at 5:30 PM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi Imesh, > > I have now completed $subject. Can you please review and merge [1] > > [1]https://github.com/wso2/product-private-paas/pull/72 > > On

Re: [Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-25 Thread Anuruddha Liyanarachchi
Hi Imesh, I have now completed $subject. Can you please review and merge [1] [1]https://github.com/wso2/product-private-paas/pull/72 On Mon, May 25, 2015 at 12:25 PM, Imesh Gunaratne wrote: > Hi Anuruddha, > > I think we need to move the Configurator to components folder [1] and > rename it to

[Dev] [PPaaS] Need to move Configurator to Components and Create a Distribution

2015-05-24 Thread Imesh Gunaratne
Hi Anuruddha, I think we need to move the Configurator to components folder [1] and rename it to org.wso2.ppaas.configurator. In addition we need to create a product inside products folder [2] for generating its distribution (wso2ppaas-configurator-4.1.0.zip). We need to follow the standard guide