Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-29 Thread Amila De Silva
Fixed the issue and create a new PR [2]. The problem was, canAccess method in CallerContext has been incrementing both global and local counts. Due to this, a single request gets counted twice, and throttling quota gets depleted before reaching the maximum number of allowed requests. After fixing

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-25 Thread Amila De Silva
Hi Chanaka, Will check this. On Saturday, September 26, 2015, Chanaka Fernando wrote: > Hi AmilaD, > > After merging this change, we have seen that there are 3 integration test > failures in product-esb[1] . Please check these failures and resend the PR. > I'll revert the fix for the moment. >

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-25 Thread Chanaka Fernando
Hi AmilaD, After merging this change, we have seen that there are 3 integration test failures in product-esb[1] . Please check these failures and resend the PR. I'll revert the fix for the moment. [1] https://wso2.org/jenkins/job/product-esb/lastBuild/testReport/ On Fri, Sep 25, 2015 at 3:13 PM,

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-25 Thread Chanaka Fernando
Hi Amila, PR[1] is merged. [1] https://github.com/wso2/wso2-synapse/commit/d5815b2afcf7f2d9c8e5e5858e8cc45427a07ce0 On Fri, Sep 25, 2015 at 2:43 PM, Amila De Silva wrote: > Hi, > > Tested RoleBased Throttling on a two node APIM cluster after applying new > changes. Counts are properly getting

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-25 Thread Amila De Silva
Hi, Tested RoleBased Throttling on a two node APIM cluster after applying new changes. Counts are properly getting replicated across all the nodes. On Tue, Sep 15, 2015 at 5:05 PM, Amila De Silva wrote: > Hi, > > Created the PR[1], by merging latest throttling fixes with > synapse-commons. Afte

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-15 Thread Amila De Silva
Hi, Created the PR[1], by merging latest throttling fixes with synapse-commons. After doing the changes, was able to successfully build wso2-synapse and carbon-mediation with unit tests. Ran all the integration tests in product-esb, after building the product on top of latest synapse and carbon-me

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-14 Thread Amila De Silva
Hi Isuru, There aren't any changes to be merged on MEPClient and SynapseCallbackReceiver. Changes that need merging are done on classes residing under [1]. Let me clarify a bit what these changes are; While fixing some throttling issues in AM 1.6.0, certain changes were done on the part that rep

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-14 Thread Isuru Udana
Hi AmilaD, Can you please point us the changes need to be merged in synapse (in MEPClient and SynapseCallbackReceiver) ? On Mon, Sep 14, 2015 at 2:58 PM, Amila De Silva wrote: > Hi All, > > While carrying out this task, came to a point where certain classes cannot > be moved out of synapse. > >

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-14 Thread Amila De Silva
Hi All, While carrying out this task, came to a point where certain classes cannot be moved out of synapse. For some of the improvements done recently, ConcurrentAccessController (which is one of the classes that originally resided in throttle core) has been used from SynapseCallbackReceiver and

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-11 Thread Amila De Silva
Hi Chanaka, Since throttle core can be used on its own, thought of creating a separate feature out of that - so a new place to put throttle component. If we put it under mediation-throttle, that would imply two components have to be used together, isn't it? On Fri, Sep 11, 2015 at 6:45 PM, Chanak

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-11 Thread Chanaka Fernando
Hi Amila, You can find [1] which already has the throttle policy editor related packages and named as mediation-throttle. You can move the throttle-core packages to this component. [1] https://github.com/wso2/carbon-mediation/tree/master/components/mediation-throttle On Fri, Sep 11, 2015 at 6:23

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-11 Thread Sanjeewa Malalgoda
+1. On Fri, Sep 11, 2015 at 5:20 PM, Amila De Silva wrote: > Will be moving throttle.core to a new component under carbon-mediation. > The new component name will be throttle-core and a new feature with the > same name will be created. Planning to do these changes on > carbon-mediation 4.4.11-S

Re: [Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-11 Thread Amila De Silva
Will be moving throttle.core to a new component under carbon-mediation. The new component name will be throttle-core and a new feature with the same name will be created. Planning to do these changes on carbon-mediation 4.4.11-SNAPSHOT and synapse 2.1.3-wso2v12-SNAPSHOT. On Mon, Sep 7, 2015 at 6:2

[Dev] [Throttling] Moving throttle.core out from Synapse

2015-09-07 Thread Amila De Silva
Hi All, One of the changes done while moving to Git was, moving source code which was under org.wso2.carbon.throttle.core to wso2-synapse. Throttle core is used by both ESB (in Throttle mediator) and by API Manager (in APIThrottleHandler - to keep track of the number of API calls made over the clu