Hi All, I have fixed the JIRA[1] as below.
The bug description suggests to add UsernameWithEmailJavaScriptRegEx property to the default user-mgt.xml. As per the offline discussions I had with Darshana, instead of adding UsernameWithEmailJavaScriptRegEx to the user-mgt.xml the following fix was given. 1. Removed validating username with the hard coded regex constant, when username as email is enabled. 2. Then in this case, first check wether there is a value for the UsernameWithEmailJavaScriptRegEx property defined in user-mgt.xml. If so validate from that regular expression. If there is no regex defined take the default value defined via UsernameJavaRegEx property. 3. There is a validation against regex properties in JDBCUserStoreManager doAuthenticate. In order to preserve the consistency same validation is added to ReadOnlyLDAPUserStoreManager such that when the user logins this validation is invoked. 4. Added error logs for JDBCUserStoreManager when validation fails. The patch is attached with the JIRA[1]. Please review the code and commit. [1] https://wso2.org/jira/browse/IDENTITY-2611 Thanks , Malithi. -- *Malithi Edirisinghe* Senior Software Engineer WSO2 Inc. Mobile : +94 (0) 718176807 malit...@wso2.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
