Hi,
On Tue, May 29, 2012 at 8:11 AM, Amila Suriarachchi wrote:
>
>
> On Mon, May 28, 2012 at 10:21 PM, Anjana Fernando wrote:
>
>> Hi,
>>
>> On Mon, May 28, 2012 at 4:54 PM, Lakmali Baminiwatta wrote:
>>
>>> Hi,
>>>
>>> Here are the review notes.
>>>
>>> When logging in the debug level, check w
Hi Amila,
On Tue, May 29, 2012 at 10:43 AM, Amila Suriarachchi wrote:
>
> This is something we thought as well. But in a web service scenario, web
> service is invoked using the tomcat thread pool. In such a case begin
> transaction and commit may call in different threads. Anyway we need to
> c
On Tue, May 29, 2012 at 9:25 AM, Anjana Fernando wrote:
> Hi Amila,
>
> On Tue, May 29, 2012 at 8:11 AM, Amila Suriarachchi wrote:
>
>>
>> Within the code review we saw that same TransactionManager is being used
>> among different services, threads and tenants.
>>
>> Then we raised the question i
Hi Amila,
On Tue, May 29, 2012 at 8:11 AM, Amila Suriarachchi wrote:
>
> Within the code review we saw that same TransactionManager is being used
> among different services, threads and tenants.
>
> Then we raised the question is this thread safe and secure? According to
> Dinusha and Prabath th
On Mon, May 28, 2012 at 10:21 PM, Anjana Fernando wrote:
> Hi,
>
> On Mon, May 28, 2012 at 4:54 PM, Lakmali Baminiwatta wrote:
>
>> Hi,
>>
>> Here are the review notes.
>>
>> When logging in the debug level, check whether debug is enabled.
>> Log the exceptions before throwing.
>> Create Exceptio
Hi,
On Mon, May 28, 2012 at 4:54 PM, Lakmali Baminiwatta wrote:
> Hi,
>
> Here are the review notes.
>
> When logging in the debug level, check whether debug is enabled.
> Log the exceptions before throwing.
> Create Exception class for TransactionManager and throw that, without
> throwing just E
Hi,
Here are the review notes.
When logging in the debug level, check whether debug is enabled.
Log the exceptions before throwing.
Create Exception class for TransactionManager and throw that, without
throwing just Exceptions.
Check the concurrent level transactions in data services.
Create Tran
