Re: [Dev] Invitation: API Manager Code Review - Tier - User Permission Integration @ Fri Aug 9, 2013 2pm - 3pm (lakm...@wso2.com)

2013-08-13 Thread Sumedha Rubasinghe
Some of these comments can be entered in crucible IMO. On Tue, Aug 13, 2013 at 11:57 AM, Lakmali Baminiwatta wrote: > Hi All, > > Please find the review notes. > > Do the tier permission validation in APIStoreHostobject @addSubscription > as well, to handle direct Store API calls. > > Replace lo

Re: [Dev] Invitation: API Manager Code Review - Tier - User Permission Integration @ Fri Aug 9, 2013 2pm - 3pm (lakm...@wso2.com)

2013-08-12 Thread Lakmali Baminiwatta
Hi All, Please find the review notes. Do the tier permission validation in APIStoreHostobject @addSubscription as well, to handle direct Store API calls. Replace logic of comparison between current roles and defined roles with Lists.retainAll(Collection c) . For displaying default permissions,