Re: [Dev] Please review the PR for ESBJAVA-3384

2015-05-26 Thread Malaka Silva
comment added On Wed, May 27, 2015 at 11:05 AM, Shakila Sivagnanarajah wrote: > Hi Malaka, > > Please find the pull request [1]. > > [1] https://github.com/wso2/wso2-synapse/pull/212/ > > On Tue, May 26, 2015 at 11:08 AM, Malaka Silva wrote: > >> Hi Shakila, >> >> I have reviewed your fix. >> >

Re: [Dev] Please review the PR for ESBJAVA-3384

2015-05-26 Thread Shakila Sivagnanarajah
Hi Malaka, Please find the pull request [1]. [1] https://github.com/wso2/wso2-synapse/pull/212/ On Tue, May 26, 2015 at 11:08 AM, Malaka Silva wrote: > Hi Shakila, > > I have reviewed your fix. > > msgContext.getProperty(PassThroughConstants.FAULTS_AS_HTTP_200).toString() > .toUpperCase()); >

Re: [Dev] Please review the PR for ESBJAVA-3384

2015-05-25 Thread Malaka Silva
Hi Shakila, I have reviewed your fix. msgContext.getProperty(PassThroughConstants.FAULTS_AS_HTTP_200).toString(). toUpperCase()); we need to check msgContext.getProperty(PassThroughConstants.FAULTS_AS_HTTP_200) for null. I think this may throw nullpointer exception if the FAULTS_AS_HTTP_200 pro

Re: [Dev] Please review the PR for ESBJAVA-3384

2015-05-25 Thread Shakila Sivagnanarajah
Hi Malaka, The FAULTS_AS_HTTP_200 property is working fine with the sample [2] with a minor modification [3]. And one mistake in the sample given in the JIRA ticket [1]. It doesn't has FAULTS_AS_HTTP_200 property in inSequence. Find the issue [1]. [1] https://wso2.org/jira/browse/ESBJAVA-3384 [2]

Re: [Dev] Please review the PR for ESBJAVA-3384

2015-05-19 Thread Malaka Silva
Hi Shakila, I don't think this will work if some one added the property mediator in IN_FLOW. Also this sets the status to 200 always. Did you check a scenario where backend sends a status code other than 200 or 500? Please check the code [1] and [2]. Check the method determineHttpStatusCode(). I

[Dev] Please review the PR for ESBJAVA-3384

2015-05-19 Thread Shakila Sivagnanarajah
Hi, I have fixed the issue ESBJAVA-3384. Please find the PR [1]. [1] https://github.com/wso2/wso2-synapse/pull/199 Thank you -- Shakila Sivagnanarajah Associate Software Engineer Mobile :+94 (0) 770 760240 shak...@wso2.com ___ Dev mailing list Dev@wso