Re: [Dev] Revert some pull requests due to API changes

2015-06-02 Thread Manoj Kumara
Created seperate pull request with the reverted changes. Will merge this in a future release. [1] https://github.com/wso2/carbon4-kernel/pull/232 *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Mon, Jun 1, 2015 at 6:10 PM, Manoj K

Re: [Dev] Revert some pull requests due to API changes

2015-06-01 Thread Manoj Kumara
Merged with https://github.com/wso2/carbon4-kernel/pull/230 *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Mon, Jun 1, 2015 at 6:06 PM, Manoj Kumara wrote: > Hi Malaka, > > Thanks for informing. Since this was along with a pull

Re: [Dev] Revert some pull requests due to API changes

2015-06-01 Thread Manoj Kumara
Hi Malaka, Thanks for informing. Since this was along with a pull request which adds some properties to axis I thought this is related to that one as well I'll add the fix and sorry for the inconvenience. Regards, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterpris

Re: [Dev] Revert some pull requests due to API changes

2015-06-01 Thread Malaka Silva
Hi Manoj, Regarding PR [1] Latest fix does not involve an api change. So we can keep this change merged. [1] ] https://github.com/wso2/carbon4-kernel/pull/205/ On Mon, Jun 1, 2015 at 4:31 PM, Manoj Kumara wrote: > Hi All, > > As per conclusion of the discussion [1] we agreed on not to add any

[Dev] Revert some pull requests due to API changes

2015-06-01 Thread Manoj Kumara
Hi All, As per conclusion of the discussion [1] we agreed on not to add any API changes on patch releases. Due to this I will be reverting following pull requests [2], [3], [4], [5] from master branch and these fixes will not be available on Carbon 4.4.1 release. I'll create a separate pull reque