[Dev] SCR version in POM.XML of Platform/Components

2012-05-31 Thread Maheshika Goonetilleke
Hi all I'm in the process of delete the following from the pom.xml as it conflicts while updating the sonar. ex: https://wso2.org/jira/secure/attachment/19017/patch_event.txt -1.0.10 - - -generate-scr-scrdescriptor -

Re: [Dev] SCR version in POM.XML of Platform/Components

2012-06-01 Thread Afkham Azeez
Don't remove this. Dushan did this sometime back & it caused the entire build to fail. We need to investigate & find the proper fix for this. On Fri, Jun 1, 2012 at 12:21 PM, Maheshika Goonetilleke wrote: > Hi all > > I'm in the process of delete the following from the pom.xml as > it conflicts

Re: [Dev] SCR version in POM.XML of Platform/Components

2012-06-01 Thread Afkham Azeez
Did you try to run a full build with integration tests after doing these changes? On Fri, Jun 1, 2012 at 6:20 PM, Afkham Azeez wrote: > Don't remove this. Dushan did this sometime back & it caused the entire > build to fail. We need to investigate & find the proper fix for this. > > > On Fri, Ju

Re: [Dev] SCR version in POM.XML of Platform/Components

2012-06-01 Thread Dushan Abeyruwan
Hi .I am not sure we can commit this unless is absolutely okay *(better not even think of commit at this point ),* I did mistake once, this is a core change and will be very difficult to find the cause if something goes wrong.(btw.She is working on this as instruction provided by Dimuthu), c

Re: [Dev] SCR version in POM.XML of Platform/Components

2012-06-04 Thread Dimuthu Leelarathne
Hi Azeez, AFAIK, what Dushan did was different to this patch. Dushan removed the whole SCR plugin instead of removing the version part. I had an offline chat with AmilaS and he said the version is there because it is copied from some other pom.xml and not because it is required. We'll be committi

Re: [Dev] SCR version in POM.XML of Platform/Components

2012-06-04 Thread Senaka Fernando
Hi Dimuthu, If there aren't any integration test failures reported by any products (in addition to the ones that are already been reported on builder), I don't see any reason to why this would cause any issues. But, someone actually has to run that before committing and validate. Especially those

Re: [Dev] SCR version in POM.XML of Platform/Components

2012-06-04 Thread Maheshika Goonetilleke
On Fri, Jun 1, 2012 at 6:21 PM, Afkham Azeez wrote: > Did you try to run a full build with integration tests after doing these > changes? > > > On Fri, Jun 1, 2012 at 6:20 PM, Afkham Azeez wrote: > >> Don't remove this. Dushan did this sometime back & it caused the entire >> build to fail. We ne