Great! Thanks Anuruddha! I have now merged this pull request to master
branch.
On Thu, Jul 2, 2015 at 10:13 AM, Anuruddha Liyanarachchi
anurudd...@wso2.com wrote:
Hi,
I have now changed the configurator to scan the template module and
validate this with environment variables when read from
Hi,
I have now changed the configurator to scan the template module and
validate this with environment variables when read from environment is true.
Also changed the dictionary define syntax from double quote to square
brackets.
Please review and merge PR [1].
I'm -1 for option 1. This would restrict the Template Module developers on
specifying variable names and they may also not know there is a such
restriction exist.
May be we need to scan the template module and find the list of variable
names. This would also allow us to validate whether the
IMO also we need to scan the template module and validate this with
environment variables. Otherwise we can't make sure we have values for all
the configurations required.
Thanks,
Gayan
On Thu, Jun 25, 2015 at 4:54 PM, Imesh Gunaratne im...@wso2.com wrote:
I'm -1 for option 1. This would
Hi Anuruddha,
I see two options to do this,
1. Mandate to the parameters to be started with CONFIG_PARAMS and pick
those from environment variables, as we discussed offline
2. Scan through the templates and get placeholders to search environment
variables
Wdyt?
Thanks.
On Thu, Jun 25, 2015 at
Hi Imesh,
The current setup is as following:
Configurator check for module.ini and identify all the variables.
(Un-commented variables)
If read from environment is enabled, the values for these variables will be
read from environment variables. If these values are not set as environment
Hi Lahiru,
I think 1st option will be more suitable as we have some logic in side the
templates to check variables are set.
Regards,
Anuruddha
On Thu, Jun 25, 2015 at 1:56 PM, Lahiru Sandaruwan lahi...@wso2.com wrote:
Hi Anuruddha,
I see two options to do this,
1. Mandate to the
Ah.. I see, Thanks.
Shall we make it read those values even if those values are commented in
module.ini?
Thanks.
On Thu, Jun 25, 2015 at 8:14 AM, Anuruddha Liyanarachchi
anurudd...@wso2.com wrote:
Hi Lahiru,
It looks like you haven't un-comment the line in module.ini. You need to
Hi Lahiru,
It looks like you haven't un-comment the line in module.ini. You need to
uncomment the lines relevant to the parameters you are sending as payload,
then only configurator will read those from environment and override the
value with environment value.
Thanks,
On Thu, Jun 25, 2015 at
