Re: [DISCUSS] Removal of configmap update logic via REST API

2022-10-31 Thread Weiwei Yang
+1 Sounds good. The new config consolidation also looks nice, thanks for moving this forward. Some minor comments added to the design doc, we can discuss offline for that. Thanks Weiwei > On Oct 31, 2022, at 9:08 PM, Wilfred Spiegelenburg > wrote: > > +1 I am for removing this functionalit

Re: [DISCUSS] Removal of configmap update logic via REST API

2022-10-31 Thread Wilfred Spiegelenburg
+1 I am for removing this functionality just from a security point alone. The change also includes watching the configmap and reloading directly in the shim [1]. We would no longer rely on the mounted file to be changed by the kubelet. This will also minimise latency between changing and applying

[DISCUSS] Removal of configmap update logic via REST API

2022-10-31 Thread Craig Condit
Hello everyone, I’d like to open a discussion around the idea of removing the current logic that supports writing a new scheduler configuration via the REST API. Currently, this logic is disabled in two different ways (and has been for several releases). First, it is turned off if config auto-r