Based on the feedback I will open a jira around the split of the e2e-tests.
I'll leave the commit limitations off for now and we can revisit in the future.
Wilfred
On Thu, 25 Aug 2022 at 03:45, Weiwei Yang wrote:
>
> Hi Wilfred
>
> Thanks for the proposals. I am
>
> +1 to
>
> e2e-tests:
>
Hi Wilfred
Thanks for the proposals. I am
+1 to
e2e-tests:
needs: build
runs-on: ubuntu-latest
I feel a little concerned about the second proposal. Are we seeing any
issues with today's pipeline that inspire you with this proposal?
On Tue, Aug 23, 2022 at 8:02 AM Craig Condit wrote:
I think I would be +1 on the e2e-after-build proposal, but I’m a strong -1 on
pre-commit enforcement. Due to the interdependencies between our different
modules, there have been (and likely will be again) scenarios where we need to
push multiple changes to get a build back into a “healthy state”
I also just noticed that we run the e2e-tests as part of a push to master.
The push to master must run the unit tests and push the result to
codecov to make sure we see the correct details in the PRs. It should
not run the e2e-tests. The result gets ignored and it wastes
resources.
We have two opt
While looking at the way we run our build jobs at the moment we start
the e2etest job in parallel with the build job of the k8shim. These
tests run for 25-30 minutes. They all get started even if the
compilation fails or we do not pass the unit tests.
Should we not wait for a successful build job b
