[
https://issues.apache.org/jira/browse/YUNIKORN-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang resolved YUNIKORN-388.
----------------------------------
Resolution: Invalid
> "make check-license" passes on travis and fails locally
> -------------------------------------------------------
>
> Key: YUNIKORN-388
> URL: https://issues.apache.org/jira/browse/YUNIKORN-388
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: webapp
> Reporter: Wilfred Spiegelenburg
> Priority: Major
>
> In [web PR#46|https://github.com/apache/incubator-yunikorn-web/pull/46] the
> travis build passes the "make check-license". This same check fails in a
> local build.
> The license check does a simple grep:
> {code}
> grep -Lr --exclude-dir={node_modules,dist}
> --include=*.{sh,md,yaml,yml,js,ts,html,js,scss} "Licensed to the Apache
> Software Foundation" .
> {code}
> However it did fail to pickup the fact that two files with the {{ts}}
> extension that were new did not have a license:
> {code}
> make check-license
> Checking license header
> following files have incorrect license header:
> ./src/app/components/error-view/error-view.component.spec.ts
> ./src/app/components/error-view/error-view.component.ts
> make: *** [check-license] Error 1
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
