[GitHub] zeppelin issue #2544: [ZEPPELIN-2724] Another Attempt to solve the dead lock...

2017-09-11 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/2544 Any updates on this? ---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

2017-09-11 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 If there are no comments anymore, I will merge to master on this pr. ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-09-11 Thread dwhsys
Github user dwhsys commented on the issue: https://github.com/apache/zeppelin/pull/2442 Can someone review please? ---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

2017-09-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2568 @malayhm What about this icon? ![image](https://user-images.githubusercontent.com/4968473/30270278-f62bdcc8-9726-11e7-883a-6204aab6abdb.png) - http://fontawesome.io/icon/bars/

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

2017-09-11 Thread malayhm
Github user malayhm commented on the issue: https://github.com/apache/zeppelin/pull/2568 @1ambda This is generally used for hamburger menu in mobile mode. What do you think about a custom icon like this, this is used on Facebook? ![more-fb](https://user-images.githubuserco

[GitHub] zeppelin issue #2556: [Zeppelin-2839] permissions for folders

2017-09-11 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2556 Ready to review (red for other tests ) ---

[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list

2017-09-11 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2449 Ready to review (red for other tests ) ---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

2017-09-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2578 LGTM, just one concern about `PythonCondaInterpreterTest.java`. It is using mock which may not found potential bugs. I think we can do unit without mock. But anyway this could be done in a followin

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

2017-09-11 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @zjffdu Thank you a lot :) ---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-11 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 This is a hot-fix change. Therefore, they merge quickly. ---

[GitHub] zeppelin pull request #2578: [ZEPPELIN-2921] does not work conda environment...

2017-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2578 ---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

2017-09-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2568 @malayhm it's nice if we can remove `More` text and there is no license problem 👍 ---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

2017-09-11 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2580 ---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

2017-09-11 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2580 [ZEPPELIN-2924] Fix broken javascript source map ### What is this PR for? Fixed broken javascript source map. The coverage loader should be used only for test env. **that's rea

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

2017-09-11 Thread malayhm
Github user malayhm commented on the issue: https://github.com/apache/zeppelin/pull/2568 @1ambda It seems this icon is available in icon finder with free commercial use: https://www.iconfinder.com/icons/476329/continued_detail_details_ellipses_more_icon#size=16 What do yo

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

2017-09-11 Thread malayhm
Github user malayhm commented on the issue: https://github.com/apache/zeppelin/pull/2568 @1ambda Please see the https://user-images.githubusercontent.com/1881135/30287842-2e72d740-9744-11e7-8468-f9a86766487b.png";> new screenshot with the new icon: ---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

2017-09-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2568 @Madhuka Happy to see the icon. I just searched the license but couldn't find the license. It only says "free for commercial usage". Could you check it can be used even in opensource?

[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7

2017-09-11 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2581 Fix/jdbc connection release 0.7 ### What is this PR for? This PR fixes JDBC connection release problem. for example whenever i run not executable command like following ![image

[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7

2017-09-11 Thread astroshim
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2581 ---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2576 Ok I think it's fine then ---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-11 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 @felixcheung Thank you :) ---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-11 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 I will merge to master ---

[GitHub] zeppelin pull request #2576: [hotfix] JDBC connection does not release when ...

2017-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2576 ---

[GitHub] zeppelin pull request #2582: fixed jdbc connection issue.

2017-09-11 Thread astroshim
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2582 fixed jdbc connection issue. ### What is this PR for? This PR fixes JDBC connection release problem. for example whenever i run not executable command like following ![image](h

[GitHub] zeppelin issue #2582: fixed jdbc connection issue.

2017-09-11 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2582 CI fails seems not related to this PR ---