[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

2018-01-14 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2730 Oops, never realize there's such magic, seems no document mention that. But we should not rely on these kinds of magic for most of users. We should provide a default value for most of users that no

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

2018-01-14 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2729 @prabhjyotsingh Could you check this commit ? https://github.com/zjffdu/zeppelin/commit/00bce395f3ed557eb822095f490dae5f8bfd5a23 I tested it locally, and works well. ---

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

2018-01-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2730 `fig.retina` sounds like a good property to play with. However, fixing `out.width` to an arbitrary value may give good result for the example you give, but did you try with other plots?

[GitHub] zeppelin pull request #2730: ZEPPELIN-3166. R plotting resolution and image ...

2018-01-14 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2730 ZEPPELIN-3166. R plotting resolution and image width is not proper ### What is this PR for? Change the resolution and image width, because the previous default value is not proper. By

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

2018-01-14 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2730 @felixcheung @echarles Could you help review it ? Thanks ---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

2018-01-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2729 @zjffdu That "calculation" looks like a bigger change and might change the content of notebook as well. ---

[jira] [Created] (ZEPPELIN-3166) R plotting resolution is not proper

2018-01-14 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-3166: Summary: R plotting resolution is not proper Key: ZEPPELIN-3166 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3166 Project: Zeppelin Issue Type: Bug