[GitHub] zeppelin pull request #2729: [ZEPPELIN-2826] support for carriage return '\r...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2729 ---

[GitHub] zeppelin pull request #2730: ZEPPELIN-3166. R plotting resolution and image ...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2730 ---

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2730 Thanks @echarles will merge if no more comments ---

[GitHub] zeppelin pull request #2728: ZEPPELIN-3104. Support Hadoop 3.0

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2728 ---

[GitHub] zeppelin issue #2712: ZEPPELIN-2742. Unify Zeppelin's Config Storage

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2712 Merge if no more comments ---

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2730 GTM ---

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2730 @echarles I am fine to keep image width as 100%. But setting `fig.retina=2` is necessary, otherwise the image displayed is so unclear. See below comparison (use both ggplot2 and R base plotting)

[GitHub] zeppelin issue #2728: ZEPPELIN-3104. Support Hadoop 3.0

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2728 Merge if no more comments ---

[GitHub] zeppelin pull request #2726: ZEPPELIN-3009. Don't iterate all the properties...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2726 ---

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Improve code style check

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2727 Hmm, make sense. Enable the import order checking ---

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

Github user RoxanaTapia commented on the issue: https://github.com/apache/zeppelin/pull/1694 @AhyoungRyu Can somebody have a look in the ticket? I was wondering if changing the role value to something else would help, until now all of them are * (e.g. admin = *, user= *) can I gran on

[jira] [Created] (ZEPPELIN-3168) Add Interpreter Settings Authorization feature

Nelson Costa created ZEPPELIN-3168: -- Summary: Add Interpreter Settings Authorization feature Key: ZEPPELIN-3168 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3168 Project: Zeppelin Iss

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Add code style check

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2727 Just update the PR to make diff more readable. @felixcheung ---

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Add code style check

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2727 I didn't check all the rules one by one. Just copy the checkstyle from spark project and remove some spark specific thing. Things like Indentation & UnusedImports is changed. ---

[jira] [Created] (ZEPPELIN-3167) SparkRInterpreter always return SUCCESS

Jeff Zhang created ZEPPELIN-3167: Summary: SparkRInterpreter always return SUCCESS Key: ZEPPELIN-3167 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3167 Project: Zeppelin Issue Type: Bu

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2729 Thanks for the review will merge this if no more discussion. ---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2729 Thanks @prabhjyotsingh The PR LGTM overall ---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2729 That works well, have merged that commit to this PR. ---

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2730 Agree, but the default will always find case where it will not work. For this image size / resolution, there may be more failure than success I am afraid. To be tested with various plots, screen