[GitHub] [zeppelin] bhavikpatel9977 commented on issue #3443: [ZEPPELIN-4311] Supporting new parser for markdown as pegdown parser …

2019-09-17 Thread GitBox
bhavikpatel9977 commented on issue #3443: [ZEPPELIN-4311] Supporting new parser for markdown as pegdown parser … URL: https://github.com/apache/zeppelin/pull/3443#issuecomment-532533921 > also is there a risk of javascript getting injected this way? This risk was already there, will

[GitHub] [zeppelin] bhavikpatel9977 commented on issue #3443: [ZEPPELIN-4311] Supporting new parser for markdown as pegdown parser …

2019-09-17 Thread GitBox
bhavikpatel9977 commented on issue #3443: [ZEPPELIN-4311] Supporting new parser for markdown as pegdown parser … URL: https://github.com/apache/zeppelin/pull/3443#issuecomment-532533228 @zjffdu / @felixcheung / @prabhjyotsingh : CI build got successful, and one which is failing which is un

[GitHub] [zeppelin] asfgit closed pull request #3422: [ZEPPELIN-4273] Support Flink 1.9 for Flink Interpreter

2019-09-17 Thread GitBox
asfgit closed pull request #3422: [ZEPPELIN-4273] Support Flink 1.9 for Flink Interpreter URL: https://github.com/apache/zeppelin/pull/3422 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] asfgit closed pull request #3448: [ZEPPELIN-4322] Flaky test: NotebookRestApiTest#testRunWithServerRestart

2019-09-17 Thread GitBox
asfgit closed pull request #3448: [ZEPPELIN-4322] Flaky test: NotebookRestApiTest#testRunWithServerRestart URL: https://github.com/apache/zeppelin/pull/3448 This is an automated message from the Apache Git Service. To respon

Re: Why do we need change_scala_version.sh?

2019-09-17 Thread Jeff Zhang
I think this is legacy thing, because some interpreter depends on specific scala version before (e.g. spark interpreter). But now user can run spark interpreter under different versions of scala version without building it with specific scala version. Our final goal is to make all interpreters scal

[GitHub] [zeppelin] zjffdu commented on issue #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0)

2019-09-17 Thread GitBox
zjffdu commented on issue #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0) URL: https://github.com/apache/zeppelin/pull/3450#issuecomment-532482471 LGTM This is an automated message from

[jira] [Created] (ZEPPELIN-4334) JVM Option Change.

2019-09-17 Thread kuckhwancho (Jira)
kuckhwancho created ZEPPELIN-4334: - Summary: JVM Option Change. Key: ZEPPELIN-4334 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4334 Project: Zeppelin Issue Type: Improvement Affec

[GitHub] [zeppelin] Leemoonsoo closed pull request #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0)

2019-09-17 Thread GitBox
Leemoonsoo closed pull request #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0) URL: https://github.com/apache/zeppelin/pull/3450 This is an automated message from the Apache Git Servic

[GitHub] [zeppelin] Leemoonsoo opened a new pull request #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0)

2019-09-17 Thread GitBox
Leemoonsoo opened a new pull request #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0) URL: https://github.com/apache/zeppelin/pull/3450 ### What is this PR for? This PR changes default Zeppelin server binding address from `0.0.0.0` to `127.0.0.1`.

[GitHub] [zeppelin] Leemoonsoo commented on issue #3448: [ZEPPELIN-4322] Flaky test: NotebookRestApiTest#testRunWithServerRestart

2019-09-17 Thread GitBox
Leemoonsoo commented on issue #3448: [ZEPPELIN-4322] Flaky test: NotebookRestApiTest#testRunWithServerRestart URL: https://github.com/apache/zeppelin/pull/3448#issuecomment-532428190 LGTM This is an automated message from the

[GitHub] [zeppelin] Leemoonsoo opened a new pull request #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0)

2019-09-17 Thread GitBox
Leemoonsoo opened a new pull request #3450: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0) URL: https://github.com/apache/zeppelin/pull/3450 ### What is this PR for? This PR changes default Zeppelin server binding address from `0.0.0.0` to `127.0.0.1`.

Why do we need change_scala_version.sh?

2019-09-17 Thread Dagang Wei
Hi folks, I am new to Zeppelin and when building it I found the change_scala_version.sh script which modifies pom xml files before running the build, I am wondering why do we need it? Cannot we use Maven properties for it?

[GitHub] [zeppelin] Leemoonsoo opened a new pull request #3449: [ZEPPELIN-4333] escape dialog title and message

2019-09-17 Thread GitBox
Leemoonsoo opened a new pull request #3449: [ZEPPELIN-4333] escape dialog title and message URL: https://github.com/apache/zeppelin/pull/3449 ### What is this PR for? There're couple of places in the code that dialog title and message is not being escaped ### What type of PR

[jira] [Created] (ZEPPELIN-4333) Escape popup dialog title and message

2019-09-17 Thread Lee moon soo (Jira)
Lee moon soo created ZEPPELIN-4333: -- Summary: Escape popup dialog title and message Key: ZEPPELIN-4333 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4333 Project: Zeppelin Issue Type:

[GitHub] [zeppelin] mwkang removed a comment on issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission

2019-09-17 Thread GitBox
mwkang removed a comment on issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission URL: https://github.com/apache/zeppelin/pull/1330#issuecomment-247754150 I'm sorry for no-reply long time. my plate was full. I will finish other 2 PRs and

[GitHub] [zeppelin] liuxunorg commented on issue #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

2019-09-17 Thread GitBox
liuxunorg commented on issue #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter URL: https://github.com/apache/zeppelin/pull/3445#issuecomment-532254498 [CI Pass](https://travis-ci.org/liuxunorg/zeppelin/builds/585958134) --

[jira] [Created] (ZEPPELIN-4332) Linkage error of bare-metal zeppelin to flink on k8s

2019-09-17 Thread Lewin Ma (Jira)
Lewin Ma created ZEPPELIN-4332: -- Summary: Linkage error of bare-metal zeppelin to flink on k8s Key: ZEPPELIN-4332 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4332 Project: Zeppelin Issue

[GitHub] [zeppelin] zjffdu opened a new pull request #3448: [ZEPPELIN-4322] Flaky test: NotebookRestApiTest#testRunWithServerRestart

2019-09-17 Thread GitBox
zjffdu opened a new pull request #3448: [ZEPPELIN-4322] Flaky test: NotebookRestApiTest#testRunWithServerRestart URL: https://github.com/apache/zeppelin/pull/3448 ### What is this PR for? The root cause of this flaky test is due to that the note may be removed when paragraph job is stil

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

2019-09-17 Thread GitBox
liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325048782 ## File path: zeppelin-plugins/launcher/docker/src/main/java/

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

2019-09-17 Thread GitBox
liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325047375 ## File path: zeppelin-plugins/launcher/docker/src/main/java/

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

2019-09-17 Thread GitBox
zjffdu commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325024026 ## File path: zeppelin-plugins/launcher/docker/src/main/java/org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3446: ZEPPELIN-4329 fix building Scio with Scala 2.11

2019-09-17 Thread GitBox
zjffdu commented on a change in pull request #3446: ZEPPELIN-4329 fix building Scio with Scala 2.11 URL: https://github.com/apache/zeppelin/pull/3446#discussion_r325023594 ## File path: pom.xml ## @@ -95,8 +95,10 @@ 1.8 -2.10.5 +2.10.5 Review comm

[GitHub] [zeppelin] alexott commented on a change in pull request #3446: ZEPPELIN-4329 fix building Scio with Scala 2.11

2019-09-17 Thread GitBox
alexott commented on a change in pull request #3446: ZEPPELIN-4329 fix building Scio with Scala 2.11 URL: https://github.com/apache/zeppelin/pull/3446#discussion_r325018220 ## File path: pom.xml ## @@ -95,8 +95,10 @@ 1.8 -2.10.5 +2.10.5 Review com

[GitHub] [zeppelin] liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

2019-09-17 Thread GitBox
liuxunorg commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325015375 ## File path: zeppelin-plugins/launcher/docker/src/main/java/

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3446: ZEPPELIN-4329 fix building Scio with Scala 2.11

2019-09-17 Thread GitBox
zjffdu commented on a change in pull request #3446: ZEPPELIN-4329 fix building Scio with Scala 2.11 URL: https://github.com/apache/zeppelin/pull/3446#discussion_r325014331 ## File path: pom.xml ## @@ -95,8 +95,10 @@ 1.8 -2.10.5 +2.10.5 Review comm

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

2019-09-17 Thread GitBox
zjffdu commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325013103 ## File path: zeppelin-plugins/launcher/docker/src/main/java/org

[GitHub] [zeppelin] zjffdu commented on issue #3422: [ZEPPELIN-4273] Support Flink 1.9 for Flink Interpreter

2019-09-17 Thread GitBox
zjffdu commented on issue #3422: [ZEPPELIN-4273] Support Flink 1.9 for Flink Interpreter URL: https://github.com/apache/zeppelin/pull/3422#issuecomment-532092712 Will merge if no more comments This is an automated message fro

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3422: [ZEPPELIN-4273] Support Flink 1.9 for Flink Interpreter

2019-09-17 Thread GitBox
zjffdu commented on a change in pull request #3422: [ZEPPELIN-4273] Support Flink 1.9 for Flink Interpreter URL: https://github.com/apache/zeppelin/pull/3422#discussion_r325011624 ## File path: flink/pom.xml ## @@ -37,11 +37,14 @@ flink -1.7.1 -2.3.7