asfgit closed pull request #4040:
URL: https://github.com/apache/zeppelin/pull/4040
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
prabhjyotsingh commented on pull request #4041:
URL: https://github.com/apache/zeppelin/pull/4041#issuecomment-774399506
@zjffdu can you help review this.
This is an automated message from the Apache Git Service.
To respond t
prabhjyotsingh commented on pull request #4045:
URL: https://github.com/apache/zeppelin/pull/4045#issuecomment-774399346
Thanks for the review will merge this if no more discussion.
This is an automated message from the Apach
fforever14 commented on pull request #4016:
URL: https://github.com/apache/zeppelin/pull/4016#issuecomment-774360385
the same as before:
> mvn package -pl flink/interpreter -am -Pflink-111
-Dmaven.gitcommitid.skip=true
---
zjffdu opened a new pull request #4047:
URL: https://github.com/apache/zeppelin/pull/4047
### What is this PR for?
Trivial PR to resolve the ConcurrentModificationException by using
ConcurrentMap instead of Map
### What type of PR is it?
[Bug Fix]
### Todos
*
Reamer commented on pull request #4037:
URL: https://github.com/apache/zeppelin/pull/4037#issuecomment-774064933
The changes look good to me. But CI fails because of checkstyle.
This is an automated message from the Apache Gi
Jeff Zhang created ZEPPELIN-5237:
Summary: ConcurrentModificationException in Notebook.getNotesInfo
Key: ZEPPELIN-5237
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5237
Project: Zeppelin
zjffdu commented on pull request #4035:
URL: https://github.com/apache/zeppelin/pull/4035#issuecomment-774049322
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Reamer commented on a change in pull request #4035:
URL: https://github.com/apache/zeppelin/pull/4035#discussion_r570981085
##
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##
@@ -0,0 +1,234 @@
+/*
+ * Licens
asfgit closed pull request #4039:
URL: https://github.com/apache/zeppelin/pull/4039
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zjffdu opened a new pull request #4046:
URL: https://github.com/apache/zeppelin/pull/4046
### What is this PR for?
Use ConcurrentHashMap instead of HashMap, and add synchronized to method
`saveNoteAuth`, because maybe multiple thread save NoteAuth at the same time.
###
prabhjyotsingh commented on pull request #4045:
URL: https://github.com/apache/zeppelin/pull/4045#issuecomment-773211578
@zjffdu can you help review this one.
This is an automated message from the Apache Git Service.
To resp
zjffdu commented on pull request #4045:
URL: https://github.com/apache/zeppelin/pull/4045#issuecomment-773772187
LGTM, thanks @prabhjyotsingh Let's wait for its CI pass
This is an automated message from the Apache Git Service
zjffdu commented on pull request #4040:
URL: https://github.com/apache/zeppelin/pull/4040#issuecomment-773685337
Will merge if no more comment
This is an automated message from the Apache Git Service.
To respond to the messag
zjffdu commented on a change in pull request #4035:
URL: https://github.com/apache/zeppelin/pull/4035#discussion_r570639170
##
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##
@@ -0,0 +1,234 @@
+/*
+ * Licens
zjffdu commented on a change in pull request #4037:
URL: https://github.com/apache/zeppelin/pull/4037#discussion_r570735715
##
File path: shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java
##
@@ -78,6 +106,10 @@ public void close() {
}
}
}
prabhjyotsingh commented on pull request #4041:
URL: https://github.com/apache/zeppelin/pull/4041#issuecomment-773149708
@zjffdu sure that makes sense, have just added the same.
This is an automated message from the Apache G
zjffdu commented on pull request #4042:
URL: https://github.com/apache/zeppelin/pull/4042#issuecomment-773685421
Will merge if no more comment
This is an automated message from the Apache Git Service.
To respond to the messag
asfgit closed pull request #4038:
URL: https://github.com/apache/zeppelin/pull/4038
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zjffdu commented on pull request #4039:
URL: https://github.com/apache/zeppelin/pull/4039#issuecomment-773685690
Will merge if no more comment
This is an automated message from the Apache Git Service.
To respond to the messag
asfgit closed pull request #4042:
URL: https://github.com/apache/zeppelin/pull/4042
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Reamer commented on pull request #4035:
URL: https://github.com/apache/zeppelin/pull/4035#issuecomment-773321274
CI passed. I will merge this into master and branch-0.9 on Monday 08.02.2021
if no further comments are received.
--
22 matches
Mail list logo
