[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-08 Thread GitBox
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1343912407 > Really great work. I only noted one small thing. > The bigger problem is that currently core-modules are no longer passing in the CI system, so we need to fix the error that occurs

[GitHub] [zeppelin] Reamer merged pull request #4534: [Minor][ZEPPELIN-5859] Fixing the styling issue

2022-12-08 Thread GitBox
Reamer merged PR #4534: URL: https://github.com/apache/zeppelin/pull/4534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] infoankitp commented on pull request #4534: [Minor][ZEPPELIN-5859] Fixing the styling issue

2022-12-08 Thread GitBox
infoankitp commented on PR #4534: URL: https://github.com/apache/zeppelin/pull/4534#issuecomment-1343832225 @Reamer Please help re-review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Created] (ZEPPELIN-5865) Web optimization proposals

2022-12-08 Thread Changjun Zhang (Jira)
Changjun Zhang created ZEPPELIN-5865: Summary: Web optimization proposals Key: ZEPPELIN-5865 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5865 Project: Zeppelin Issue Type: Improve

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4520: [MINOR] Fix Appveyor error

2022-12-08 Thread GitBox
jongyoul commented on code in PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#discussion_r1043970325 ## pom.xml: ## @@ -1585,6 +1585,14 @@ net.alchim31.maven scala-maven-plugin ${plugin.scala.alchim31.version} + Review Comm

[jira] [Created] (ZEPPELIN-5864) Clean up scala complie options

2022-12-08 Thread Jongyoul Lee (Jira)
Jongyoul Lee created ZEPPELIN-5864: -- Summary: Clean up scala complie options Key: ZEPPELIN-5864 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5864 Project: Zeppelin Issue Type: Improve

[GitHub] [zeppelin] zenozeng commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-12-08 Thread GitBox
zenozeng commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1343483428 Looking forward to this patch +1. BTW, I have manually tested this PR on flink 1.16, it worked as expected in all my use cases. 👍 -- This is an automated message from the Apache Gi

[GitHub] [zeppelin] halfvector commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-12-08 Thread GitBox
halfvector commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1343035090 Looking forward to this patch, thank you for starting it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine

2022-12-08 Thread GitBox
Reamer commented on code in PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#discussion_r1043276481 ## zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java: ## @@ -46,66 +46,66 @@ public void getAllowedOrigins2Test() throws Malformed

[GitHub] [zeppelin] Reamer commented on pull request #4534: [Minor][ZEPPELIN-5859] Fixing the styling issue

2022-12-08 Thread GitBox
Reamer commented on PR #4534: URL: https://github.com/apache/zeppelin/pull/4534#issuecomment-1342615029 Looks better. But let's wait for the CI system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [zeppelin] infoankitp commented on pull request #4534: [Minor][ZEPPELIN-5859] Fixing the styling issue

2022-12-08 Thread GitBox
infoankitp commented on PR #4534: URL: https://github.com/apache/zeppelin/pull/4534#issuecomment-1342582750 > Still checkstyle error. Check CI-Job core / interpreter-test-non-core Yes ! Just noticed ! Have fixed it ! I think should be fixed now. -- This is an automated message from

[GitHub] [zeppelin] infoankitp commented on a diff in pull request #4524: [ZEPPELIN-5859] Upgrading alluxio client library to latest stable release 2.9.0

2022-12-08 Thread GitBox
infoankitp commented on code in PR #4524: URL: https://github.com/apache/zeppelin/pull/4524#discussion_r1043098647 ## alluxio/src/main/java/org/apache/zeppelin/alluxio/AlluxioInterpreter.java: ## @@ -76,17 +76,21 @@ public AlluxioInterpreter(Properties property) { alluxioMa

[GitHub] [zeppelin] infoankitp opened a new pull request, #4534: [Minor][ZEPPELIN-5859] Fixing the styling issue

2022-12-08 Thread GitBox
infoankitp opened a new pull request, #4534: URL: https://github.com/apache/zeppelin/pull/4534 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/co