[GitHub] [zeppelin] zjffdu commented on pull request #4579: [ZEPPELIN-5893] Dev zeppelin client bug

2023-04-21 Thread via GitHub
zjffdu commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1518472971 @xiaomin0322 Could you update the jira title to be more specific? `Dev zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when getting progress from paragraphJs

[jira] [Created] (ZEPPELIN-5902) Support Spark 3.4

2023-04-21 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5902: Summary: Support Spark 3.4 Key: ZEPPELIN-5902 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5902 Project: Zeppelin Issue Type: Improvement Co

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4585: Bump spark-core_2.12 from 3.1.2 to 3.4.0 in /spark/interpreter

2023-04-21 Thread via GitHub
dependabot[bot] opened a new pull request, #4585: URL: https://github.com/apache/zeppelin/pull/4585 Bumps spark-core_2.12 from 3.1.2 to 3.4.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.spark:spa

[jira] [Created] (ZEPPELIN-5901) Pod launch fails when user name has special char.

2023-04-21 Thread Jeet (Jira)
Jeet created ZEPPELIN-5901: -- Summary: Pod launch fails when user name has special char. Key: ZEPPELIN-5901 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5901 Project: Zeppelin Issue Type: Bug

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173980444 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,11 +89,14 @@ public void run() { runningJob = queue.take(

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173974707 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -82,10 +88,11 @@ public void runJobInScheduler(Job job) { * RUNNING stat

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173972774 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -53,22 +55,26 @@ public void runJobInScheduler(Job job) { remot

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173962995 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java: ## @@ -34,14 +36,14 @@ public class RemoteScheduler extends AbstractScheduler {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173961893 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java: ## @@ -342,17 +341,14 @@ public Scheduler getScheduler() { // runn

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173959970 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java: ## @@ -70,6 +70,14 @@ public boolean isPending() { public boolean isCompleted() {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173957427 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -133,21 +134,14 @@ protected void runJob(Job runningJob) { Object

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,6 +89,7 @@ public void run() { runningJob = queue.take();

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on code in PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java: ## @@ -89,6 +89,7 @@ public void run() { runningJob = queue.take();

[GitHub] [zeppelin] Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter

2023-04-21 Thread via GitHub
Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter URL: https://github.com/apache/zeppelin/pull/4584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1518056388 As this PR changes a very important component of Zeppelin, I need an accurate review. If you want me to describe the changes in more detail, please let me know. -- This is an automated

[GitHub] [zeppelin] Samrat002 opened a new pull request, #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter

2023-04-21 Thread via GitHub
Samrat002 opened a new pull request, #4584: URL: https://github.com/apache/zeppelin/pull/4584 ### What is this PR for? - It introduces new flink 1.17.0 interpreter support in zeppelin. - Flink-1.17 is [released](https://flink.apache.org/2023/03/23/announcing-the-release-of-apache-flin

[GitHub] [zeppelin] Reamer opened a new pull request, #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest

2023-04-21 Thread via GitHub
Reamer opened a new pull request, #4582: URL: https://github.com/apache/zeppelin/pull/4582 ### What is this PR for? This PR changes the RemoteScheduler The main change is the executor of the RemoteScheduler. It's now a separate FIFO Executor (one Thread). As a result, jobs are now queu

[jira] [Created] (ZEPPELIN-5900) Fix RemoteSchedulerTest.testAbortOnPending

2023-04-21 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5900: Summary: Fix RemoteSchedulerTest.testAbortOnPending Key: ZEPPELIN-5900 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5900 Project: Zeppelin Iss

[GitHub] [zeppelin] Reamer commented on pull request #4581: Sanitize user labels for k8s

2023-04-21 Thread via GitHub
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1517384284 Hello @grizzly-monkey, thanks for your Pull Request. We already have a sanitize method. Have a look at `K8sUtils:generateK8sName`. Please use this method or adapt the method to your